SChernykh
e52802baef
Wallet2: fix optimize-coinbase for p2pool payouts
...
RefreshOptimizeCoinbase was an optimization to speed up scanning of coinbase transactions before RingCT (tx version 2) where they split miner reward into multiple denominations, all to the same wallet.
When RingCT was introduced, all coinbase transactions became 1 output only, so this optimization does nothing now.
With p2pool, this optimization will skip scanning p2pool payouts because they use more than 1 output in coinbase transaction.
Fix it by applying this optimization only to pre-RingCT transactions (version < 2).
2021-08-26 11:50:15 +02:00
luigi1111
8b9eea92f1
Merge pull request #7849
...
6f15a0c
2021-08-20 16:49:59 -04:00
luigi1111
1b079e5195
Merge pull request #7845
...
e1af8dc
2021-08-20 16:45:15 -04:00
luigi1111
5812b757e0
Merge pull request #7821
...
da2955f
2021-08-20 16:33:53 -04:00
Kermit Alexander II
24d3d65d42
monero-wallet-rpc: Prevent --password-file from being used with --wallet-dir
2021-08-20 08:54:41 -05:00
j-berman
e1af8dc02c
Protect client from divide by 0 caused by integer truncation
2021-08-19 14:56:36 -07:00
j-berman
da2955feae
Apply gamma distr from chain tip when selecting decoys
...
- matches the paper by Miller et al to apply the gamma from chain tip, rather than after unlock time
- if the gamma produces an output more recent than the unlock time, the algo packs that output into one of the first 50 spendable blocks, respecting the block density factor
2021-08-19 14:51:20 -07:00
luigi1111
62844a776d
Merge pull request #7786
...
9c6e094fix #7784 - deinit wallet in wallet dtor (Dusan Klinec)
2021-08-11 22:30:11 -04:00
j-berman
6f15a0c8d3
Make sure node returns to wallet that real output is unlocked
2021-08-11 07:28:10 -07:00
Dusan Klinec
13a8a576ed
trezor: try empty passphrase first
...
- Try empty passphrase first when opening a wallet, as all Trezors will have passphrase enabled by default by Trezor Suite by default.
This feature enables easier access to all users using disabled passphrase (or empty passhprase)
- If wallet address differs from device address with empty passphrase, another opening attempt is made, without passphrase suppression,
so user can enter his passhprase if using some. In this scenario, nothing changes to user, wallet opening just consumes one more call
to Trezor (get wallet address with empty passphrase)
- also change how m_passphrase is used. Previous version did not work well with recent passphrase entry mechanism change (made in Trezor),
thus this commit fixes the behaviour).
2021-08-03 13:54:04 +02:00
luigi1111
ed506006d2
Merge pull request #7796
...
0c6e1d3
2021-08-02 18:54:46 -04:00
luigi1111
eeda76570c
Merge pull request #7790
...
bc8d764
2021-08-02 18:53:05 -04:00
luigi1111
8c41d14ad5
Merge pull request #7788
...
f5eb2ce
2021-08-02 18:50:25 -04:00
luigi1111
9aa2d4c16e
Merge pull request #7747
...
8cf95c8
2021-08-02 18:42:32 -04:00
luigi1111
2d5b8a6ff7
Merge pull request #7740
...
8cea9d8
2021-07-27 16:55:14 -04:00
moneromooo-monero
0c6e1d343e
wallet2: chunk get_outs.bin calls to avoid sanity limits
2021-07-15 17:25:07 +00:00
tobtoht
f5eb2ce968
wallet2: Don't auto lock device on process parsed blocks
2021-07-14 13:02:54 +02:00
Dusan Klinec
bc8d7644d2
wallet: rephrase error message on invalid device address
2021-07-14 11:02:29 +02:00
Dusan Klinec
9c6e0941cb
fix #7784 - deinit wallet in wallet dtor
2021-07-14 10:46:16 +02:00
luigi1111
7499837a6f
Merge pull request #7661
...
08e4497
2021-06-10 12:00:54 -05:00
luigi1111
a1a3e970f7
Merge pull request #7662
...
4da1112
2021-06-10 11:34:20 -05:00
tobtoht
8cf95c8f29
wallet2: refresh: check error and throw before potentially breaking out of loop
2021-06-04 18:37:06 +02:00
tobtoht
8cea9d8605
wallet: Reset RPC Pay ID on node switch
...
RPC pay client ID is sent with each RPC request, set a new secret every time we switch nodes to mitigate trivial correlation
2021-06-04 13:58:09 +02:00
luigi1111
628c04499b
Merge pull request #7682
...
bbdb612
2021-05-12 15:30:34 -05:00
rbrunner7
bbdb612b51
Wallet2: Update 'approximate_testnet_rolled_back_blocks'
2021-04-25 10:20:39 +02:00
Nathan Dorfman
c57ef7f807
wallet2: Fix rescan_bc keep_ki option
2021-04-23 09:11:45 -06:00
luigi1111
9bba3f4767
Merge pull request #7651
...
c8ff1d4
2021-04-22 01:35:20 -04:00
mj-xmr
dc81e23e60
Split epee/string_tools.h and encapsulate boost::lexical_cast
2021-04-16 20:54:20 +02:00
moneromooo-monero
4da1112967
rpc: send confirmations in get_transactions result
...
if the wallet does it, it would get a wrong result (possibly even
negative) if its local chain is not synced up to the daemon's yet
2021-04-15 15:31:52 +00:00
Elliot Wirrick
c8ff1d4d23
monero-wallet-cli: improve error message when tx amount is zero
2021-04-07 10:10:16 -04:00
luigi1111
2098941ca0
Merge pull request #7635
...
447bfae
2021-04-06 12:23:45 -05:00
moneromooo-monero
447bfae2a4
wallet2: fix unlocked mixup in light wallet mode
2021-03-25 09:33:40 +00:00
moneromooo-monero
f9b5b521e8
fix serialization being different on mac
...
On Mac, size_t is a distinct type from uint64_t, and some
types (in wallet cache as well as cold/hot wallet transfer
data) use pairs/containers with size_t as fields. Mac would
save those as full size, while other platforms would save
them as varints. Might apply to other platforms where the
types are distinct.
There's a nasty hack for backward compatibility, which can
go after a couple forks.
2021-03-05 23:42:33 +00:00
luigi1111
6556c33f13
Merge pull request #7355
...
bd129841572df9
2021-02-18 14:06:47 -05:00
luigi1111
ce5800a225
Merge pull request #7346
...
85db173
2021-02-18 14:03:31 -05:00
luigi1111
0e35d46f5e
Merge pull request #7341
...
b587ffa
2021-02-18 14:02:13 -05:00
luigi1111
3f55f7df31
Merge pull request #7312
...
186271e
2021-02-18 14:00:35 -05:00
Horia Mihai David
186271e5d1
monero-wallet-cli: Added command scan_tx
...
To implement this feature, the wallet2::scan_tx API was implemented.
2021-02-17 20:25:55 +01:00
luigi1111
4ee301c687
Merge pull request #6986
...
ee58f4f
2021-02-15 21:36:48 -05:00
Kevin Barbour
85db1734e7
Remove unused variables in monero codebase
...
There are quite a few variables in the code that are no longer
(or perhaps never were) in use. These were discovered by enabling
compiler warnings for unused variables and cleaning them up.
In most cases where the unused variables were the result
of a function call the call was left but the variable
assignment removed, unless it was obvious that it was
a simple getter with no side effects.
2021-02-09 08:05:05 +01:00
Lee Clagett
1572df9e26
Removing unused namespace alias
2021-01-28 23:40:57 -05:00
Alex Opie
520ce1ca81
Attempt to carve the fee from a partial payment early
...
Do this for both the estimate and actual fee.
#7337
2021-01-25 12:01:27 +13:00
Alex Opie
b587ffa1fd
Stop adding more outputs than bulletproof allows
...
If more outputs are requested, they are split across
multiple transactions.
#7322
2021-01-25 10:01:38 +13:00
Lee Clagett
08e4497c6e
Improve cryptonote (block and tx) binary read performance
2021-01-23 06:23:39 +00:00
moneromooo-monero
d2fda6c25f
restrict public node checks a little
...
do not include blocked hosts in peer lists or public node lists by default,
warn about no https on clearnet and about untrusted peers likely being spies
2020-12-22 23:39:07 +00:00
woodser
ee58f4f766
Balance includes unconfirmed payments
2020-11-06 15:08:43 -05:00
Lee Clagett
7414e2bac1
Change epee binary output from std::stringstream to byte_stream
2020-10-10 15:28:40 +00:00
Alexander Blair
6b8db83149
Merge pull request #7043
...
17c537039
2020-12-04 13:25:01 -08:00
selsta
89bbb802c0
wallet2: set propagation timeout to current max timeout
2020-12-03 02:18:58 +01:00
Alexander Blair
438442ace0
Merge pull request #6890
...
ec14e4b8c
2020-12-01 14:18:22 -08:00
Crypto City
17c5370398
wallet2: check imported multisig curve points are in main subgroup
2020-11-24 16:25:35 +00:00
xiphon
fc2f97177b
wallet2: wait for propagation timeout before marking tx as failed
2020-10-18 14:00:56 +00:00
xiphon
ec14e4b8cd
wallet2: skip reorgs exceeding max-reorg-depth wallet setting
2020-10-13 15:23:35 +00:00
moneromooo-monero
b6c4f8cd54
fix a couple bugs found by OSS-fuzz
...
- index out of bounds when importing outputs
- accessing invalid CLSAG data
2020-09-24 15:30:38 +00:00
luigi1111
2b1488ef6f
Merge pull request #6793
...
de9a9fb
2020-09-15 19:56:49 -05:00
TheCharlatan
80e535c95a
wallet2: adapt to deterministic unlock time
2020-09-15 11:40:31 +00:00
luigi1111
9bba1a24ea
Merge pull request #6815
...
ef4325f
2020-09-14 11:47:06 -05:00
moneromooo-monero
ef4325fd41
wallet2: fix tx sanity check triggering on pre-rct outputs
2020-09-12 17:51:41 +00:00
Reinaldulin
a3844e257e
Fix typo in command line argument description
2020-09-09 10:18:32 -04:00
luigi1111
fd657c7706
Merge pull request #6798
...
4e44306
2020-09-07 14:30:41 -05:00
Dusan Klinec
4e4430603f
enable CLSAG support for Trezor client
2020-09-04 01:24:58 +02:00
luigi1111
ee0b02d0db
Merge pull request #6757
...
6a37da8
2020-09-03 12:25:59 -05:00
woodser
de9a9fb340
update error message "No unlocked balance in the specified account"
2020-09-01 17:30:00 -04:00
moneromooo-monero
6a37da837e
threadpool: guard against exceptions in jobs, and armour plating
...
Those would, if uncaught, exit run and leave the waiter to wait
indefinitely for the number of active jobs to reach 0
2020-09-01 14:33:33 +00:00
Sarang Noether
fa06c39d97
Bind signature to full address and signing mode
2020-08-28 19:38:00 -04:00
moneromooo-monero
743608ec16
wallet: allow signing a message with spend or view key
2020-08-28 19:25:17 -04:00
moneromooo-monero
82ee01699c
Integrate CLSAGs into monero
...
They are allowed from v12, and MLSAGs are rejected from v13.
2020-08-27 12:44:04 +00:00
Alexander Blair
4fe2858b4d
Merge pull request #6746
...
20f603c6b
2020-08-27 02:58:53 -07:00
Alexander Blair
a06c83db73
Merge pull request #6752
...
85899230de916201f1
2020-08-27 02:58:23 -07:00
Alexander Blair
42519b48a7
Merge pull request #6731
...
db5d6e460
2020-08-27 02:55:48 -07:00
Alexander Blair
bad5d8d6f0
Merge pull request #6690
...
7175dcb10
2020-08-27 02:54:30 -07:00
luigi1111
765db1ae7a
Revert "Use domain-separated ChaCha20 for in-memory key encryption"
...
This reverts commit 921dd8dde5
2020-08-17 14:08:59 -05:00
moneromooo-monero
7175dcb107
replace most boost serialization with existing monero serialization
...
This reduces the attack surface for data that can come from
malicious sources (exported output and key images, multisig
transactions...) since the monero serialization is already
exposed to the outside, and the boost lib we were using had
a few known crashers.
For interoperability, a new load-deprecated-formats wallet
setting is added (off by default). This allows loading boost
format data if there is no alternative. It will likely go
at some point, along with the ability to load those.
Notably, the peer lists file still uses the boost serialization
code, as the data it stores is define in epee, while the new
serialization code is in monero, and migrating it was fairly
hairy. Since this file is local and not obtained from anyone
else, the marginal risk is minimal, but it could be migrated
later if needed.
Some tests and tools also do, this will stay as is for now.
2020-08-17 16:23:58 +00:00
Alexander Blair
01b512f3a9
Merge pull request #6716
...
76c16822d
2020-08-16 12:52:21 -07:00
Alexander Blair
f40b9e34e0
Merge pull request #6715
...
3d6bc0a68
2020-08-16 12:51:57 -07:00
Alexander Blair
8f02e7a7fc
Merge pull request #6632
...
ef694d028
2020-08-16 12:44:59 -07:00
Alexander Blair
6d29ee6c52
Merge pull request #6493
...
921dd8dde
2020-08-16 12:39:59 -07:00
moneromooo-monero
85899230d1
simplewallet: allow setting tx keys when sending to a subaddress
...
The tx key derivation is different then
2020-08-10 21:25:51 +00:00
Sarang Noether
921dd8dde5
Use domain-separated ChaCha20 for in-memory key encryption
2020-08-09 19:11:54 -04:00
Sarang Noether
6bfcd31015
Updates InProofV1, OutProofV1, and ReserveProofV1 to new V2 variants that include all public proof parameters in Schnorr challenges, along with hash function domain separators. Includes new randomized unit tests.
2020-08-09 18:42:15 -04:00
moneromooo-monero
e916201f12
wallet2: fix setting tx keys when another is already set
...
insert doesn't actually insert if another element with the
same key is already in the map
2020-08-08 14:40:03 +00:00
Jason Rhinelander
20f603c6be
Fix broken multisig pubkey sorting
...
The sort predicate is a boolean ordered-before value, but these are
returning the memcmp value directly, and thus returns true whenever the
pubkeys aren't equal. This means:
- it isn't actually sorting.
- it can (and does) segfault for some inputs.
2020-08-05 12:42:27 -03:00
moneromooo-monero
db5d6e4602
wallet2: fix wrong name when checking RPC cost
2020-07-31 14:17:23 +00:00
xiphon
76c16822d0
wallet2_api: implement runtime proxy configuration
2020-07-20 13:45:12 +00:00
xiphon
3d6bc0a680
wallet2: throw a error on wallet initialization failure
2020-07-20 04:40:34 +00:00
Alexander Blair
a0d179e528
Merge pull request #6512
...
5ef0607da
2020-07-19 03:32:59 -07:00
luigi1111
340e1943ac
Merge pull request #6587
...
94befec
2020-07-08 17:14:09 -05:00
luigi1111
c4f4091dd4
Merge pull request #6561
...
c17fe81
2020-06-08 14:21:33 -05:00
luigi1111
3a577f1ce7
Merge pull request #6525
...
86cf811
2020-06-08 14:07:45 -05:00
woodser
ef694d028f
fix warning by removing std::move() on temporary http_client object
2020-06-06 11:38:32 -04:00
Lee Clagett
7aeb503547
Fix boost <1.60 compilation and fix boost 1.73+ warnings
2020-05-31 21:18:11 -04:00
Denis Smirnov
94befecb05
fix typo in pick_preferred_rct_inputs
2020-05-25 03:39:54 +07:00
moneromooo-monero
c17fe815a2
wallet2: fix multisig data clearing stomping on a vector
2020-05-19 10:45:40 +00:00
moneromooo-monero
86cf811a39
simplewallet: don't complain about incoming payment ids on change
2020-05-13 23:28:31 +00:00
luigi1111
4c2f78aeeb
Merge pull request #6506
...
42e1484
2020-05-07 10:43:05 -05:00
SomaticFanatic
5ef0607da6
Update copyright year to 2020
...
Update copyright year to 2020
2020-05-06 22:36:54 -04:00
luigi1111
3de804f1e9
Merge pull request #6485
...
7a8c1ee
2020-05-06 00:31:51 -05:00
luigi1111
9e3f72c375
Merge pull request #6480
...
4f489fa
2020-05-06 00:28:18 -05:00
luigi1111
6d1f3c9acd
Merge pull request #6467
...
8b655de
2020-05-05 23:40:44 -05:00
luigi1111
b4023dcfc5
Merge pull request #6441
...
613071f
2020-05-05 23:39:32 -05:00
