luigi1111
a39b1d56c8
Merge pull request #7899
...
cd76eb7
wallet: fix unused lambda capture warning (selsta)
2021-09-09 15:21:10 -04:00
luigi1111
dfa6b58d4d
Merge pull request #7823
...
24d3d65
monero-wallet-rpc: Prevent --password-file from being used with --wallet-dir (Kermit Alexander II)
2021-09-09 15:14:17 -04:00
luigi1111
b7315efc1c
Merge pull request #7342
...
520ce1c
Attempt to carve the fee from a partial payment early (lxop)
2021-09-09 15:06:46 -04:00
selsta
cd76eb7b8c
wallet: fix unused lambda capture warning
2021-08-28 15:18:32 +02:00
SChernykh
e52802baef
Wallet2: fix optimize-coinbase for p2pool payouts
...
RefreshOptimizeCoinbase was an optimization to speed up scanning of coinbase transactions before RingCT (tx version 2) where they split miner reward into multiple denominations, all to the same wallet.
When RingCT was introduced, all coinbase transactions became 1 output only, so this optimization does nothing now.
With p2pool, this optimization will skip scanning p2pool payouts because they use more than 1 output in coinbase transaction.
Fix it by applying this optimization only to pre-RingCT transactions (version < 2).
2021-08-26 11:50:15 +02:00
luigi1111
8b9eea92f1
Merge pull request #7849
...
6f15a0c
Make sure node returns to wallet that real output is unlocked (j-berman)
2021-08-20 16:49:59 -04:00
luigi1111
1b079e5195
Merge pull request #7845
...
e1af8dc
Protect client from divide by 0 caused by integer truncation (j-berman)
2021-08-20 16:45:15 -04:00
luigi1111
5812b757e0
Merge pull request #7821
...
da2955f
Apply gamma distr from chain tip when selecting decoys (j-berman)
2021-08-20 16:33:53 -04:00
Kermit Alexander II
24d3d65d42
monero-wallet-rpc: Prevent --password-file from being used with --wallet-dir
2021-08-20 08:54:41 -05:00
j-berman
e1af8dc02c
Protect client from divide by 0 caused by integer truncation
2021-08-19 14:56:36 -07:00
j-berman
da2955feae
Apply gamma distr from chain tip when selecting decoys
...
- matches the paper by Miller et al to apply the gamma from chain tip, rather than after unlock time
- if the gamma produces an output more recent than the unlock time, the algo packs that output into one of the first 50 spendable blocks, respecting the block density factor
2021-08-19 14:51:20 -07:00
luigi1111
62844a776d
Merge pull request #7786
...
9c6e094
fix #7784 - deinit wallet in wallet dtor (Dusan Klinec)
2021-08-11 22:30:11 -04:00
j-berman
6f15a0c8d3
Make sure node returns to wallet that real output is unlocked
2021-08-11 07:28:10 -07:00
luigi1111
ed506006d2
Merge pull request #7796
...
0c6e1d3
wallet2: chunk get_outs.bin calls to avoid sanity limits (moneromooo-monero)
2021-08-02 18:54:46 -04:00
luigi1111
eeda76570c
Merge pull request #7790
...
bc8d764
wallet: rephrase error message on invalid device address (Dusan Klinec)
2021-08-02 18:53:05 -04:00
luigi1111
8c41d14ad5
Merge pull request #7788
...
f5eb2ce
wallet2: Don't auto lock device on process parsed blocks (tobtoht)
2021-08-02 18:50:25 -04:00
luigi1111
9aa2d4c16e
Merge pull request #7747
...
8cf95c8
wallet2: refresh: check error and throw before potentially breaking out of loop (tobtoht)
2021-08-02 18:42:32 -04:00
luigi1111
2d5b8a6ff7
Merge pull request #7740
...
8cea9d8
wallet: Reset RPC Pay ID on node switch (tobtoht)
2021-07-27 16:55:14 -04:00
moneromooo-monero
0c6e1d343e
wallet2: chunk get_outs.bin calls to avoid sanity limits
2021-07-15 17:25:07 +00:00
tobtoht
f5eb2ce968
wallet2: Don't auto lock device on process parsed blocks
2021-07-14 13:02:54 +02:00
Dusan Klinec
bc8d7644d2
wallet: rephrase error message on invalid device address
2021-07-14 11:02:29 +02:00
Dusan Klinec
9c6e0941cb
fix #7784 - deinit wallet in wallet dtor
2021-07-14 10:46:16 +02:00
luigi1111
7499837a6f
Merge pull request #7661
...
08e4497
Improve cryptonote (block and tx) binary read performance (Lee Clagett)
2021-06-10 12:00:54 -05:00
luigi1111
a1a3e970f7
Merge pull request #7662
...
4da1112
rpc: send confirmations in get_transactions result (moneromooo-monero)
2021-06-10 11:34:20 -05:00
tobtoht
8cf95c8f29
wallet2: refresh: check error and throw before potentially breaking out of loop
2021-06-04 18:37:06 +02:00
tobtoht
8cea9d8605
wallet: Reset RPC Pay ID on node switch
...
RPC pay client ID is sent with each RPC request, set a new secret every time we switch nodes to mitigate trivial correlation
2021-06-04 13:58:09 +02:00
luigi1111
628c04499b
Merge pull request #7682
...
bbdb612
Wallet2: Update 'approximate_testnet_rolled_back_blocks' (rbrunner7)
2021-05-12 15:30:34 -05:00
rbrunner7
bbdb612b51
Wallet2: Update 'approximate_testnet_rolled_back_blocks'
2021-04-25 10:20:39 +02:00
Nathan Dorfman
c57ef7f807
wallet2: Fix rescan_bc keep_ki option
2021-04-23 09:11:45 -06:00
luigi1111
9bba3f4767
Merge pull request #7651
...
c8ff1d4
monero-wallet-cli: improve error message when tx amount is zero (Elliot Wirrick)
2021-04-22 01:35:20 -04:00
mj-xmr
dc81e23e60
Split epee/string_tools.h and encapsulate boost::lexical_cast
2021-04-16 20:54:20 +02:00
moneromooo-monero
4da1112967
rpc: send confirmations in get_transactions result
...
if the wallet does it, it would get a wrong result (possibly even
negative) if its local chain is not synced up to the daemon's yet
2021-04-15 15:31:52 +00:00
Elliot Wirrick
c8ff1d4d23
monero-wallet-cli: improve error message when tx amount is zero
2021-04-07 10:10:16 -04:00
luigi1111
2098941ca0
Merge pull request #7635
...
447bfae
wallet2: fix unlocked mixup in light wallet mode (moneromooo-monero)
2021-04-06 12:23:45 -05:00
moneromooo-monero
447bfae2a4
wallet2: fix unlocked mixup in light wallet mode
2021-03-25 09:33:40 +00:00
moneromooo-monero
f9b5b521e8
fix serialization being different on mac
...
On Mac, size_t is a distinct type from uint64_t, and some
types (in wallet cache as well as cold/hot wallet transfer
data) use pairs/containers with size_t as fields. Mac would
save those as full size, while other platforms would save
them as varints. Might apply to other platforms where the
types are distinct.
There's a nasty hack for backward compatibility, which can
go after a couple forks.
2021-03-05 23:42:33 +00:00
luigi1111
6556c33f13
Merge pull request #7355
...
bd12984
Remove copies from foreach loops (thanks to Clang) (Lee Clagett)
1572df9
Removing unused namespace alias (Lee Clagett)
2021-02-18 14:06:47 -05:00
luigi1111
ce5800a225
Merge pull request #7346
...
85db173
Remove unused variables in monero codebase (Kevin Barbour)
2021-02-18 14:03:31 -05:00
luigi1111
0e35d46f5e
Merge pull request #7341
...
b587ffa
Stop adding more outputs than bulletproof allows (Alex Opie)
2021-02-18 14:02:13 -05:00
luigi1111
3f55f7df31
Merge pull request #7312
...
186271e
monero-wallet-cli: Added command scan_tx (Horia Mihai David)
2021-02-18 14:00:35 -05:00
Horia Mihai David
186271e5d1
monero-wallet-cli: Added command scan_tx
...
To implement this feature, the wallet2::scan_tx API was implemented.
2021-02-17 20:25:55 +01:00
luigi1111
4ee301c687
Merge pull request #6986
...
ee58f4f
Balance includes unconfirmed payments (woodser)
2021-02-15 21:36:48 -05:00
Kevin Barbour
85db1734e7
Remove unused variables in monero codebase
...
There are quite a few variables in the code that are no longer
(or perhaps never were) in use. These were discovered by enabling
compiler warnings for unused variables and cleaning them up.
In most cases where the unused variables were the result
of a function call the call was left but the variable
assignment removed, unless it was obvious that it was
a simple getter with no side effects.
2021-02-09 08:05:05 +01:00
Lee Clagett
1572df9e26
Removing unused namespace alias
2021-01-28 23:40:57 -05:00
Alex Opie
520ce1ca81
Attempt to carve the fee from a partial payment early
...
Do this for both the estimate and actual fee.
#7337
2021-01-25 12:01:27 +13:00
Alex Opie
b587ffa1fd
Stop adding more outputs than bulletproof allows
...
If more outputs are requested, they are split across
multiple transactions.
#7322
2021-01-25 10:01:38 +13:00
Lee Clagett
08e4497c6e
Improve cryptonote (block and tx) binary read performance
2021-01-23 06:23:39 +00:00
moneromooo-monero
d2fda6c25f
restrict public node checks a little
...
do not include blocked hosts in peer lists or public node lists by default,
warn about no https on clearnet and about untrusted peers likely being spies
2020-12-22 23:39:07 +00:00
woodser
ee58f4f766
Balance includes unconfirmed payments
2020-11-06 15:08:43 -05:00
Lee Clagett
7414e2bac1
Change epee binary output from std::stringstream to byte_stream
2020-10-10 15:28:40 +00:00