moneromooo-monero
dd144b14bc
blockchain: fix reorganizations past a hard fork boundary
...
After popping blocks from the old chain, the hard fork object's
notion of the current version was not in line with the new height,
causing the first blocks from the new chain to be rejected due
to a false expection of a newer version.
2016-12-13 02:13:23 +00:00
luigi1111
0fb5dc870d
monero-wallet-cli wording changes 'n' stuff
...
Possibly other pedantry. Pedants are people too.
2016-12-12 19:53:28 -06:00
NanoAkron
4299bdf614
Improve language of 'node ahead by' message
2016-12-12 23:24:40 +00:00
luigi1111
9d906159c3
Tx verification failing is not an error
...
And rangeProofs are on outputs...
2016-12-12 17:01:20 -06:00
Riccardo Spagni
655eafd160
bump version
2016-12-13 00:29:29 +02:00
Riccardo Spagni
117194a397
update checkpoints
2016-12-13 00:26:25 +02:00
Riccardo Spagni
39a9db9eb1
update checkpoints
2016-12-13 00:24:48 +02:00
Jaquee
3b4539ee7e
addressbook updates
2016-12-12 21:50:50 +01:00
Riccardo Spagni
5b7f1fc8e4
Merge pull request #1424
...
aeb13289
Update cryptonote_protocol_handler.inl (Gingeropolous)
2016-12-12 22:40:41 +02:00
Riccardo Spagni
aa7a926681
Merge pull request #1434
...
5df92877
GUI address book (Jaquee)
2016-12-12 22:39:38 +02:00
Riccardo Spagni
84d3107600
Merge pull request #1431
...
81c6bb9a
thread_group: fix build on older GCC (moneromooo-monero)
2016-12-12 22:38:27 +02:00
Riccardo Spagni
67844f826e
Merge pull request #1425
...
c5c45ca6
wallet: bring forward use of the dynamic fee (moneromooo-monero)
2016-12-12 22:38:05 +02:00
Jaquee
5df92877c7
GUI address book
2016-12-12 00:43:02 +01:00
moneromooo-monero
81c6bb9a40
thread_group: fix build on older GCC
...
vtnerd (original author) confirmed this is the Right Way.
2016-12-11 13:59:42 +00:00
moneromooo-monero
c5c45ca660
wallet: bring forward use of the dynamic fee
...
It was 14 days after v4, it is now one day after it.
luigi1111's suggestion
2016-12-10 15:39:26 +00:00
Gingeropolous
aeb13289bb
Update cryptonote_protocol_handler.inl
...
Per discussion of #1359 , the wording has changed to indicate that no assessment of the blocks validity is made.
2016-12-10 10:22:16 -05:00
moneromooo-monero
19585d4914
mnemonics: fix misc STL containers leak
...
found by coverity
2016-12-10 12:51:36 +00:00
moneromooo-monero
f6fcf0ef26
oaes_lib: fix a leak on OOM error path
...
found by coverity
2016-12-10 12:51:20 +00:00
Riccardo Spagni
2d0fbaf35b
Merge pull request #1422
...
9b00d80f
wallet2: pass by const ref where possible (moneromooo-monero)
2016-12-10 14:49:34 +02:00
Riccardo Spagni
930aceb242
Merge pull request #1419
...
f4a3ce15
Fix sending outputs from a tx with more than one pubkey (moneromooo-monero)
2016-12-10 14:48:56 +02:00
Riccardo Spagni
0f99423080
Merge pull request #1418
...
dfbb85b6
blockchain: fix setting non trovial alternate chain as invalid (moneromooo-monero)
2016-12-10 14:48:39 +02:00
moneromooo-monero
9b00d80f85
wallet2: pass by const ref where possible
...
Reported by kenshi84
2016-12-10 11:43:44 +00:00
moneromooo-monero
f4a3ce15c1
Fix sending outputs from a tx with more than one pubkey
...
A bug in cold signing caused a spurious pubkey to be included
in transactions, so we need to ensure we use the correct one
when sending outputs from one of those.
2016-12-09 18:21:21 +00:00
moneromooo-monero
dfbb85b6fe
blockchain: fix setting non trovial alternate chain as invalid
...
The wrong iterator was being used.
Also preincrement iterators to avoid possibly invalidating them,
I'm not sure this is necessary, but let's be safe.
2016-12-08 22:26:27 +00:00
Riccardo Spagni
12b59460c2
Merge pull request #1417
...
0b91d825
simplewallet: restore automatically setting trusted local daemon (moneromooo-monero)
2016-12-08 23:45:04 +02:00
Riccardo Spagni
8e1a8c6adc
Merge pull request #1415
...
6c44f5c6
wallet: send 0 change to a random address where necessary with rct (moneromooo-monero)
2016-12-08 23:44:40 +02:00
Riccardo Spagni
e6b05ed95a
Merge pull request #1414
...
3b005275
ringct: add sc_check calls in MLSAG_Ver for ss and cc (moneromooo-monero)
2f1732a7
ringct: guard against bad data exceptions in worker threads (moneromooo-monero)
2016-12-08 23:44:09 +02:00
Riccardo Spagni
22e16e88e3
Merge pull request #1413
...
648ea6be
blockchain: bring the v4 fork height one block forward (luigi1111)
46a0dcc1
ringct: luigi1111's changes to fix and speedup Borromean sigs (luigi1111)
76958fc7
ringct: switch to Borromean signatures (Shen Noether)
2016-12-08 23:43:41 +02:00
Riccardo Spagni
f9503d2789
Merge pull request #1405
...
d1a75754
Remove infinite loop in refresh code (Jaquee)
2016-12-08 23:43:19 +02:00
moneromooo-monero
0b91d82574
simplewallet: restore automatically setting trusted local daemon
2016-12-08 20:01:24 +00:00
moneromooo-monero
3b00527500
ringct: add sc_check calls in MLSAG_Ver for ss and cc
...
luigi1111's recommendation
2016-12-07 22:41:21 +00:00
moneromooo-monero
2f1732a7e5
ringct: guard against bad data exceptions in worker threads
...
If purported pubkeys aren't actually valid pubkeys, exceptions
will fly. These will terminate if thrown in a worker thread.
Guard against this.
2016-12-07 22:09:43 +00:00
moneromooo-monero
6c44f5c6eb
wallet: send 0 change to a random address where necessary with rct
...
If a rct transaction would cause no change to be generated, a zero
change output is added, and sent to a randomly generated address.
This ensures that no transaction will be sent with just one output,
which could cause the receiver to be able to determine which of the
inputs in the sent rings is the real one.
This is very rare, since it requires the sum of outputs to be equal
to the sum of outputs plus the fee, which is now a function of the
last few blocks.
2016-12-07 21:05:50 +00:00
luigi1111
648ea6bef1
blockchain: bring the v4 fork height one block forward
...
This will ensure the early 0.10 daemons will barf at the fork
height, and not a bit later, which could be confusing.
2016-12-06 21:59:08 +00:00
Lee Clagett
18462aa065
Added confirmation before binding wallet-rpc to external IP
2016-12-05 21:45:11 -05:00
Jaquee
d1a75754df
Remove infinite loop in refresh code
...
This reverts commit fd181b03bb
.
2016-12-05 13:02:45 +01:00
luigi1111
46a0dcc1d2
ringct: luigi1111's changes to fix and speedup Borromean sigs
2016-12-04 21:54:16 +00:00
Shen Noether
76958fc75a
ringct: switch to Borromean signatures
2016-12-04 21:54:11 +00:00
Riccardo Spagni
b500a64524
Merge pull request #1399
...
73ac3b8e
wallet2: avoid possible undefined behavior on empty string (moneromooo-monero)
2016-12-04 22:28:48 +02:00
Riccardo Spagni
f2ea2afb77
Merge pull request #1398
...
f4772bae
Fix a few minor typos (Pierre Boyer)
2016-12-04 22:28:22 +02:00
Riccardo Spagni
8086379680
Merge pull request #1397
...
3f7d6fb5
Fix delayed exit when syncing (moneromooo-monero)
2016-12-04 22:27:41 +02:00
Riccardo Spagni
4a0be41dfe
Merge pull request #1396
...
7c0dd5e4
net_node: drop connections from banned IPs after looping through connections (moneromooo-monero)
2016-12-04 22:26:12 +02:00
Riccardo Spagni
d59dc59744
Merge pull request #1395
...
59443bf9
ringct: fix MGs serialization to JSON (moneromooo-monero)
2016-12-04 22:25:24 +02:00
Riccardo Spagni
daf5dbebb0
Merge pull request #1393
...
0e18f465
db_lmdb: add info in an error message when we can't get an output (moneromooo-monero)
c96f9b02
db_lmdb: guard against going out of sync on unexpected db results (moneromooo-monero)
bef51e67
db_lmdb: minor pedantic tweaks (moneromooo-monero)
3465c4eb
db_lmdb: set same packing format for output_data_t and pre_rct_output_data_t (moneromooo-monero)
2016-12-04 22:23:34 +02:00
Riccardo Spagni
416f7fbd5f
Merge pull request #1392
...
204b1bff
blockchain: use high bound block reward on error where appropriate (moneromooo-monero)
2016-12-04 22:23:03 +02:00
Riccardo Spagni
98150be7d8
Merge pull request #1389
...
4adde042
p2p: possibly fix crash in relay_blocks (moneromooo-monero)
2016-12-04 22:22:07 +02:00
Riccardo Spagni
977dd9b76c
Merge pull request #1385
...
5783dd8c
tests: add unit tests for uri parsing (moneromooo-monero)
82ba2108
wallet: add API and RPC to create/parse monero: URIs (moneromooo-monero)
d9001b43
epee: add functions to convert from URL format (ie, %XX values) (moneromooo-monero)
2016-12-04 22:19:06 +02:00
Riccardo Spagni
836c748366
Merge pull request #1388
...
fcd178ef
wallet_api: add a few daemon related getters (moneromooo-monero)
2016-12-04 22:17:48 +02:00
Riccardo Spagni
2fd43e25ee
Merge pull request #1386
...
8f6ec90c
blockchain: reject invalid pubkeys from v4 (moneromooo-monero)
2016-12-04 22:15:36 +02:00
Riccardo Spagni
42d07e865f
Merge pull request #1383
...
00592189
change 'invalid address format' loglevel (Jaquee)
2016-12-04 22:02:58 +02:00
Riccardo Spagni
3d533d1037
Merge pull request #1380
...
657a70e0
wallet: add a getter for the filename path (moneromooo-monero)
2016-12-04 22:02:40 +02:00
Riccardo Spagni
fe89782512
Merge pull request #1379
...
d6086f5b
Improve daemon RPC version handling (moneromooo-monero)
2016-12-04 22:01:49 +02:00
moneromooo-monero
73ac3b8e26
wallet2: avoid possible undefined behavior on empty string
2016-12-04 14:56:06 +00:00
Pierre Boyer
f4772bae81
Fix a few minor typos
2016-12-04 14:13:54 +01:00
moneromooo-monero
3f7d6fb57d
Fix delayed exit when syncing
2016-12-04 12:27:45 +00:00
moneromooo-monero
7c0dd5e46c
net_node: drop connections from banned IPs after looping through connections
...
This keeps the connections lock just for the time of looping
and adding connectoins to a list, and the dropping happens
after it. This should avoid lengthy delays waiting for the
connections lock.
2016-12-03 11:20:48 +00:00
moneromooo-monero
59443bf9df
ringct: fix MGs serialization to JSON
2016-12-02 13:16:19 +00:00
moneromooo-monero
4adde0423b
p2p: possibly fix crash in relay_blocks
2016-12-01 23:52:16 +00:00
moneromooo-monero
204b1bff62
blockchain: use high bound block reward on error where appropriate
...
If the block reward to use for the fee calculation can't be
calculated (should not happen in practice), use a high bound,
so we use a fee overestimate that will be accepted by the network.
2016-12-01 16:34:09 +00:00
moneromooo-monero
0e18f46522
db_lmdb: add info in an error message when we can't get an output
...
Will be useful to debug
2016-12-01 14:31:40 +00:00
moneromooo-monero
c96f9b0255
db_lmdb: guard against going out of sync on unexpected db results
...
m_num_outputs keeps track of the number of outputs, which should
be the same as the size of both the output_txs and output_amounts
databases. If one goes out of sync, we need to throw to abort
whatever it is we were doing.
2016-12-01 14:29:35 +00:00
moneromooo-monero
bef51e677e
db_lmdb: minor pedantic tweaks
...
Add consts in a few places where it makes sense, avoid unnecessary
memory reallocation where we know the full size needed at the outset,
simplify and avoid memory copy.
2016-12-01 14:28:09 +00:00
moneromooo-monero
3465c4ebc7
db_lmdb: set same packing format for output_data_t and pre_rct_output_data_t
...
For safety, though it seems to have been the case already.
Also add a comment about the necessary layout identity.
2016-12-01 14:26:18 +00:00
moneromooo-monero
fcd178ef33
wallet_api: add a few daemon related getters
...
Blockchain height, version, Mining hash rate...
2016-11-29 10:54:38 +00:00
moneromooo-monero
8f6ec90c83
blockchain: reject invalid pubkeys from v4
2016-11-28 22:32:58 +00:00
moneromooo-monero
82ba2108e9
wallet: add API and RPC to create/parse monero: URIs
2016-11-28 17:54:22 +00:00
Jaquee
0059218908
change 'invalid address format' loglevel
2016-11-27 14:44:19 +01:00
moneromooo-monero
657a70e004
wallet: add a getter for the filename path
2016-11-26 14:19:57 +00:00
moneromooo-monero
d6086f5b4e
Improve daemon RPC version handling
...
Daemon RPC version is now composed of a major and minor number,
so that incompatible changes bump the major version, while
compatible changes can still bump the minor version without
causing clients to unnecessarily complain.
2016-11-26 12:56:44 +00:00
Lee Clagett
91ffb61c25
Added command_line::is_yes
2016-11-25 21:57:27 -05:00
Riccardo Spagni
c36cb54340
Merge pull request #1372
...
17b6bd6
Fix DNS failures in offline mode preventing daemon startup (moneromooo-monero)
2016-11-24 13:01:35 +02:00
Riccardo Spagni
2497a2d547
Merge pull request #1369
...
6d76072
simplewallet: remove double confirmation when submitting signed tx (moneromooo-monero)
92dea04
wallet2: fix wrong change being recorded for cold signed txes (moneromooo-monero)
2016-11-24 13:00:32 +02:00
Riccardo Spagni
ce8a2315cf
Merge pull request #1364
...
f025198
Added task_region - a fork/join task implementation (Lee Clagett)
2016-11-24 12:58:09 +02:00
Riccardo Spagni
3fa1b6623a
Merge pull request #1361
...
1d9e223
rpc: do not include output indices for pool txes (moneromooo-monero)
e227d6e
rpc: bump version after RPC changes (moneromooo-monero)
2c0173c
Add a get_outs (fully text based) version of get_outs.bin (moneromooo-monero)
e05907b
rpc: add output indices to gettransactions (moneromooo-monero)
2016-11-24 12:57:00 +02:00
Riccardo Spagni
a26b27f66e
Merge pull request #1358
...
7abfc54
wallet: fix exporting outputs and key images with txes with two pubkeys (moneromooo-monero)
2016-11-24 12:55:14 +02:00
Riccardo Spagni
25369df4d8
Merge pull request #1357
...
5fc36f9
wallet2_api: fix history leak on destruction (moneromooo-monero)
2016-11-24 12:54:25 +02:00
Riccardo Spagni
f801dc8567
Merge pull request #1356
...
69b188c
wallet2_api: fix payment ids from integrated addresses being ignored (moneromooo-monero)
2016-11-24 12:53:59 +02:00
Riccardo Spagni
570acdc686
Merge pull request #1352
...
d01f5c7
wallet2: fix illegal memory access removing newlines from password (moneromooo-monero)
2016-11-24 12:53:14 +02:00
Riccardo Spagni
2121f3b2f0
Merge pull request #1351
...
e6264a2
wallet2: fix decrypting a bit too much in authenticated mode (moneromooo-monero)
2016-11-24 12:52:54 +02:00
moneromooo-monero
17b6bd6d35
Fix DNS failures in offline mode preventing daemon startup
2016-11-23 23:14:49 +00:00
moneromooo-monero
6d76072612
simplewallet: remove double confirmation when submitting signed tx
2016-11-23 20:45:03 +00:00
moneromooo-monero
92dea04929
wallet2: fix wrong change being recorded for cold signed txes
2016-11-23 20:27:22 +00:00
Lee Clagett
f025198f19
Added task_region - a fork/join task implementation
2016-11-23 14:41:25 -05:00
moneromooo-monero
1d9e223944
rpc: do not include output indices for pool txes
...
Those aren't yet in the blockchain, so will not be found
(and aren't yet known, since it depends on where exactly the
tx will be mined in the next block or blocks)
2016-11-23 18:56:54 +00:00
moneromooo-monero
e227d6e7ac
rpc: bump version after RPC changes
2016-11-22 20:01:20 +00:00
moneromooo-monero
2c0173c722
Add a get_outs (fully text based) version of get_outs.bin
2016-11-22 20:00:40 +00:00
moneromooo-monero
e05907b3e7
rpc: add output indices to gettransactions
...
Someone apparently needs that to make a wallet but never asked.
If you read that and that's not what you wanted, the bugtracker
is at https://github.com/monero-project/monero/issues
2016-11-22 20:00:23 +00:00
moneromooo-monero
7abfc5474c
wallet: fix exporting outputs and key images with txes with two pubkeys
...
This also needs to make sure to pick the correct one, in the case
where cold signing caused to tx keys to be included.
2016-11-19 09:36:40 +00:00
moneromooo-monero
5fc36f981c
wallet2_api: fix history leak on destruction
2016-11-18 21:42:08 +00:00
moneromooo-monero
69b188c4b2
wallet2_api: fix payment ids from integrated addresses being ignored
2016-11-18 19:13:43 +00:00
Dion Ahmetaj
fd181b03bb
Clamp refresh from height to blockchain height.
2016-11-18 13:40:55 -05:00
moneromooo-monero
d01f5c7f1f
wallet2: fix illegal memory access removing newlines from password
2016-11-17 20:43:58 +00:00
moneromooo-monero
e6264a2c35
wallet2: fix decrypting a bit too much in authenticated mode
2016-11-17 20:31:00 +00:00
Riccardo Spagni
dbf2ab56c5
Merge pull request #1346
...
4eb7347
wallet: return fee in transfer RPC (moneromooo-monero)
2016-11-17 16:40:37 +02:00
Riccardo Spagni
5df6f0be80
Merge pull request #1318
...
4fca34d
Wallet2: calculate approximate blockchain height on offline creation (Jacob Brydolf)
2016-11-17 16:37:30 +02:00
Riccardo Spagni
2988e1be8c
Merge pull request #1344
...
a0131c8
wallet: auto sync outputs and key images in cold signing files (moneromooo-monero)
f806611
wallet2: fill key image and pubkey maps when importing outputs (moneromooo-monero)
5fe363c
wallet: cast indices to string in logs to be nice to CLANG (moneromooo-monero)
11ae187
wallet2: try all tx keys when scanning a new transaction (moneromooo-monero)
072d646
wallet2: fill in key image map when importing key images (moneromooo-monero)
23d80b1
core: remove any tx pubkey from extra before adding one (moneromooo-monero)
d72376d
simplewallet: add a verbose flag to incoming_transfers (moneromooo-monero)
47413a5
simplewallet: spell out change when signing a transfer (moneromooo-monero)
14cb088
simplewallet: print public keys too on spendkey/viewkey commands (moneromooo-monero)
a99ab49
wallet: fix serialization of new m_key_image_known member (moneromooo-monero)
2016-11-17 16:36:12 +02:00
Riccardo Spagni
b7b54b6cff
Merge pull request #1336
...
bd4da18
simplewallet: include amount sent in transfer confirmation (moneromooo-monero)
2016-11-17 16:26:49 +02:00
moneromooo-monero
4eb7347fdd
wallet: return fee in transfer RPC
2016-11-16 18:56:45 +00:00
moneromooo-monero
a0131c8be3
wallet: auto sync outputs and key images in cold signing files
...
When passing around unsigned and signed transactions, outputs
and key images are passed along (outputs are passed along unsigned
transactions from the hot wallet to the cold wallet, key images
are passed along with signed transations from the cold wallet
to the hot wallet), to allow more user friendly syncing between
hot and cold wallets.
2016-11-16 09:22:24 +00:00
moneromooo-monero
f8066116dd
wallet2: fill key image and pubkey maps when importing outputs
2016-11-16 09:22:18 +00:00