moneromooo-monero
da8b60cbbf
simplewallet: reject attempts to use too low mixin early
...
This yields a clear error message rather then some possibly
confusing more technical errors down the line
2017-11-14 13:12:39 +00:00
Riccardo Spagni
2ddb894607
Merge pull request #2661
...
ac4018a7
wallet2: workaround for lightwallet before supporting subaddress (followup #2656 ) (kenshi84)
2017-11-14 15:01:25 +02:00
Riccardo Spagni
395025bb23
Merge pull request #2633
...
ad96c478
wallet-cli: added --generate-from-spend-key option (stoffu)
2017-11-14 14:56:07 +02:00
Riccardo Spagni
3fff292dc1
Merge pull request #2509
...
ccf53a56
track double spending in the txpool (moneromooo-monero)
2017-11-14 14:50:03 +02:00
binaryFate
da706b6102
Fix false GCC warning '‘*((void*)& subaddr_account +4)’ may be used unitialized'
2017-11-14 09:45:43 +01:00
stoffu
ad96c478b1
wallet-cli: added --generate-from-spend-key option
2017-11-14 16:30:59 +09:00
moneromooo-monero
d269bff2ab
wallet2: use a vector, not a list, for selected_transfers
...
Friendlier on memory/speed, we know in advance the max amount
of items, which are small and constant size, and there's a lot
of list walking involved.
2017-11-13 19:36:18 +00:00
moneromooo-monero
7e387fb1ad
wallet2: only add a dummy 0 output if there's one output otherwise
2017-11-13 14:08:10 +00:00
Michał Sałaban
ffe5b857e1
Correct totals computation
2017-11-08 12:09:50 +01:00
moneromooo-monero
5d92c7ccf6
wallet2: typo fix in error message
2017-11-07 14:04:40 +00:00
stoffu
37c3792b00
wallet2 bugfix: supply missing subaddr_account arg to balance() and unlocked balance()
2017-11-06 10:15:38 +09:00
moneromooo-monero
ccf53a566c
track double spending in the txpool
...
Transactions in the txpool are marked when another transaction
is seen double spending one or more of its inputs.
This is then exposed wherever appropriate.
Note that being marked with this "double spend seen" flag does
NOT mean this transaction IS a double spend and will never be
mined: it just means that the network has seen at least another
transaction spending at least one of the same inputs, so care
should be taken to wait for a few confirmations before acting
upon that transaction (ie, mostly of use for merchants wanting
to accept unconfirmed transactions).
2017-11-06 00:05:44 +00:00
Riccardo Spagni
3dd31d33fa
Merge pull request #2605
...
b370ef54
Wallet: Descriptions through new commands 'set_description', 'get_description' (rbrunner7)
2017-11-06 01:56:06 +02:00
Riccardo Spagni
32b083d8bd
Merge pull request #2546
...
b2d416f2
Distinguish "not enough money" and "not enough unlocked money" (binaryFate)
2017-11-06 01:53:43 +02:00
Tim L
0bf0915446
Fix file permission issue
...
This branch fixes a file permission issue introduced by 69c37200aa
2017-11-03 11:27:50 -04:00
Maxime THIEBAUT
d70515fca4
Used declared default refresh status as default rather than it's current value
2017-11-03 16:15:02 +01:00
moneromooo-monero
6cf3344605
Remove wallet dependency on p2p
2017-11-02 16:13:24 +00:00
Riccardo Spagni
32b46c594b
Merge pull request #2703
...
d0463312
fix libwallet api test after api change (Jaquee)
a46c1eed
Wallet2: Don't throw when subaddress label doesn't exist (Jaquee)
086b7db2
Wallet API: default values for account and subaddr index (Jaquee)
2017-11-01 11:24:54 +02:00
Riccardo Spagni
54463b33b3
Merge pull request #2723
...
69c37200
RPC Add cross origin resource sharing support (Tim L)
2017-10-31 20:38:38 +02:00
Riccardo Spagni
5ef9c69ef5
Merge pull request #2711
...
fab3b722
Add more specific RPC error codes (Michał Sałaban)
2017-10-31 20:35:41 +02:00
Riccardo Spagni
c97fbb0176
Merge pull request #2718
...
626e8078
wallet2: fix show_transfers missing multiple incoming outputs (moneromooo-monero)
2017-10-31 20:33:44 +02:00
Riccardo Spagni
3fe07603e4
Merge pull request #2705
...
44f14638
wallet2: fix tx size estimator for large number of inputs (moneromooo-monero)
2017-10-31 20:33:19 +02:00
moneromooo-monero
9d6c6c5dec
wallet2: do not bother downloading block hashes below last checkpoint
2017-10-31 10:29:54 +00:00
Tim L
69c37200aa
RPC Add cross origin resource sharing support
2017-10-30 13:55:56 -04:00
Jaquee
a46c1eed8c
Wallet2: Don't throw when subaddress label doesn't exist
2017-10-29 15:26:22 +01:00
Jaquee
867b67c4fd
Wallet API: override update subdir when built from src
2017-10-29 15:17:31 +01:00
moneromooo-monero
626e80780b
wallet2: fix show_transfers missing multiple incoming outputs
2017-10-23 14:38:07 +01:00
moneromooo-monero
ca87cbd852
wallet2: fix subaddress fields serialization
...
When loading an older wallet cache, they wouldn't be initialized,
leading them to have random(ish) values, and so assigned to some
random subaddress.
2017-10-23 11:53:49 +01:00
Michał Sałaban
fab3b7221b
Add more specific RPC error codes
2017-10-23 04:27:02 +02:00
moneromooo-monero
44f1463867
wallet2: fix tx size estimator for large number of inputs
2017-10-22 19:46:07 +01:00
Jaquee
086b7db2c7
Wallet API: default values for account and subaddr index
2017-10-22 18:15:23 +02:00
rbrunner7
b370ef54b9
Wallet: Descriptions through new commands 'set_description', 'get_description'
2017-10-16 22:24:09 +02:00
binaryFate
b2d416f211
Distinguish "not enough money" and "not enough unlocked money"
...
Fix #1530
2017-10-16 15:14:09 +02:00
kenshi84
ac4018a7e6
wallet2: workaround for lightwallet before supporting subaddress (followup #2656 )
2017-10-16 12:03:09 +09:00
Vasil Dimov
4d35ad7603
Fix compiler warnings with Clang 6.0.0.
...
monero/src/cryptonote_protocol/block_queue.cpp:208:44: error:
suggest braces around initialization of subobject [-Werror,-Wmissing-braces]
static const boost::uuids::uuid uuid0 = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0};
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
{ }
monero/src/wallet/wallet_rpc_server.cpp:1895:43: error:
lambda capture 'wal' is not used [-Werror,-Wunused-lambda-capture]
tools::signal_handler::install([&wrpc, &wal](int) {
^
monero/src/cryptonote_protocol/cryptonote_protocol_handler.inl:1616:40: error:
lambda capture 'arg' is not used [-Werror,-Wunused-lambda-capture]
m_p2p->for_each_connection([this, &arg, &fluffy_arg, &exclude_context, &fullConnections...
^
monero/src/cryptonote_protocol/cryptonote_protocol_handler.inl:1616:46: error:
lambda capture 'fluffy_arg' is not used [-Werror,-Wunused-lambda-capture]
m_p2p->for_each_connection([this, &arg, &fluffy_arg, &exclude_context, &fullConnections...
^
monero/src/blockchain_utilities/blockchain_export.cpp:181:3: error:
bool literal returned from 'main' [-Werror,-Wmain]
CHECK_AND_ASSERT_MES(r, false, "Failed to initialize source blockchain storage");
^ ~~~~~
monero/contrib/epee/include/misc_log_ex.h:180:97: note:
expanded from macro 'CHECK_AND_ASSERT_MES'
...fail_ret_val, message) do{if(!(expr)) {LOG_ERROR(message); return fail_ret_val;};}while(0)
^ ~~~~~~~~~~~~
monero/src/blockchain_utilities/blockchain_export.cpp:195:3: error:
bool literal returned from 'main' [-Werror,-Wmain]
CHECK_AND_ASSERT_MES(r, false, "Failed to export blockchain raw data");
^ ~~~~~
monero/contrib/epee/include/misc_log_ex.h:180:97: note:
expanded from macro 'CHECK_AND_ASSERT_MES'
...fail_ret_val, message) do{if(!(expr)) {LOG_ERROR(message); return fail_ret_val;};}while(0)
^ ~~~~~~~~~~~~
2017-10-15 22:02:24 +03:00
Jaquee
3492de010b
fix lightwallet and subaddresses conflict
2017-10-15 19:19:40 +02:00
Riccardo Spagni
5c3275ddbe
Merge pull request #2596
...
06fb9bcf
wallet2: fix refresh height calc for new wallets (moneromooo-monero)
2017-10-15 18:47:16 +02:00
Riccardo Spagni
71253c1dcd
Merge pull request #2592
...
dc19659d
Remove network_address_base which has been merged with ipv4_network_address in 8b006877
(Michał Sałaban)
2183ade0
Don't try to create wallet-dir when it's not given, don't crash if wallet-dir already exists. (Michał Sałaban)
2017-10-15 18:39:13 +02:00
Riccardo Spagni
1280ba4f5b
Merge pull request #2589
...
8f0cea63
add a command_line function to check for defaulted options (moneromooo-monero)
2017-10-15 18:38:46 +02:00
Riccardo Spagni
27ed7419bb
Merge pull request #2570
...
f139a6ca
wallet2: fix backlog being off by 1 (moneromooo-monero)
2017-10-15 18:33:51 +02:00
Riccardo Spagni
c45f3ac4d9
Merge pull request #2568
...
7130cf0c
Add tools::on_startup, and warn about glibc 2.25 bug if found (moneromooo-monero)
2017-10-15 18:32:09 +02:00
Riccardo Spagni
1c546e0d81
Merge pull request #2565
...
452d4fae
tests: fix hashchain unit tests (moneromooo-monero)
2017-10-15 18:27:08 +02:00
Riccardo Spagni
960886aa04
Merge pull request #2109
...
97c2e449
wallet2+API: use separate callbacks for lightwallets (Jaquee)
d9261867
walletAPI: correct confirmations in txHistory for unsynced wallets (Jaquee)
9442b043
walletAPI: lightwallet exceptions (Jaquee)
fc922934
walletAPI: add lightwallet login() and importWalletRequest() (Jaquee)
79207743
walletAPI: init() lightwallet and SSL support (Jaquee)
dde5a1fc
walletAPI: add tx unlock_time (Jaquee)
bba5cbed
wallet2: remove obsolete get_num_rct_outputs() call from create_transactions_2 (Jaquee)
7a482f30
wallet2: create_transactions_2 lightwallet support (Jaquee)
ce61b818
wallet2: get_outs lightwallet support (Jaquee)
1197cb71
wallet2: commit_tx() lightwallet support (Jaquee)
43b57804
wallet2: refactor is_tx_spendtime_unlocked() (Jaquee)
32e2b003
wallet2: add lightwallet exceptions to common functions (Jaquee)
2e692fc0
wallet2: refresh() lightwallet support (Jaquee)
f44d156c
my/openmonero API functions (Jaquee)
288d3c75
wallet2: add remove_obsolete_pool_txs() (Jaquee)
2c6aad7e
wallet2: add on_pool_tx_removed callback (Jaquee)
ff7c30aa
wallet2: light wallet member variables (Jaquee)
e2a276cb
wallet2: add ssl option to init() (Jaquee)
a13540be
add string_tools::validate_hex() (Jaquee)
fd773d88
refactor cryptonote_basic::add_tx_pub_key_to_extra (Jaquee)
8bfa6c2d
lightwallet rpc server commands (Jaquee)
76961ddc
Serializer: string to integer conversion for MyMonero compatibility (Jaquee)
1cf940f2
epee http_client SSL support (Jaquee)
eec10137
CMakeLists.txt - Add openssl include dir (Jaquee)
2017-10-15 18:25:08 +02:00
Jaquee
97c2e449ce
wallet2+API: use separate callbacks for lightwallets
2017-10-15 17:58:28 +02:00
Jaquee
d92618675b
walletAPI: correct confirmations in txHistory for unsynced wallets
2017-10-15 17:58:28 +02:00
Jaquee
9442b04302
walletAPI: lightwallet exceptions
2017-10-15 17:57:45 +02:00
Jaquee
fc9229342d
walletAPI: add lightwallet login() and importWalletRequest()
2017-10-15 17:57:43 +02:00
Jaquee
79207743b8
walletAPI: init() lightwallet and SSL support
2017-10-15 17:56:35 +02:00
Jaquee
dde5a1fc36
walletAPI: add tx unlock_time
2017-10-15 17:54:17 +02:00
Jaquee
bba5cbed8f
wallet2: remove obsolete get_num_rct_outputs() call from create_transactions_2
2017-10-15 17:54:14 +02:00
Jaquee
7a482f302b
wallet2: create_transactions_2 lightwallet support
2017-10-15 17:51:20 +02:00
Jaquee
ce61b8189b
wallet2: get_outs lightwallet support
2017-10-15 17:50:03 +02:00
Jaquee
1197cb71e9
wallet2: commit_tx() lightwallet support
2017-10-15 17:48:45 +02:00
Jaquee
43b57804f8
wallet2: refactor is_tx_spendtime_unlocked()
2017-10-15 17:48:45 +02:00
Jaquee
32e2b0030e
wallet2: add lightwallet exceptions to common functions
2017-10-15 17:48:41 +02:00
Jaquee
2e692fc05a
wallet2: refresh() lightwallet support
2017-10-15 17:42:50 +02:00
Jaquee
f44d156cbd
my/openmonero API functions
2017-10-15 17:42:29 +02:00
Jaquee
288d3c75c3
wallet2: add remove_obsolete_pool_txs()
2017-10-15 17:39:54 +02:00
Jaquee
2c6aad7ea7
wallet2: add on_pool_tx_removed callback
2017-10-15 17:35:15 +02:00
Jaquee
ff7c30aadc
wallet2: light wallet member variables
2017-10-15 17:35:08 +02:00
Riccardo Spagni
d316b3d266
Merge pull request #2554
...
d74336d5
wallet: encrypt (un)signed tx, also optionally save unencrypted raw tx hexstr (stoffu)
2017-10-15 17:32:30 +02:00
Jaquee
e2a276cbb5
wallet2: add ssl option to init()
2017-10-15 17:32:13 +02:00
moneromooo-monero
7130cf0c61
Add tools::on_startup, and warn about glibc 2.25 bug if found
...
https://sourceware.org/bugzilla/show_bug.cgi?id=21778
2017-10-14 09:12:28 +01:00
moneromooo-monero
06fb9bcfcc
wallet2: fix refresh height calc for new wallets
2017-10-07 11:21:11 +01:00
kenshi84
53ad5a0f42
Subaddresses
2017-10-07 13:06:21 +09:00
stoffu
d74336d5c9
wallet: encrypt (un)signed tx, also optionally save unencrypted raw tx hexstr
2017-10-07 12:45:32 +09:00
Michał Sałaban
2183ade0c4
Don't try to create wallet-dir when it's not given, don't crash if wallet-dir already exists.
2017-10-07 02:04:33 +02:00
Riccardo Spagni
09ccd07bbc
Merge pull request #2542
...
180a848c
wallet2: Missing underflow check on low heights (landergate)
2017-10-06 23:00:24 +04:00
Riccardo Spagni
fb7dcb6ec0
Merge pull request #2539
...
93ed9321
cmake: add libversion and libcheckpoints to libwallet_merged (redfish)
2017-10-06 22:57:20 +04:00
Riccardo Spagni
6cf36b4e96
Merge pull request #2530
...
cbc5508b
construct_tx_and_get_tx_key: return sorted sources for print_ring_memebrs to work properly (stoffu)
2017-10-06 22:54:19 +04:00
Riccardo Spagni
1c044b162c
Merge pull request #2529
...
bd937139
wallet2: error check for generate_key_image_helper, removed redundant wallet_generate_key_image_helper (stoffu)
2017-10-06 22:53:28 +04:00
moneromooo-monero
8f0cea6355
add a command_line function to check for defaulted options
2017-10-06 10:56:18 +01:00
moneromooo-monero
f139a6cad0
wallet2: fix backlog being off by 1
...
We don't want to count "partly filled" blocks in this case
2017-10-03 11:49:46 +01:00
moneromooo-monero
452d4fae39
tests: fix hashchain unit tests
...
and relax the not-empty safety check to stay more intuitiuve
2017-10-03 00:51:53 +01:00
stoffu
bd9371395e
wallet2: error check for generate_key_image_helper, removed redundant wallet_generate_key_image_helper
2017-10-03 08:13:00 +09:00
stoffu
cbc5508b15
construct_tx_and_get_tx_key: return sorted sources for print_ring_memebrs to work properly
2017-10-03 08:12:28 +09:00
selsta
986d03d4b2
simplewallet: allow to set threshold before warning about tx backlog
2017-10-02 21:23:33 +02:00
Riccardo Spagni
737717c111
Merge pull request #2491
...
d5a9edf2
wallet2: fix exception on split txes (moneromooo-monero)
5c5b0fd0
wallet2: print unused indices on a single line (moneromooo-monero)
2017-10-02 23:17:57 +04:00
moneromooo-monero
37c12119ab
wallet2: fix hash chain trimming when the inner chain becomes empty
...
It'd prevent further syncing. Recovery of empty hash chains is
automatic, but requires a running daemon
2017-10-02 12:52:22 +01:00
landergate
180a848cbe
wallet2: Missing underflow check on low heights
...
Lack of it results in `m_refresh_from_block_height` being < 0 (18446744...) on low heights, which blocks `process_new_blockchain_entry` and never process coins on heights less than blocks_per_month.
Follow-up to #2258
2017-09-27 14:17:48 +03:00
redfish
93ed932143
cmake: add libversion and libcheckpoints to libwallet_merged
...
Needed to link monero-core Qt wallet.
2017-09-27 00:57:02 -04:00
moneromooo-monero
36c3465b98
wallet2: do not keep block hashes below last checkpoint
...
This saves a lot of space and load/save time for wallet caches
2017-09-25 21:16:40 +01:00
moneromooo-monero
5d65a75b69
move checkpoints in a separate library
2017-09-25 21:16:26 +01:00
moneromooo-monero
2ec928badb
wallet2: simplify tx processing a bit
2017-09-25 18:35:51 +01:00
moneromooo-monero
740e6533a5
wallet2: factor some of the tx scanning code
2017-09-25 16:11:28 +01:00
Riccardo Spagni
32bbe62120
Merge pull request #2456
...
91def9a5
daemon, wallet: add --max-log-file-size option (selsta)
2017-09-25 16:54:08 +02:00
Riccardo Spagni
c2346c6c59
Merge pull request #2424
...
28b72b6e
tx_pool: pre-init tvc.m_verifivation_failed before processing (moneromooo-monero)
50a629b2
core_tests: catch (impossible in practice) tx extra api failure (moneromooo-monero)
fee15ef1
wallet2: catch failure to parse address (moneromooo-monero)
1399e26d
net_peerlist: remove dead code (moneromooo-monero)
50e09698
tx_pool: guard against failure getting tx hash (moneromooo-monero)
54cc209a
wallet_rpc_server: catch failure to create directory (moneromooo-monero)
3e55099c
wallet_rpc_server: init m_vm to NULL in ctor (moneromooo-monero)
7d0dde5e
wallet_args: remove redundant default value for --log-file (moneromooo-monero)
ed4a3350
wallet2: catch failure to save keys file (moneromooo-monero)
44434c8a
wallet2_api: check whether dynamic_cast returns NULL (moneromooo-monero)
92f2f687
core: check return value from parse_hexstr_to_binbuff (moneromooo-monero)
5475692e
wallet2_api: remove an unused, uninitialized, field (moneromooo-monero)
a7ba3de1
libwallet_api_tests: initialize newblock_triggered on reset (moneromooo-monero)
b2763ace
wallet2_api: init error code to "no error" in the ctor (moneromooo-monero)
b5faac53
get_blockchain_top now returns void (moneromooo-monero)
2e44d8f2
wallet_rpc_server: guard against exceptions (moneromooo-monero)
4230876b
simplewallet: guard against I/O exceptions (moneromooo-monero)
06c1e057
daemon: initialize decode_as_json in RPC request (moneromooo-monero)
11f71af5
http_base: init size_t in http_request_info ctor (moneromooo-monero)
2017-09-25 16:52:27 +02:00
Riccardo Spagni
5953724f69
Merge pull request #2443
...
ffe27127
wallet_rpc_server: fix index for newly added address book entry (moneromooo-monero)
2017-09-25 16:51:07 +02:00
Riccardo Spagni
b911130a46
Merge pull request #2442
...
e29282d2
build: auto update version info without manually deleting version.h (stoffu)
2017-09-25 16:50:35 +02:00
moneromooo-monero
fee15ef1a9
wallet2: catch failure to parse address
...
CID 175297
2017-09-25 15:48:48 +01:00
moneromooo-monero
54cc209a5e
wallet_rpc_server: catch failure to create directory
...
CID 175281
2017-09-25 15:48:39 +01:00
moneromooo-monero
3e55099cb2
wallet_rpc_server: init m_vm to NULL in ctor
...
CID 175279
2017-09-25 15:48:36 +01:00
moneromooo-monero
7d0dde5eb5
wallet_args: remove redundant default value for --log-file
...
CID 175265
2017-09-25 15:48:33 +01:00
moneromooo-monero
ed4a33502d
wallet2: catch failure to save keys file
...
CID 161848
2017-09-25 15:48:30 +01:00
moneromooo-monero
44434c8a37
wallet2_api: check whether dynamic_cast returns NULL
...
CID 161844
2017-09-25 15:48:27 +01:00
moneromooo-monero
5475692ed5
wallet2_api: remove an unused, uninitialized, field
...
Silences CID 161874
2017-09-25 15:48:21 +01:00
moneromooo-monero
b2763ace06
wallet2_api: init error code to "no error" in the ctor
...
CID 161872
2017-09-25 15:48:16 +01:00
moneromooo-monero
2e44d8f23c
wallet_rpc_server: guard against exceptions
...
CID 175305
2017-09-25 15:48:10 +01:00
Riccardo Spagni
ce37967dd2
Merge pull request #2386
...
a15e8583
wallet2: guard against daemon sending txes in the wrong order (moneromooo-monero)
8fe5f609
rpc: order transactions in the order they were requested (moneromooo-monero)
2017-09-25 16:40:54 +02:00
Riccardo Spagni
216395d43e
Merge pull request #2379
...
9c83f806
Do not create file when RPC user/pass is given and use file locking (Lee Clagett)
2017-09-25 16:40:35 +02:00
Riccardo Spagni
ec0e144e90
Merge pull request #2377
...
b5cbdce8
wallet2: correctly handle in/out payments for view-only wallet (stoffu)
2017-09-25 16:40:16 +02:00
Riccardo Spagni
40d213154b
Merge pull request #2289
...
6ee1116d
store is optional during close and defaults to true; except during descruction (m2049r)
2017-09-25 16:38:14 +02:00
Riccardo Spagni
c6306e75e7
Merge pull request #2257
...
651baaec
wallet: add encrypted seed functionality (moneromooo-monero)
2017-09-25 16:37:17 +02:00
m2049r
6ee1116d75
store is optional during close and defaults to true; except during descruction
2017-09-23 00:52:09 +02:00
stoffu
e29282d208
build: auto update version info without manually deleting version.h
2017-09-21 07:47:37 +09:00
stoffu
b5cbdce8a6
wallet2: correctly handle in/out payments for view-only wallet
2017-09-21 07:46:19 +09:00
Riccardo Spagni
a6403846ef
Merge pull request #2441
...
fee3c3ed
Update wallet2.cpp for misspelling (Matthew Campassi)
2017-09-20 21:41:33 +02:00
Riccardo Spagni
786a4ae9ea
Merge pull request #2429
...
55b91d86
wallet: fix --help and --version erroring out (moneromooo-monero)
2017-09-20 21:41:09 +02:00
moneromooo-monero
d5a9edf27a
wallet2: fix exception on split txes
2017-09-20 10:35:15 +01:00
moneromooo-monero
5c5b0fd048
wallet2: print unused indices on a single line
...
Decreases log spam massively on large wallets
2017-09-20 10:34:45 +01:00
selsta
91def9a59b
daemon, wallet: add --max-log-file-size option
2017-09-17 04:42:45 +02:00
Howard Chu
510d0d4753
Use a threadpool
...
Instead of constantly creating and destroying threads
2017-09-14 21:42:48 +01:00
moneromooo-monero
ffe2712726
wallet_rpc_server: fix index for newly added address book entry
2017-09-13 11:02:06 +01:00
Matthew Campassi
fee3c3ed1e
Update wallet2.cpp for misspelling
...
Misspelling in wallet2.cpp
2017-09-12 16:11:45 -05:00
moneromooo-monero
651baaec46
wallet: add encrypted seed functionality
...
This uses luigi1111's CN_Add method.
See https://xmr.llcoins.net for details.
2017-09-12 13:56:01 +01:00
moneromooo-monero
a15e858302
wallet2: guard against daemon sending txes in the wrong order
2017-09-11 16:48:28 +01:00
moneromooo-monero
55b91d8605
wallet: fix --help and --version erroring out
2017-09-10 14:12:32 +01:00
Riccardo Spagni
e19b68b005
Merge pull request #2362
...
adce8ae4
simplewallet: new "fee" command to display fee information (moneromooo-monero)
2017-09-02 11:30:07 +02:00
Riccardo Spagni
2560948f69
Merge pull request #2342
...
2e338ca5
wallet2: account for huge testnet reorgs for estimating height (moneromooo-monero)
2017-09-02 11:29:53 +02:00
Riccardo Spagni
10da3051c2
Merge pull request #2309
...
d58700e0
WalletAPI: only allow trusted daemon when importing key images (Jaquee)
8a9bbd26
WalletAPI: copy wallet data when creating a view only wallet (Jaquee)
d27fe32e
wallet2: export/import wallet data functions (Jaquee)
225a25f3
import_key_images - allow importing without being connected to daemon (Jaquee)
2017-09-02 11:28:25 +02:00
Lee Clagett
9c83f8063d
Do not create file when RPC user/pass is given and use file locking
2017-08-30 17:39:59 -04:00
moneromooo-monero
adce8ae466
simplewallet: new "fee" command to display fee information
...
including expected transaction backlog at different priorities
2017-08-29 16:28:18 +01:00
moneromooo-monero
f906d87e66
wallet: new option to check/confirm txpool backlog when sending
2017-08-26 17:16:30 +01:00
moneromooo-monero
2e338ca574
wallet2: account for huge testnet reorgs for estimating height
2017-08-25 11:03:51 +01:00
Jaquee
d58700e003
WalletAPI: only allow trusted daemon when importing key images
2017-08-21 08:11:12 +02:00
Jaquee
8a9bbd26d3
WalletAPI: copy wallet data when creating a view only wallet
2017-08-21 08:11:12 +02:00
Jaquee
d27fe32e4a
wallet2: export/import wallet data functions
2017-08-21 08:11:12 +02:00
Jaquee
225a25f327
import_key_images - allow importing without being connected to daemon
2017-08-18 16:11:30 +02:00
Riccardo Spagni
9e6bcbc014
Merge pull request #2286
...
8655ba04
wallet_rpc_server: adjust small ring sizes to 5 for v6 (moneromooo-monero)
2017-08-15 20:55:30 +02:00
Riccardo Spagni
a861cbb465
Merge pull request #2279
...
359517c7
wallet_rpc_server: fix possible privacy leak in on_import_key_images() (Jaquee)
20495b27
simplewallet: fix possible privacy leak in import_key_images() (Jaquee)
2017-08-15 20:53:58 +02:00
Riccardo Spagni
b6fc7f283f
Merge pull request #2270
...
1307e3cc
WalletAPI: add getDefaultDataDir() (Jaquee)
2017-08-15 20:51:11 +02:00
Riccardo Spagni
9721b37bd5
Merge pull request #2258
...
74597bd1
wallet2: improve refresh height determination (moneromooo-monero)
2017-08-15 20:49:56 +02:00
Riccardo Spagni
085ef96768
Merge pull request #2252
...
9707998a
wallet2: clear some missing containers in clear() (moneromooo-monero)
2017-08-15 20:48:31 +02:00
Riccardo Spagni
6f60613ffb
Merge pull request #2240
...
b7d6ec83
simplewallet: add (out of sync) or (no daemon) markers in the prompt (moneromooo-monero)
fa23a500
wallet2: add a is_synced function (moneromooo-monero)
f1307bbd
node_rpc_proxy: add a proxy for target height (moneromooo-monero)
2017-08-15 20:46:31 +02:00
Riccardo Spagni
4c24eb050b
Merge pull request #2238
...
ad4649ac
Enable verifying wallet password with having to load wallet. (m2049r)
2017-08-15 20:46:09 +02:00
Riccardo Spagni
d64b9c1c9e
Merge pull request #2233
...
67ce4910
wallet2: store testnet bool in keys file (Jaquee)
2017-08-15 20:45:19 +02:00
Riccardo Spagni
68ccc10b29
Merge pull request #2205
...
c97d1bd3
wallet: return unlock_time in get_transfers (moneromooo-monero)
2017-08-15 20:44:44 +02:00
moneromooo-monero
8655ba04ba
wallet_rpc_server: adjust small ring sizes to 5 for v6
2017-08-12 12:59:06 +01:00
Jaquee
359517c7f5
wallet_rpc_server: fix possible privacy leak in on_import_key_images()
2017-08-11 11:18:21 +02:00
Jaquee
1307e3cc12
WalletAPI: add getDefaultDataDir()
2017-08-09 12:38:29 +02:00
Riccardo Spagni
bfd2532ea5
Merge pull request #2247
...
a839a6fa
Wallet API: add tx unlock time (Jaquee)
2017-08-07 23:34:06 +02:00
moneromooo-monero
61770ec2da
change mixin to ring size in user visible places
2017-08-07 21:12:27 +01:00
Riccardo Spagni
3db039828e
Merge pull request #2254
...
e31aac80
walletAPI: add getRefreshFromBlockHeight() (Jaquee)
48c0cb1b
wallet api: pause refresh while commiting tx (Jaquee)
f233c01c
CMakeLists.txt - ios/xcode fix (Jaquee)
2017-08-07 16:01:40 +02:00
Riccardo Spagni
15e895399c
Merge pull request #2239
...
600353e2
fix wallet callback signatures (m2049r)
2017-08-07 15:13:30 +02:00
Riccardo Spagni
1e2d6f898e
Merge pull request #2211
...
525975ac
wallet-cli: Minor improvement to help output (Erik de Castro Lopo)
2017-08-07 15:10:13 +02:00
Riccardo Spagni
f5be5b7e7b
Merge pull request #2210
...
cb0b5594
Move OpenAlias console input back from libs (moneromooo-monero)
2017-08-07 15:09:45 +02:00
Riccardo Spagni
24dd5e87af
Merge pull request #2203
...
0c57df97
wallet2: fix temporarily missing incoming tx when being mined (moneromooo-monero)
2017-08-07 15:09:17 +02:00
Riccardo Spagni
5a04301b32
Merge pull request #2201
...
dc0b312f
wallet_rpc_server: optionally return tx blobs on transfer calls (moneromooo-monero)
5eb79983
epee: add a KV_SERIALIZE variant for optional parameters (moneromooo-monero)
2017-08-07 15:09:03 +02:00
moneromooo-monero
74597bd15a
wallet2: improve refresh height determination
...
As reported by jaquee, the calculation could underflow for very
low heights.
Additionally, we now use the target height too.
2017-08-06 16:56:51 +01:00
Jaquee
e31aac80e5
walletAPI: add getRefreshFromBlockHeight()
2017-08-05 19:23:55 +02:00
Jaquee
48c0cb1ba6
wallet api: pause refresh while commiting tx
2017-08-05 19:21:23 +02:00
moneromooo-monero
9707998a08
wallet2: clear some missing containers in clear()
2017-08-05 18:09:31 +01:00
Jaquee
67ce4910bc
wallet2: store testnet bool in keys file
2017-08-05 17:23:47 +02:00
moneromooo-monero
0c57df9770
wallet2: fix temporarily missing incoming tx when being mined
...
When scanning the txpool without having first updated the
blockchain, the tx would be seen as neither in the txpool
nor the chain, and removed, so it'd only reappear once the
chain is refreshed, and the tx seen in a block.
2017-08-05 12:36:03 +01:00
Jaquee
a839a6fa8a
Wallet API: add tx unlock time
2017-08-03 21:37:45 +02:00
m2049r
ad4649ac81
Enable verifying wallet password with having to load wallet.
2017-08-03 01:45:45 +02:00
moneromooo-monero
fa23a5006d
wallet2: add a is_synced function
2017-08-02 14:44:19 +01:00
moneromooo-monero
f1307bbd7b
node_rpc_proxy: add a proxy for target height
2017-08-02 14:43:47 +01:00
moneromooo-monero
c97d1bd3d4
wallet: return unlock_time in get_transfers
...
also show it in simplewallet's show_transfer
2017-08-02 10:15:27 +01:00
m2049r
600353e2b2
fix wallet callback signatures
2017-08-02 01:23:53 +02:00
Erik de Castro Lopo
525975acc4
wallet-cli: Minor improvement to help output
2017-07-27 20:36:28 +10:00
moneromooo-monero
cb0b559451
Move OpenAlias console input back from libs
...
Library code should definitely not ask for console input unless
it's clearly an input function. Delegating the user interaction
part to the caller means it can now be used by a GUI, or have a
decision algorithm better adapted to a particular caller.
2017-07-27 11:30:13 +01:00
moneromooo-monero
dc0b312f8a
wallet_rpc_server: optionally return tx blobs on transfer calls
...
also add do_not_relay flag to them, so it now becomes possible
to create a tx without sending it yet
2017-07-26 10:33:04 +01:00
Erik de Castro Lopo
35d68b2c6d
Fix spelling errors
2017-07-05 17:53:16 +10:00
Riccardo Spagni
218f1a1d69
Merge pull request #2125
...
f98bf48b
Minor cleanup: tab vs. space + logs messages (binaryFate)
2017-07-03 12:30:46 +02:00
Riccardo Spagni
44e4bbd15c
Merge pull request #2124
...
3b599d2b
wallet2: get current height from the daemon on creation (moneromooo-monero)
d3bb72ff
wallet2: fix infinite loop on future refresh height (moneromooo-monero)
32754784
wallet: fix refresh_from_height setting on new wallet (moneromooo-monero)
2017-07-03 12:30:16 +02:00
Riccardo Spagni
645c898e2d
Merge pull request #2121
...
5a09d79c
Fix #2120 : return per-tx amount in transfer_split RPC call. (binaryFate)
2017-07-03 12:28:56 +02:00
binaryFate
f98bf48b1d
Minor cleanup: tab vs. space + logs messages
2017-06-26 12:30:14 +02:00
binaryFate
5a09d79caf
Fix #2120 : return per-tx amount in transfer_split RPC call.
2017-06-26 12:22:12 +02:00
moneromooo-monero
3b599d2b7e
wallet2: get current height from the daemon on creation
...
Use current time to estimate current height only if the daemon
cannot be queried.
2017-06-26 08:11:14 +01:00
moneromooo-monero
d3bb72fff1
wallet2: fix infinite loop on future refresh height
...
If the refresh height is in the future, the current code will
loop till the actual height reaches this. Fix it by bailing out
if we receive only three hashes, which is what we set in the
call parameters.
2017-06-26 06:58:37 +01:00
moneromooo-monero
32754784db
wallet: fix refresh_from_height setting on new wallet
...
The previous patch was based on a wrong premise (that the
daemon height was 0 because the daemon calling code wasn't
yet initialized). In fact, current height approximation
was not setup for testnet. Fix this.
2017-06-26 06:58:31 +01:00
Mike C
b592cb3f0a
Fix on_transfer RPC incorrect logging info
2017-06-23 11:54:10 -04:00
Riccardo Spagni
ae8841f2ab
Merge pull request #2087
...
4e13ab30
wallet_api: fix missing transaction parameter in callback (moneromooo-monero)
2017-06-18 17:36:55 +02:00
moneromooo-monero
4e13ab306a
wallet_api: fix missing transaction parameter in callback
...
It was unused, so harmless
Reported by erikd on IRC
2017-06-13 19:34:51 +01:00
Robby Weinberg
71f8249a08
Prevent crash if performing certain actions before wallet is initialized
2017-06-03 19:56:51 -05:00
Riccardo Spagni
ea286d1a14
Merge pull request #2058
...
6bcd3b2d
fix get_upper_transaction rename (schnerchi)
2017-06-01 19:42:37 +02:00
schnerchi
6bcd3b2df1
fix get_upper_transaction rename
2017-05-31 12:26:42 +02:00
Riccardo Spagni
f5e65452ce
Merge pull request #2042
...
740bc24c
Wallet API: Set seed lang when recovering form keys (Jaquee)
2017-05-30 21:24:45 +02:00
Riccardo Spagni
a4c13ea092
Merge pull request #2039
...
4b932ff3
changed crypto to cncrypto so it generated libcncrypto (Gentian)
2017-05-30 21:24:11 +02:00
Riccardo Spagni
cd13bcb4d2
Merge pull request #2036
...
89b2f306
tests: fix invalid key image test (moneromooo-monero)
a374a522
wallet2: check key image validity domain in import_key_images (moneromooo-monero)
2017-05-30 21:23:05 +02:00
Riccardo Spagni
d621f9e558
Merge pull request #2022
...
e2529347
Correct spelling of 'get_upper_transaction_size_limit' (Nano Akron)
3029d0ef
Remove the 1.25x multiplier in max transaction size in just the wallet (Nano Akron)
2017-05-30 21:19:00 +02:00
Riccardo Spagni
024860b49d
Merge pull request #2020
...
6cb1ad1f
wallet fix: ensure iterator to be valid (stoffu)
2017-05-30 21:14:24 +02:00
moneromooo-monero
0a182576d0
node_rpc_proxy: fix earliest fork height query for unknown forks
2017-05-26 21:34:44 +01:00
Jaquee
740bc24c95
Wallet API: Set seed lang when recovering form keys
2017-05-23 14:01:23 +02:00
Gentian
4b932ff314
changed crypto to cncrypto so it generated libcncrypto
...
fix a cmakelist
2017-05-23 07:45:40 -04:00
moneromooo-monero
a374a522df
wallet2: check key image validity domain in import_key_images
2017-05-18 09:19:48 +01:00
Nano Akron
e2529347b6
Correct spelling of 'get_upper_transaction_size_limit'
2017-05-09 16:02:57 +01:00
Nano Akron
3029d0efb3
Remove the 1.25x multiplier in max transaction size in just the wallet
2017-05-09 16:01:11 +01:00
stoffu
6cb1ad1fa2
wallet fix: ensure iterator to be valid
2017-05-09 11:54:21 +09:00
moneromooo-monero
391c918d87
wallet2: fix sweep_unmixable assuming wrong minimum mixin at v5
...
The bump to minimum mixin 4 was moved from v5 to v6
2017-05-07 18:27:25 +01:00
Riccardo Spagni
81b370d5a1
Merge pull request #2012
...
bbf4c210
Wallet API: add spend/view key getters (Jaquee)
2017-05-05 11:35:03 +02:00
Jaquee
bbf4c21048
Wallet API: add spend/view key getters
2017-05-02 16:48:38 +02:00
moneromooo-monero
6df83b3efb
wallet: add sweep_below function
...
It sweeps all outputs below the given threshold
This is available via the existing sweep_all RPC, by setting
amount_threshold the desired amount (in atomic units)
2017-04-24 19:50:37 +01:00
Riccardo Spagni
9a9fb0483f
Merge pull request #1996
...
a6d5bb75
wallet2: refer to triangular distribution for recent zone in comment (moneromooo-monero)
ac1aba90
wallet2: bias fake outs more towards recent outputs (moneromooo-monero)
2017-04-24 10:55:24 +02:00
Riccardo Spagni
999b0f399d
Merge pull request #1989
...
7f4beaa4
wallet2: fix removal of wrong txes from unconfirmed_payments (moneromooo-monero)
2017-04-24 10:50:54 +02:00
Riccardo Spagni
ae1d816768
Merge pull request #1976
...
a7d78dda
wallet2: fix --generate-from-json in RPC mode (moneromooo-monero)
2017-04-24 10:48:56 +02:00
Riccardo Spagni
29a77c9b19
Merge pull request #1961
...
89d70756
wallet2: fix spurious output splitting when not merging destinations (moneromooo-monero)
2017-04-24 10:43:39 +02:00
Riccardo Spagni
0a6da8929d
Merge pull request #1959
...
10e137be
wallet2: mention escaping/quoting --password in help string (moneromooo-monero)
2017-04-24 10:43:13 +02:00
moneromooo-monero
a6d5bb75fe
wallet2: refer to triangular distribution for recent zone in comment
...
It was wrongly refering to equiprobable distribution, which I think
I'd originally done, but forgot to update the comment after changing
to triangular
Reported by smooth on IRC
2017-04-22 11:22:39 +01:00
moneromooo-monero
ac1aba90f8
wallet2: bias fake outs more towards recent outputs
...
Two recent papers quantified the real usage bias for the
real output in a ring being the true one, and shows that
the current biasing is much too weak.
While we wait for a better solution, we increase the ratio
of recent-to-total fake outputs, as well as decrease the
time window for recent outputs, so that half the fake outs
are selected within the last 1.8 day. Value plucked from
figure 10, page 11 of An Empirical Analysis of Linkability
in the Monero Blockchain, 2017, Miller et al.
This is also arbitrary, of course, but serves as a stopgap
till a better selection algorithm is chosen.
2017-04-22 10:29:03 +01:00
moneromooo-monero
7f4beaa44a
wallet2: fix removal of wrong txes from unconfirmed_payments
...
unconfirmed_payments changed from having the txid as key to
the payment id, and this was not changed to match.
2017-04-17 19:37:13 +01:00
moneromooo-monero
a7d78dda77
wallet2: fix --generate-from-json in RPC mode
...
The daemon address was initialized too late
2017-04-14 22:12:20 +01:00
Howard Chu
110b683152
Resolve #92 add ability to create wallets thru RPC
...
Reviewed and squashed. Open/Create is only allowed if no walletfile
was specified at startup.
2017-04-11 01:22:44 +01:00
Riccardo Spagni
4be94be168
Merge pull request #1951
...
0a7885bf
Wallet API: fix Cold signing split tx (Jaquee)
2017-04-11 00:26:47 +02:00
Riccardo Spagni
e9ca165b1a
Merge pull request #1950
...
f5bd3465
IOS CMAKE build settings (Jaquee)
d8a88d05
add IOS CMAKE toolchain (Jaquee)
2017-04-11 00:26:15 +02:00
moneromooo-monero
89d707566a
wallet2: fix spurious output splitting when not merging destinations
2017-04-08 11:13:28 +01:00
moneromooo-monero
10e137be3a
wallet2: mention escaping/quoting --password in help string
2017-04-06 21:24:55 +01:00
Jaquee
f5bd346573
IOS CMAKE build settings
2017-04-03 18:38:50 +02:00
Jaquee
0a7885bf19
Wallet API: fix Cold signing split tx
2017-04-02 14:19:21 +02:00
moneromooo-monero
0ee018b407
wallet2: do not go over the target tx size if many destinations
...
If using a large input and many destinations, the code would
generate as many outputs as it could using that input, even if
it would bring the resulting tx above the max tx size.
2017-04-02 11:13:15 +01:00
moneromooo-monero
a50c4a4fad
wallet: option to merge destinations
...
With the change from the original transfer method to the new
algorithm, payments to the same destination were merged. It
seemed like a good idea, optimizing space. However, it is a
useful tool for people who want to split large outputs into
several smaller ones (ie, service providers making frequent
payments, and who do not like a large chunk of their balance
being locked for 10 blocks after each payment).
Default to off, which is a change from the previous behavior.
2017-03-25 11:44:04 +00:00
moneromooo-monero
0ad87db01f
wallet: try to save large outputs when using an unneeded second input
...
When a single input is enough to satisfy a transfer, the code would
previously try to add a second input, to match the "canonical" makeup
of a transaction with two inputs and two outputs. This would cause
wallets to slowly merge outputs till all the monero ends up in a
single output, which causes trouble when making two transactions
one after the other, since change is locked for 10 blocks, and an
increasing portion of the remaining balance would end up locked on
each transaction.
There are two new settings (min-output-count and min-output-value)
which can control when to stop adding such unneeded second outputs.
The idea is that small "dust" outputs will still get added, but
larger ones will not.
Enable with, eg:
set min-output-count 10
set min-output-value 30
to avoid using an unneeded second output of 30 monero or more, if
there would be less than 10 such outputs left.
This does not invalidate any other reason why such outputs would
be used (ie, when they're really needed to satisfy a transfer, or
when randomly picked in the normal course of selection). This may
be improved in the future.
2017-03-24 21:04:08 +00:00
Riccardo Spagni
92c2d79d10
Merge pull request #1915
...
a8646b09
Wallet API: add hard fork info functions (Jaquee)
2017-03-24 14:34:55 +02:00
Riccardo Spagni
f543377789
Merge pull request #1894
...
8bbcbcfb
wallet rpc: enable solo mining (stoffu)
2017-03-24 14:33:47 +02:00
Jaquee
a8646b0957
Wallet API: add hard fork info functions
2017-03-24 09:59:26 +01:00
moneromooo-monero
558cfc31ca
core, wallet: faster tx pool scanning
...
Includes a new RPC to get tx pool hashes fast.
2017-03-23 09:25:22 +00:00
Riccardo Spagni
70e71a1845
Merge pull request #1904
...
995969b1
wallet: fix set_log not handling 0,xxx style settings (moneromooo-monero)
2017-03-21 14:09:42 +02:00
Riccardo Spagni
7769a6e757
Merge pull request #1903
...
350e99ae
wallet2: cache which pool txes were scanned already (moneromooo-monero)
2017-03-21 14:09:19 +02:00
Riccardo Spagni
9d157b519d
Merge pull request #1899
...
c1e9ccc7
wallet2: speed up transactions using remote nodes (moneromooo-monero)
2017-03-21 14:08:36 +02:00
moneromooo-monero
995969b190
wallet: fix set_log not handling 0,xxx style settings
2017-03-21 11:17:05 +00:00
moneromooo-monero
350e99ae57
wallet2: cache which pool txes were scanned already
...
This massively speeds up the wallet updating the pool on mainnet,
where the tx backlog is more than 500 txes.
2017-03-21 10:30:25 +00:00
moneromooo-monero
5b7c6ced80
wallet2: start using new fee priorities at v5, not 14 days laer
...
Waiting would mean the fee used is 1x base, but the base will
have suddenly dropped
2017-03-20 18:34:56 +00:00
moneromooo-monero
c1e9ccc794
wallet2: speed up transactions using remote nodes
...
Asking for a full histogram from a remote node (since it's
untrusted) is pretty slow, and spams the remote node, so
we replace it by only adding a second input if we have rct
ones, which are for all intents and purposes always mixable.
2017-03-20 08:44:28 +00:00
stoffu
8bbcbcfb0d
wallet rpc: enable solo mining
2017-03-20 09:47:16 +09:00
Riccardo Spagni
45fa27b56a
Merge pull request #1892
...
df810a82
wallet-rpc bugfix: get_transfer_by_txid previously checking against payment id (kenshi84)
2017-03-19 22:58:55 +02:00
kenshi84
df810a8250
wallet-rpc bugfix: get_transfer_by_txid previously checking against payment id
2017-03-19 17:45:39 +09:00
moneromooo-monero
24ae71404f
wallet: increase node_rpc_proxy timeout to match wallet2
2017-03-18 23:06:06 +00:00
Riccardo Spagni
a6f1959d1c
Merge pull request #1884
...
e9175cec
wallet_rpc_server: make a few RPCs unavailable in restricted mode (moneromooo-monero)
2017-03-18 20:30:50 +02:00
Riccardo Spagni
f33a696ec7
Merge pull request #1883
...
d0238313
use const references in catch blocks (moneromooo-monero)
2017-03-18 20:30:19 +02:00
Riccardo Spagni
9aac64c238
Merge pull request #1882
...
3fa59755
wallet2: call is_key_image_spent in blocks in rescan_spent (moneromooo-monero)
9d134e86
wallet_rpc_server: add a rescan_spent RPC (moneromooo-monero)
2017-03-18 20:29:22 +02:00
moneromooo-monero
e9175cec07
wallet_rpc_server: make a few RPCs unavailable in restricted mode
...
Address book modification, setting tx nodes, importing key images
2017-03-18 13:01:53 +00:00
moneromooo-monero
d023831327
use const references in catch blocks
2017-03-18 12:56:07 +00:00
moneromooo-monero
3fa5975520
wallet2: call is_key_image_spent in blocks in rescan_spent
...
This is a potentially long lasting daemon RPC call
2017-03-18 12:47:07 +00:00
moneromooo-monero
9d134e8647
wallet_rpc_server: add a rescan_spent RPC
2017-03-18 12:04:17 +00:00
stoffu
250c4cb3e0
wallet-rpc: enable openalias
2017-03-17 10:42:10 +09:00
Riccardo Spagni
c642d3224c
Merge pull request #1869
...
3396a9f2
Add intervening v5 fork for increased min block size (moneromooo-monero)
2017-03-15 18:23:51 +01:00
moneromooo-monero
3396a9f2af
Add intervening v5 fork for increased min block size
...
Minimum mixin 4 and enforced ringct is moved from v5 to v6.
v5 is now used for an increased minimum block size (from 60000
to 300000) to cater for larger typical/minimum transaction size.
The fee algorithm is also changed to decrease the base per kB
fee, and add a cheap tier for those transactions which we do
not care if they get delayed (or even included in a block).
2017-03-15 08:32:51 +00:00
Arne Brutschy
badec326d8
Adds a config file option to the wallet
2017-03-12 21:45:59 +01:00
Riccardo Spagni
5bcb25f3f8
Merge pull request #1846
...
4b48565c
wallet: add password command (moneromooo-monero)
2017-03-06 15:14:59 +00:00
Riccardo Spagni
8cb58dbb69
Merge pull request #1842
...
223fe5bb
wallet: fix get_tranfers with multiple incoming txes with same pid (moneromooo-monero)
2017-03-05 17:52:42 +02:00
moneromooo-monero
4b48565c9e
wallet: add password command
...
Also tweak wallet2 password code to verify password without
saying it's a new wallet, because it's assuming things.
2017-03-05 14:53:46 +00:00
moneromooo-monero
223fe5bbe2
wallet: fix get_tranfers with multiple incoming txes with same pid
2017-03-04 21:47:53 +00:00
moneromooo-monero
c7dd0b1535
Revert "wallet: fix insertion of pool transactions"
...
This reverts commit d47dac9a88
.
Callers actually expect the key to be payment id, so this
needs a lot more changes (like storing payment ids in the
structure, and possibly also to other existing structures
which do the same thing).
2017-03-04 12:41:19 +00:00
Jaquee
9ae33b51fb
wallet api: fix parameters in wallet2callbackImpl
2017-03-03 15:49:12 +01:00
Jaquee
1cf2f5a5c2
use txid in wallet2::process_new_transaction()
2017-03-03 15:48:32 +01:00
Riccardo Spagni
e24cd86c18
Merge pull request #1827
...
db1c7d80
wallet api: add missing mining options (Jaquee)
2017-03-03 14:31:28 +02:00
Riccardo Spagni
d35d626181
Merge pull request #1826
...
2c468dd4
allow user I/O in millinero, micronero, nanonero, piconero (moneromooo-monero)
2017-03-03 14:31:04 +02:00
Riccardo Spagni
2f9ecd4fba
Merge pull request #1823
...
d47dac9a
wallet: fix insertion of pool transactions (moneromooo-monero)
2017-03-03 14:30:24 +02:00
Riccardo Spagni
78a99fe7da
Merge pull request #1820
...
7a44f38a
Add support for the wallet to refresh pruned blocks (moneromooo-monero)
da18898f
ringct: do not require range proof in decodeRct/decodeRctSimple (moneromooo-monero)
b49c6ab4
rpc: add a default category for daemon rpc (moneromooo-monero)
f113b92b
core: add functions to serialize base tx info (moneromooo-monero)
6fd4b827
node_rpc_proxy: allow caching daemon RPC version (moneromooo-monero)
b5c74e40
wallet: invalidate node proxy cache when reconnecting (moneromooo-monero)
2017-03-03 14:30:02 +02:00
Riccardo Spagni
460836a2b7
Merge pull request #1813
...
b8a08f19
wallet: fix --log-file not working (moneromooo-monero)
2017-03-03 14:14:09 +02:00
Riccardo Spagni
14c6c910d7
Merge pull request #1803
...
53105743
Wallet API: Add support for daemon rpc login (Jaquee)
2017-03-03 14:10:44 +02:00
moneromooo-monero
2c468dd429
allow user I/O in millinero, micronero, nanonero, piconero
2017-03-02 19:02:41 +00:00
Jaquee
db1c7d80b1
wallet api: add missing mining options
2017-03-02 14:09:04 +01:00
moneromooo-monero
d47dac9a88
wallet: fix insertion of pool transactions
...
They were inserted using payment id as key, not txid
2017-02-28 21:19:24 +00:00
moneromooo-monero
b8a08f199a
wallet: fix --log-file not working
2017-02-28 09:07:56 +00:00
moneromooo-monero
7a44f38a7f
Add support for the wallet to refresh pruned blocks
2017-02-27 22:29:00 +00:00
moneromooo-monero
6fd4b827fb
node_rpc_proxy: allow caching daemon RPC version
2017-02-27 17:57:18 +00:00
moneromooo-monero
b5c74e4041
wallet: invalidate node proxy cache when reconnecting
2017-02-27 17:46:55 +00:00
Jaquee
5310574382
Wallet API: Add support for daemon rpc login
2017-02-25 22:17:35 +01:00
moneromooo-monero
cf2b151116
wallet: avoid pre-log-init spew on --version
2017-02-24 19:08:02 +00:00
Riccardo Spagni
57f15994a5
Merge pull request #1797
...
ada6a8a2
wallet_rpc_server: new --trusted-daemon flag (moneromooo-monero)
2017-02-24 20:33:04 +02:00
moneromooo-monero
ada6a8a2de
wallet_rpc_server: new --trusted-daemon flag
...
and remove trusted_daemon fields from transfer RPCs,
it is much friendlier on users
2017-02-24 18:20:14 +00:00
Riccardo Spagni
3435038a4d
add rpc timeouts to calls that might timeout
2017-02-24 19:17:22 +02:00
Jaquee
e4dbea976e
wallet2: fix wrong status on daemon shutdown/startup
2017-02-23 12:41:21 +01:00
moneromooo-monero
14d0e00235
wallet2_api: add updates check api
2017-02-22 13:03:45 +00:00
Riccardo Spagni
c3599fa7b9
update copyright year, fix occasional lack of newline at line end
2017-02-21 19:38:18 +02:00
Riccardo Spagni
50fadea8fa
Merge pull request #1747
...
26bd7aac
wallet_api: fix logging init via api (moneromooo-monero)
2017-02-21 11:28:58 +02:00
Riccardo Spagni
d596722dfa
Merge pull request #1749
...
5a3b1e98
wallet2: fix failure to send (relatedness check in wrong case) (moneromooo-monero)
2017-02-21 11:15:40 +02:00
moneromooo-monero
5a3b1e983c
wallet2: fix failure to send (relatedness check in wrong case)
...
A relatedness check was meant to be done in the case of adding
an extra output if just one was enough. This was mistakenly
added to the "preferred output" case.
2017-02-19 09:31:54 +00:00
moneromooo-monero
26bd7aac03
wallet_api: fix logging init via api
2017-02-18 20:44:23 +00:00
moneromooo-monero
83ec209f42
simplewallet: validate hex input size
2017-02-14 19:45:46 +00:00
iDunk5400
b2ac939eb3
Fix GUI building after libcryptonote_core was split ( #1626 )
2017-02-11 17:00:55 +01:00
Riccardo Spagni
eacf2124b6
Merge pull request #1689
...
ce7fcbb4
Add server auth to monerod, and client auth to wallet-cli and wallet-rpc (Lee Clagett)
2017-02-11 00:35:25 +02:00
Riccardo Spagni
9296960081
Merge pull request #1686
...
bceaf4b7
wallet2: fix transactions not considering rct inputs (moneromooo-monero)
2017-02-11 00:22:17 +02:00
Riccardo Spagni
9781ecaa70
Merge pull request #1685
...
7549116e
Wallet API: Easylogger wrapper for gui (Jaquee)
2017-02-11 00:21:51 +02:00
kenshi84
8027ce0c75
extract some basic code from libcryptonote_core into libcryptonote_basic
2017-02-08 22:45:15 +09:00
Riccardo Spagni
99ee3fd17e
Merge pull request #1679
...
4efc926d
Wallet API: Catch error from tools::is_local_address (Jaquee)
2017-02-08 12:53:57 +02:00
moneromooo-monero
bceaf4b788
wallet2: fix transactions not considering rct inputs
...
I broke this very recently in 2bf029be17
and didn't notice in time
2017-02-06 20:20:22 +00:00
Lee Clagett
ce7fcbb4ae
Add server auth to monerod, and client auth to wallet-cli and wallet-rpc
2017-02-06 01:15:41 -05:00
Jaquee
7549116ec3
Wallet API: Easylogger wrapper for gui
2017-02-05 20:12:01 +01:00
Jaquee
4efc926d28
Wallet API: Catch error from tools::is_local_address
2017-02-05 11:08:05 +01:00
Jaquee
0cc50bdd11
GUI: Improved refresh performance
2017-02-04 23:25:05 +01:00
Jaquee
805625b541
wallet api: Remove initAsync() and don't start refresh automatically on init
2017-02-04 23:25:03 +01:00
Jaquee
031b060af0
wallet2::init() - disconnect before init if connected
...
Makes it possible for GUI to reinit with new daemon without closing and reopening wallet.
2017-02-04 23:10:20 +01:00
Riccardo Spagni
e56bf442c3
Merge pull request #1669
...
4f5b130d
wallet_rpc_server: add address book RPC calls (moneromooo-monero)
2017-02-04 17:28:53 +02:00
Riccardo Spagni
31cf4e7362
Merge pull request #1640
...
f97526e6
simplewallet: option to always ask password for any crytical operations (kenshi84)
2017-02-04 17:18:38 +02:00
moneromooo-monero
4f5b130de9
wallet_rpc_server: add address book RPC calls
2017-02-04 11:40:49 +00:00
kenshi84
f97526e641
simplewallet: option to always ask password for any crytical operations
2017-02-03 09:38:12 +09:00
Riccardo Spagni
58c87786ae
Merge pull request #1652
...
fba9332d
Changed console output for transaction from L0 to L1 (NanoAkron)
2017-02-02 21:36:56 +02:00
Riccardo Spagni
011c5a8a7c
Merge pull request #1647
...
2bf029be
wallet2: fix corner case failing to send a second output (moneromooo-monero)
2017-02-02 21:35:31 +02:00
Riccardo Spagni
10b625079b
Merge pull request #1645
...
9bd9906e
Factor is_address_local code into a tools function (moneromooo-monero)
2017-02-02 21:27:45 +02:00
Riccardo Spagni
614400e5af
Merge pull request #1643
...
69d2ad39
wallet_rpc_server: fix logs going to the wrong file (moneromooo-monero)
2017-02-02 21:26:56 +02:00
Riccardo Spagni
5bb95fc613
Merge pull request #1634
...
99f58437
Fix invalid + of std::string and int (Timothy D. Prime)
2017-02-02 19:43:05 +02:00
Riccardo Spagni
5fb3f97a55
Merge pull request #1629
...
c02e1cb9
Updates to epee HTTP client code - http_simple_client now uses std::chrono for timeouts - http_simple_client accepts timeouts per connect / invoke call - shortened names of epee http invoke functions - invoke command functions only take relative path, connection is not automatically performed (Lee Clagett)
2017-02-02 19:32:01 +02:00
Riccardo Spagni
f9e60dcd55
Merge pull request #1617
...
0644eed7
Remove boost/foreach.cpp includes (Miguel Herranz)
36dd3e23
Replace BOOST_REVERSE_FOREACH with ranged for (Miguel Herranz)
629e3101
Replace BOOST_FOREACH with C++11 ranged for (Miguel Herranz)
2017-02-02 18:16:39 +02:00
luigi1111
3cef7fbbb6
Merge pull request 1635
...
774a213
Wallet API: Create wallet from keys (Jaqueeee)
2017-01-30 17:09:38 -06:00
Jaquee
774a21394a
Wallet API: Create wallet from keys
2017-01-30 23:28:09 +01:00
NanoAkron
fba9332de8
Changed console output for transaction from L0 to L1
2017-01-30 03:24:51 +00:00
moneromooo-monero
8c8482ac98
wallet_rpc_server: fix short payment id validation in transfer
2017-01-29 16:10:20 +00:00
moneromooo-monero
2bf029be17
wallet2: fix corner case failing to send a second output
...
If a rct transaction can be made with just one input, a second
output will be added. This output will be the smallest amount
output available. However, if this output is a non rct output
with less available fake outs than requested, the transaction
will be rejected. We now check the histogram to only consider
outputs with enough available fake outs in the first place.
2017-01-28 15:07:15 +00:00
moneromooo-monero
9bd9906e8f
Factor is_address_local code into a tools function
2017-01-28 14:57:47 +00:00
moneromooo-monero
69d2ad3967
wallet_rpc_server: fix logs going to the wrong file
2017-01-28 11:37:21 +00:00
luigi1111
4629ead8c5
Merge pull request #1618
2017-01-27 11:33:26 -06:00
Timothy D. Prime
99f584376e
Fix invalid + of std::string and int
...
These warnings were emitted by clang++, and they are real bugs.
src/rpc/core_rpc_server.cpp:208:58: warning: adding 'uint64_t'
(aka 'unsigned long') to a string does not append to the string
[-Wstring-plus-int]
res.status = "Error retrieving block at height " + height;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
The obvious intent is achieved by using std::to_string().
2017-01-26 10:11:37 -08:00
Lee Clagett
c02e1cb943
Updates to epee HTTP client code
...
- http_simple_client now uses std::chrono for timeouts
- http_simple_client accepts timeouts per connect / invoke call
- shortened names of epee http invoke functions
- invoke command functions only take relative path, connection
is not automatically performed
2017-01-25 15:39:32 -05:00
Riccardo Spagni
6f39ba5909
Merge pull request #1621
...
feed6175
fixed typo: monero-wallet-cli,log (kenshi84)
2017-01-23 08:11:02 -05:00
kenshi84
feed6175ea
fixed typo: monero-wallet-cli,log
2017-01-23 11:44:06 +09:00
=
e92c4fff1a
Wallet api: testnet getter
2017-01-22 23:02:01 +01:00
Miguel Herranz
629e3101ab
Replace BOOST_FOREACH with C++11 ranged for
2017-01-22 21:38:10 +01:00
Riccardo Spagni
17247b23bf
Merge pull request #1612
...
20f71527
wallet2: fix sending a rct tx with a single output available (moneromooo-monero)
2017-01-22 11:49:20 -05:00
moneromooo-monero
20f7152769
wallet2: fix sending a rct tx with a single output available
...
This would have tried to send a second output to make the tx
look like the 2/2 ideal, but it would not fail to find one
because picking an output from preferred_inputs priority list
did not remove it from the unused tranfer/dust outputs, so
it would try to send the same output twice.
While there, I also added a check to avoid sending a second
input if it's related to the first. Better 1/2 than linking
inputs, I think.
2017-01-22 15:16:45 +00:00
Riccardo Spagni
39aaea8e62
Merge pull request #1599
...
17246d05
wallet: print exception message on get_random_outs_error (moneromooo-monero)
2017-01-20 21:00:01 -05:00
moneromooo-monero
17246d051d
wallet: print exception message on get_random_outs_error
2017-01-20 18:01:13 +00:00
moneromooo-monero
87c658f83b
wallet2_api: add API to set log categories
2017-01-16 21:14:44 +00:00
moneromooo-monero
693c190881
wallet: add a node RPC cache layer for simple RPC calls
...
Mostly getinfo and get_hard_fork_info, which are called
pretty often. This speeds up transfers as a bonus.
2017-01-16 08:59:15 +00:00
moneromooo-monero
d86ae2bec6
wallet2: reuse fake outs when adjusting fee on transfer
...
This avoids indirectly leaking the real output to the daemon,
and is faster.
This will still happen for more complex cases, especially
when cancelling a tx and "re-rolling" it.
2017-01-16 08:59:08 +00:00
Riccardo Spagni
ab69d5b367
Merge pull request #1569
...
16b8b66a
specify restore height by YYYY-MM-DD format (kenshi84)
2017-01-15 20:32:57 -05:00
kenshi84
16b8b66adc
specify restore height by YYYY-MM-DD format
2017-01-16 10:00:28 +09:00
moneromooo-monero
5833d66f65
Change logging to easylogging++
...
This replaces the epee and data_loggers logging systems with
a single one, and also adds filename:line and explicit severity
levels. Categories may be defined, and logging severity set
by category (or set of categories). epee style 0-4 log level
maps to a sensible severity configuration. Log files now also
rotate when reaching 100 MB.
To select which logs to output, use the MONERO_LOGS environment
variable, with a comma separated list of categories (globs are
supported), with their requested severity level after a colon.
If a log matches more than one such setting, the last one in
the configuration string applies. A few examples:
This one is (mostly) silent, only outputting fatal errors:
MONERO_LOGS=*:FATAL
This one is very verbose:
MONERO_LOGS=*:TRACE
This one is totally silent (logwise):
MONERO_LOGS=""
This one outputs all errors and warnings, except for the
"verify" category, which prints just fatal errors (the verify
category is used for logs about incoming transactions and
blocks, and it is expected that some/many will fail to verify,
hence we don't want the spam):
MONERO_LOGS=*:WARNING,verify:FATAL
Log levels are, in decreasing order of priority:
FATAL, ERROR, WARNING, INFO, DEBUG, TRACE
Subcategories may be added using prefixes and globs. This
example will output net.p2p logs at the TRACE level, but all
other net* logs only at INFO:
MONERO_LOGS=*:ERROR,net*:INFO,net.p2p:TRACE
Logs which are intended for the user (which Monero was using
a lot through epee, but really isn't a nice way to go things)
should use the "global" category. There are a few helper macros
for using this category, eg: MGINFO("this shows up by default")
or MGINFO_RED("this is red"), to try to keep a similar look
and feel for now.
Existing epee log macros still exist, and map to the new log
levels, but since they're used as a "user facing" UI element
as much as a logging system, they often don't map well to log
severities (ie, a log level 0 log may be an error, or may be
something we want the user to see, such as an important info).
In those cases, I tried to use the new macros. In other cases,
I left the existing macros in. When modifying logs, it is
probably best to switch to the new macros with explicit levels.
The --log-level options and set_log commands now also accept
category settings, in addition to the epee style log levels.
2017-01-16 00:25:46 +00:00
Riccardo Spagni
ec323d8c3f
Merge pull request #1561
...
d561f4ad
enable clang checks that were disabled (Chris Vickio)
0aefb2f6
remove std::move from return statements (pessimizing-move warning) (Chris Vickio)
629d5b76
change counter from bool to int (deprecated-increment-bool warning) (Chris Vickio)
fb76d439
add extra braces around subobjects (missing-braces warning) (Chris Vickio)
3b6d5f25
make struct/class declarations consistent (mismatched-tags warning) (Chris Vickio)
fcf66925
remove unused fields from network_throttle (unused-private-field warning) (Chris Vickio)
296f8c16
inline unused function (for unused-function warning) (Chris Vickio)
2017-01-15 19:01:08 -05:00
Riccardo Spagni
9cda94d0aa
Merge pull request #1574
...
d276a165
wallet2: use at least two rct inputs if possible (moneromooo-monero)
2017-01-15 14:55:40 -05:00
Riccardo Spagni
f00797a1f2
Merge pull request #1573
...
dea53962
fix timeout in check_connection (Jaquee)
2017-01-15 14:55:12 -05:00
Riccardo Spagni
31de98793f
Merge pull request #1567
...
c9f13c5e
wallet2: fix tx reroll not updating fee is going up a kB step (moneromooo-monero)
2017-01-15 14:47:44 -05:00
Riccardo Spagni
865f5bef34
Merge pull request #1564
...
1d317981
Wallet API: add key image import/export functions (Jaquee)
2017-01-15 14:46:52 -05:00
Riccardo Spagni
935f50471c
Merge pull request #1560
...
46550c0b
Wallet API: add rescanSpent() (Jaquee)
2017-01-15 14:44:49 -05:00
Chris Vickio
0aefb2f60a
remove std::move from return statements (pessimizing-move warning)
2017-01-15 19:23:33 +03:00
Chris Vickio
629d5b7689
change counter from bool to int (deprecated-increment-bool warning)
2017-01-15 19:23:33 +03:00
moneromooo-monero
d276a16526
wallet2: use at least two rct inputs if possible
...
If we'd make a rct tx with just one input, we try to add
a second one to match the 2/2 ideal. This means more txes
use that template (and are thus using a larger anonymity
set), and it coalesces outputs "for free". We use the
smallest amount outputs in priority for this, so we can
"clean" the wallet at the same time.
2017-01-14 21:43:01 +00:00
Jaquee
dea53962a3
fix timeout in check_connection
2017-01-14 14:45:30 +01:00
Chris Vickio
3b6d5f255d
make struct/class declarations consistent (mismatched-tags warning)
2017-01-14 15:06:07 +03:00
moneromooo-monero
c9f13c5e54
wallet2: fix tx reroll not updating fee is going up a kB step
2017-01-13 22:28:19 +00:00
Jaquee
1d3179816b
Wallet API: add key image import/export functions
2017-01-13 23:02:20 +01:00
Jaquee
4a0176740d
Wallet API: support integrated addresses in address book.
2017-01-13 22:41:17 +01:00
Jaquee
46550c0b4f
Wallet API: add rescanSpent()
2017-01-13 22:05:39 +01:00
Riccardo Spagni
2806842200
Merge pull request #1562
...
a081b39c
Move key image export/import functions to wallet2 (Jaquee)
2017-01-13 14:38:29 -05:00
Riccardo Spagni
2a2f02e375
Merge pull request #1559
...
db56a03f
Wallet2 + API: Callbacks for unconfirmed transfers (Jaquee)
2017-01-13 14:37:12 -05:00
Riccardo Spagni
faa33fc326
Merge pull request #1541
...
0d3918e1
Wallet api: Update trustedDaemon when daemon is changed (Jaquee)
dbb838f4
GUI cold signing (Jaquee)
afb85a02
Wallet API: functions for supporting/creating view only wallets (Jaquee)
2017-01-13 14:34:55 -05:00
Riccardo Spagni
e51afeb90f
Merge pull request #1540
...
79b4e1f9
Cold signing: make sure short payment id isnt encrypted twice (Jaquee)
2017-01-13 14:34:26 -05:00
Riccardo Spagni
36b84ded95
Merge pull request #1526
...
5eed5b05
Wallet API: functions for supporting/creating view only wallets (Jaquee)
2017-01-13 14:32:26 -05:00
Riccardo Spagni
aeeb24991a
Merge pull request #1523
...
d81cb087
Added (not yet enabled) HTTP client authentication (Lee Clagett)
2017-01-13 14:32:08 -05:00
Riccardo Spagni
71c7577370
Merge pull request #1513
...
a813ab50
wallet2_api: add solo mining API (moneromooo-monero)
2017-01-13 13:24:45 -05:00
Jaquee
a081b39c01
Move key image export/import functions to wallet2
2017-01-13 12:49:10 +01:00
Jaquee
db56a03ff2
Wallet2 + API: Callbacks for unconfirmed transfers
2017-01-12 18:25:34 +01:00
Lee Clagett
d81cb08704
Added (not yet enabled) HTTP client authentication
2017-01-11 03:21:17 -05:00
Jaquee
0d3918e15b
Wallet api: Update trustedDaemon when daemon is changed
2017-01-10 22:49:30 +01:00
Jaquee
dbb838f4d0
GUI cold signing
...
fix conflict
2017-01-10 22:49:17 +01:00
Jaquee
afb85a028f
Wallet API: functions for supporting/creating view only wallets
2017-01-10 22:49:11 +01:00
Jaquee
5eed5b056b
Wallet API: functions for supporting/creating view only wallets
2017-01-10 22:34:46 +01:00
moneromooo-monero
a813ab50fe
wallet2_api: add solo mining API
2017-01-09 10:12:55 +00:00
kenshi84
f1dde1a429
wallet cli: print originating block heights of mixin keys when making transfer
2017-01-09 15:10:34 +09:00
Riccardo Spagni
c6ec939626
Merge pull request #1542
...
60fe1b61
Add parse_uri to wallet2_api (MoroccanMalinois)
2017-01-08 16:47:42 -08:00
Riccardo Spagni
59021496d8
Merge pull request #1537
...
c2135082
simplewallet: add a show_transfer <txid> command (moneromooo-monero)
19c4041d
wallet_rpc_server: new RPC call to get a transfer by txid (moneromooo-monero)
2017-01-08 16:44:29 -08:00
Riccardo Spagni
6cbfe0f849
Merge pull request #1521
...
21c5af5a
wallet2_api: add an address book payment id lookup API (moneromooo-monero)
2017-01-08 16:42:08 -08:00
Riccardo Spagni
ba9744d400
Merge pull request #1515
...
ada7c7da
portable serializer: tests added (kenshi84)
f390a0e2
portable serializer: make signerd/unsigned tx portable, ignore archive version checking (kenshi84)
2017-01-08 16:41:44 -08:00
Riccardo Spagni
da05900524
Merge pull request #1509
...
29333c41
wallet api: prevent setting refresh height too high (Jaquee)
2017-01-08 16:39:23 -08:00
Riccardo Spagni
13c5da2aa3
Merge pull request #1508
...
4585ada4
Wallet2: faster exit while refreshing (Jaquee)
2017-01-08 16:39:07 -08:00
Riccardo Spagni
0ce4618bea
Merge pull request #1504
...
5f4ac6b9
wallet2 bugfix: store watch_only flag properly with rewrite() (kenshi84)
2017-01-08 16:38:19 -08:00
Riccardo Spagni
06de09daf4
Merge pull request #1501
...
cebae0c5
wallet2: check the node returned the real output when requested (moneromooo-monero)
2017-01-08 16:37:11 -08:00
Riccardo Spagni
1736b7ef6b
Merge pull request #1500
...
c0a0fcaf
wallet2_api: some new APIs to access daemon state (moneromooo-monero)
2017-01-08 16:36:46 -08:00
Riccardo Spagni
03497f0268
Merge pull request #1497
...
50511677
wallet2: fix large reorgs failing (moneromooo-monero)
2017-01-08 16:35:14 -08:00
MoroccanMalinois
60fe1b61e0
Add parse_uri to wallet2_api
2017-01-08 22:53:24 +00:00
Jaquee
79b4e1f997
Cold signing: make sure short payment id isnt encrypted twice
2017-01-08 21:04:53 +01:00
moneromooo-monero
19c4041df5
wallet_rpc_server: new RPC call to get a transfer by txid
2017-01-08 13:16:22 +00:00
kenshi84
ada7c7da8f
portable serializer: tests added
2017-01-03 09:14:48 +09:00
kenshi84
f390a0e2dc
portable serializer: make signerd/unsigned tx portable, ignore archive version checking
2017-01-02 20:04:58 +09:00
moneromooo-monero
21c5af5a8a
wallet2_api: add an address book payment id lookup API
2017-01-01 16:06:34 +00:00
Jaquee
29333c417e
wallet api: prevent setting refresh height too high
2016-12-27 19:38:05 +01:00
Jaquee
4585ada453
Wallet2: faster exit while refreshing
2016-12-27 19:12:18 +01:00
moneromooo-monero
cebae0c510
wallet2: check the node returned the real output when requested
2016-12-27 09:38:10 +00:00
kenshi84
5f4ac6b909
wallet2 bugfix: store watch_only flag properly with rewrite()
2016-12-26 18:33:24 +09:00
moneromooo-monero
c0a0fcaff0
wallet2_api: some new APIs to access daemon state
2016-12-25 12:31:50 +00:00
moneromooo-monero
505116771e
wallet2: fix large reorgs failing
...
If a reorg was large enough that a full 1000 block chunk
from the daemon was all known blocks, refresh would stop,
and no reorg would happen.
2016-12-24 16:04:37 +00:00
kenshi84
99580adf66
make openalias also available for solo miner; introduce namespace tools::dns_utils; support integrated address with dns lookup
2016-12-21 23:12:15 +09:00
Riccardo Spagni
9777de1890
Merge pull request #1474
...
fc40b3e7
Lower connection timeout in check_connection() (Jaquee)
2016-12-20 17:47:58 +02:00
Riccardo Spagni
e170cbe013
Merge pull request #1473
...
e3639f5c
Removed unused functions (Lee Clagett)
2016-12-20 17:47:16 +02:00
Riccardo Spagni
6847999fb8
Merge pull request #1472
...
2bddb8eb
Refactored password prompting for wallets (Lee Clagett)
2016-12-20 17:46:58 +02:00
Riccardo Spagni
233ba51ad9
Merge pull request #1468
...
9a2cd722
wallet2_api: add an API to the OpenAlias resolver (moneromooo-monero)
2016-12-20 17:45:13 +02:00
Riccardo Spagni
b9b9028e50
Merge pull request #1462
...
07b9138c
support importing unportable outputs (kenshi84)
2ac80075
also use portable serializer for boost_serialization_helper.h and net_node.inl, completely adandon boost/archive/binary_oarchive.hpp (kenshi84)
d1d6e27a
moved boost cpp into hpp since they're supposed to be header only (kenshi84)
66e6af89
added experimental boost::archive::portable_binary_{i|o}archive (kenshi84)
2016-12-20 17:40:11 +02:00
kenshi84
2ac8007544
also use portable serializer for boost_serialization_helper.h and net_node.inl, completely adandon boost/archive/binary_oarchive.hpp
2016-12-20 13:04:19 +09:00
kenshi84
d1d6e27ab6
moved boost cpp into hpp since they're supposed to be header only
2016-12-20 12:27:23 +09:00
Lee Clagett
2bddb8ebee
Refactored password prompting for wallets
2016-12-19 20:00:43 -05:00
Jaquee
fc40b3e732
Lower connection timeout in check_connection()
2016-12-19 21:19:02 +01:00
Lee Clagett
e3639f5cc3
Removed unused functions
2016-12-19 14:47:26 -05:00
moneromooo-monero
9a2cd72257
wallet2_api: add an API to the OpenAlias resolver
2016-12-17 13:05:17 +00:00
Lee Clagett
427054c3d5
Enabled HTTP auth support for monero-wallet-rpc
2016-12-16 23:59:46 -05:00
kenshi84
66e6af89ce
added experimental boost::archive::portable_binary_{i|o}archive
2016-12-16 23:46:24 +09:00
Riccardo Spagni
73e50749e2
Merge pull request #1455
...
4bb0bff2
AddressBook: use unsigned type for row ID's (anonimal)
2016-12-15 14:35:47 +02:00
Riccardo Spagni
00898fe750
Merge pull request #1452
...
944b6079
Wallet API: Do not refresh while daemon is syncing + fixed fast refresh when creating wallet offline + improved close wallet logic (make sure refresh thread is stopped) (Jaquee)
2016-12-15 14:28:15 +02:00
Riccardo Spagni
aa47ea41a7
Merge pull request #1444
...
bdc3d749
Adding HTTP Digest Auth (but not yet enabled) (Lee Clagett)
2016-12-15 14:25:49 +02:00
Jaquee
944b6079d9
Wallet API: Do not refresh while daemon is syncing
...
+ fixed fast refresh when creating wallet offline
+ improved close wallet logic (make sure refresh thread is stopped)
2016-12-15 12:31:09 +01:00
anonimal
4bb0bff233
AddressBook: use unsigned type for row ID's
...
Fixes build warnings and may also prevent future headaches.
2016-12-14 21:37:49 +00:00
Riccardo Spagni
183d3657f3
Merge pull request #1446
...
b2adfa8c
Bitmonero namespace renamed Monero. Bitmonero namespace alias added so that third party uses of the wallet api can transition. (Randi Joseph)
2016-12-13 19:13:09 +02:00
Randi Joseph
b2adfa8c51
Bitmonero namespace renamed Monero. Bitmonero namespace alias added so that third party uses of the wallet api can transition.
2016-12-13 10:21:38 -05:00
Lee Clagett
bdc3d7496f
Adding HTTP Digest Auth (but not yet enabled)
2016-12-13 00:19:54 -05:00
luigi1111
0fb5dc870d
monero-wallet-cli wording changes 'n' stuff
...
Possibly other pedantry. Pedants are people too.
2016-12-12 19:53:28 -06:00
Jaquee
3b4539ee7e
addressbook updates
2016-12-12 21:50:50 +01:00
Riccardo Spagni
aa7a926681
Merge pull request #1434
...
5df92877
GUI address book (Jaquee)
2016-12-12 22:39:38 +02:00
Jaquee
5df92877c7
GUI address book
2016-12-12 00:43:02 +01:00
moneromooo-monero
c5c45ca660
wallet: bring forward use of the dynamic fee
...
It was 14 days after v4, it is now one day after it.
luigi1111's suggestion
2016-12-10 15:39:26 +00:00
Riccardo Spagni
2d0fbaf35b
Merge pull request #1422
...
9b00d80f
wallet2: pass by const ref where possible (moneromooo-monero)
2016-12-10 14:49:34 +02:00
Riccardo Spagni
930aceb242
Merge pull request #1419
...
f4a3ce15
Fix sending outputs from a tx with more than one pubkey (moneromooo-monero)
2016-12-10 14:48:56 +02:00
moneromooo-monero
9b00d80f85
wallet2: pass by const ref where possible
...
Reported by kenshi84
2016-12-10 11:43:44 +00:00
moneromooo-monero
f4a3ce15c1
Fix sending outputs from a tx with more than one pubkey
...
A bug in cold signing caused a spurious pubkey to be included
in transactions, so we need to ensure we use the correct one
when sending outputs from one of those.
2016-12-09 18:21:21 +00:00
Riccardo Spagni
8e1a8c6adc
Merge pull request #1415
...
6c44f5c6
wallet: send 0 change to a random address where necessary with rct (moneromooo-monero)
2016-12-08 23:44:40 +02:00
Riccardo Spagni
f9503d2789
Merge pull request #1405
...
d1a75754
Remove infinite loop in refresh code (Jaquee)
2016-12-08 23:43:19 +02:00
moneromooo-monero
6c44f5c6eb
wallet: send 0 change to a random address where necessary with rct
...
If a rct transaction would cause no change to be generated, a zero
change output is added, and sent to a randomly generated address.
This ensures that no transaction will be sent with just one output,
which could cause the receiver to be able to determine which of the
inputs in the sent rings is the real one.
This is very rare, since it requires the sum of outputs to be equal
to the sum of outputs plus the fee, which is now a function of the
last few blocks.
2016-12-07 21:05:50 +00:00
Lee Clagett
18462aa065
Added confirmation before binding wallet-rpc to external IP
2016-12-05 21:45:11 -05:00
Jaquee
d1a75754df
Remove infinite loop in refresh code
...
This reverts commit fd181b03bb
.
2016-12-05 13:02:45 +01:00
Riccardo Spagni
b500a64524
Merge pull request #1399
...
73ac3b8e
wallet2: avoid possible undefined behavior on empty string (moneromooo-monero)
2016-12-04 22:28:48 +02:00
Riccardo Spagni
f2ea2afb77
Merge pull request #1398
...
f4772bae
Fix a few minor typos (Pierre Boyer)
2016-12-04 22:28:22 +02:00
Riccardo Spagni
977dd9b76c
Merge pull request #1385
...
5783dd8c
tests: add unit tests for uri parsing (moneromooo-monero)
82ba2108
wallet: add API and RPC to create/parse monero: URIs (moneromooo-monero)
d9001b43
epee: add functions to convert from URL format (ie, %XX values) (moneromooo-monero)
2016-12-04 22:19:06 +02:00
Riccardo Spagni
836c748366
Merge pull request #1388
...
fcd178ef
wallet_api: add a few daemon related getters (moneromooo-monero)
2016-12-04 22:17:48 +02:00
Riccardo Spagni
3d533d1037
Merge pull request #1380
...
657a70e0
wallet: add a getter for the filename path (moneromooo-monero)
2016-12-04 22:02:40 +02:00
moneromooo-monero
73ac3b8e26
wallet2: avoid possible undefined behavior on empty string
2016-12-04 14:56:06 +00:00
Pierre Boyer
f4772bae81
Fix a few minor typos
2016-12-04 14:13:54 +01:00
moneromooo-monero
fcd178ef33
wallet_api: add a few daemon related getters
...
Blockchain height, version, Mining hash rate...
2016-11-29 10:54:38 +00:00
moneromooo-monero
82ba2108e9
wallet: add API and RPC to create/parse monero: URIs
2016-11-28 17:54:22 +00:00
moneromooo-monero
657a70e004
wallet: add a getter for the filename path
2016-11-26 14:19:57 +00:00
moneromooo-monero
d6086f5b4e
Improve daemon RPC version handling
...
Daemon RPC version is now composed of a major and minor number,
so that incompatible changes bump the major version, while
compatible changes can still bump the minor version without
causing clients to unnecessarily complain.
2016-11-26 12:56:44 +00:00
Riccardo Spagni
c36cb54340
Merge pull request #1372
...
17b6bd6
Fix DNS failures in offline mode preventing daemon startup (moneromooo-monero)
2016-11-24 13:01:35 +02:00
Riccardo Spagni
2497a2d547
Merge pull request #1369
...
6d76072
simplewallet: remove double confirmation when submitting signed tx (moneromooo-monero)
92dea04
wallet2: fix wrong change being recorded for cold signed txes (moneromooo-monero)
2016-11-24 13:00:32 +02:00
Riccardo Spagni
3fa1b6623a
Merge pull request #1361
...
1d9e223
rpc: do not include output indices for pool txes (moneromooo-monero)
e227d6e
rpc: bump version after RPC changes (moneromooo-monero)
2c0173c
Add a get_outs (fully text based) version of get_outs.bin (moneromooo-monero)
e05907b
rpc: add output indices to gettransactions (moneromooo-monero)
2016-11-24 12:57:00 +02:00
Riccardo Spagni
a26b27f66e
Merge pull request #1358
...
7abfc54
wallet: fix exporting outputs and key images with txes with two pubkeys (moneromooo-monero)
2016-11-24 12:55:14 +02:00
Riccardo Spagni
25369df4d8
Merge pull request #1357
...
5fc36f9
wallet2_api: fix history leak on destruction (moneromooo-monero)
2016-11-24 12:54:25 +02:00
Riccardo Spagni
f801dc8567
Merge pull request #1356
...
69b188c
wallet2_api: fix payment ids from integrated addresses being ignored (moneromooo-monero)
2016-11-24 12:53:59 +02:00
Riccardo Spagni
570acdc686
Merge pull request #1352
...
d01f5c7
wallet2: fix illegal memory access removing newlines from password (moneromooo-monero)
2016-11-24 12:53:14 +02:00
Riccardo Spagni
2121f3b2f0
Merge pull request #1351
...
e6264a2
wallet2: fix decrypting a bit too much in authenticated mode (moneromooo-monero)
2016-11-24 12:52:54 +02:00
moneromooo-monero
17b6bd6d35
Fix DNS failures in offline mode preventing daemon startup
2016-11-23 23:14:49 +00:00
moneromooo-monero
92dea04929
wallet2: fix wrong change being recorded for cold signed txes
2016-11-23 20:27:22 +00:00
moneromooo-monero
2c0173c722
Add a get_outs (fully text based) version of get_outs.bin
2016-11-22 20:00:40 +00:00
moneromooo-monero
7abfc5474c
wallet: fix exporting outputs and key images with txes with two pubkeys
...
This also needs to make sure to pick the correct one, in the case
where cold signing caused to tx keys to be included.
2016-11-19 09:36:40 +00:00
moneromooo-monero
5fc36f981c
wallet2_api: fix history leak on destruction
2016-11-18 21:42:08 +00:00
moneromooo-monero
69b188c4b2
wallet2_api: fix payment ids from integrated addresses being ignored
2016-11-18 19:13:43 +00:00
Dion Ahmetaj
fd181b03bb
Clamp refresh from height to blockchain height.
2016-11-18 13:40:55 -05:00
moneromooo-monero
d01f5c7f1f
wallet2: fix illegal memory access removing newlines from password
2016-11-17 20:43:58 +00:00
moneromooo-monero
e6264a2c35
wallet2: fix decrypting a bit too much in authenticated mode
2016-11-17 20:31:00 +00:00
Riccardo Spagni
dbf2ab56c5
Merge pull request #1346
...
4eb7347
wallet: return fee in transfer RPC (moneromooo-monero)
2016-11-17 16:40:37 +02:00
Riccardo Spagni
5df6f0be80
Merge pull request #1318
...
4fca34d
Wallet2: calculate approximate blockchain height on offline creation (Jacob Brydolf)
2016-11-17 16:37:30 +02:00
moneromooo-monero
4eb7347fdd
wallet: return fee in transfer RPC
2016-11-16 18:56:45 +00:00
moneromooo-monero
a0131c8be3
wallet: auto sync outputs and key images in cold signing files
...
When passing around unsigned and signed transactions, outputs
and key images are passed along (outputs are passed along unsigned
transactions from the hot wallet to the cold wallet, key images
are passed along with signed transations from the cold wallet
to the hot wallet), to allow more user friendly syncing between
hot and cold wallets.
2016-11-16 09:22:24 +00:00
moneromooo-monero
f8066116dd
wallet2: fill key image and pubkey maps when importing outputs
2016-11-16 09:22:18 +00:00
moneromooo-monero
5fe363cd22
wallet: cast indices to string in logs to be nice to CLANG
2016-11-16 09:22:13 +00:00
moneromooo-monero
11ae1873f8
wallet2: try all tx keys when scanning a new transaction
...
The vast majority of transactions will have just one tx pubkey,
but a bug with cold wallet signing caused two such keys to be
there, with the second one being the real one.
2016-11-16 09:22:05 +00:00
moneromooo-monero
072d646a45
wallet2: fill in key image map when importing key images
2016-11-15 21:20:08 +00:00
moneromooo-monero
a99ab49dd5
wallet: fix serialization of new m_key_image_known member
2016-11-13 16:38:29 +00:00
Jacob Brydolf
4fca34ddb4
Wallet2: calculate approximate blockchain height on offline creation
...
Wallet API: add approximateBlockChainHeight()
2016-11-13 03:36:44 +01:00
iDunk5400
e1dd15b050
Don't build monero-wallet-rpc when building the GUI
2016-11-12 19:22:19 +01:00
moneromooo-monero
70d4915980
wallet: add version dependency to the wallet target
2016-11-12 12:55:19 +00:00
Riccardo Spagni
6a2bb62827
Merge pull request #1316
...
358e068
Created monero-wallet-rpc, moving functionality from monero-wallet-cli (Lee Clagett)
2016-11-11 12:48:39 +02:00
Riccardo Spagni
a3cd7230f8
Merge pull request #1315
...
9150a16
Wallet API: use stored refresh height when rebuilding cache (Jacob Brydolf)
2016-11-11 12:35:47 +02:00
Riccardo Spagni
3fd13080b7
Merge pull request #1314
...
63772e4
wallet: fix corner case of no recent outputs available (moneromooo-monero)
2016-11-11 12:35:25 +02:00
Lee Clagett
358e068e87
Created monero-wallet-rpc, moving functionality from monero-wallet-cli
2016-11-10 16:39:27 -05:00
moneromooo-monero
1669621937
wallet2_api: support for sweeping all
2016-11-09 19:32:37 +00:00
Jacob Brydolf
9150a16ed1
Wallet API: use stored refresh height when rebuilding cache
2016-11-09 18:46:03 +01:00
moneromooo-monero
63772e4048
wallet: fix corner case of no recent outputs available
...
Also clarify related logs
2016-11-09 14:01:54 +00:00
Riccardo Spagni
dc5e0e45cd
Merge pull request #1310
...
40a68e2
wallet2_api: add API for create_unmixable_sweep_transactions (moneromooo-monero)
2016-11-09 14:11:57 +02:00
Riccardo Spagni
56c594a8fe
Merge pull request #1309
...
c441a61
wallet2_api: API to sign and verify a message (moneromooo-monero)
2016-11-09 14:10:39 +02:00
Riccardo Spagni
06ca304b06
Merge pull request #1307
...
4dcb74f
wallet_api: PendingTransaction::txCount - number of split transactions (Ilya Kitaev)
2016-11-09 14:10:12 +02:00
Riccardo Spagni
144a7f090a
Merge pull request #1305
...
c80f4d4
wallet: fix output collision detection for view wallets (moneromooo-monero)
2016-11-09 14:08:34 +02:00
moneromooo-monero
c441a61ef6
wallet2_api: API to sign and verify a message
2016-11-08 21:21:08 +00:00
Ilya Kitaev
4dcb74f97f
wallet_api: PendingTransaction::txCount - number of split transactions
2016-11-09 00:13:18 +03:00
Riccardo Spagni
e8a55db29d
Merge pull request #1308
...
0c530de
Wallet API: Pause refresh while creating transaction (Jacob Brydolf)
2016-11-08 22:57:04 +02:00
Riccardo Spagni
18fdd8116e
Merge pull request #1306
...
8aba0d4
wallet: encrypt outputs and key images files with the view key (moneromooo-monero)
2016-11-08 22:55:56 +02:00
Riccardo Spagni
7c7a6cf2f8
Merge pull request #1302
...
63fe6fd
wallet2_api: allow connection to return "yes, but wrong version" (moneromooo-monero)
2016-11-08 22:53:13 +02:00
Riccardo Spagni
96e0138ebf
Merge pull request #1301
...
35da3cb
Wallet API: added getTxKey() (Jacob Brydolf)
2016-11-08 22:50:13 +02:00
Jacob Brydolf
35da3cb074
Wallet API: added getTxKey()
2016-11-08 21:48:26 +01:00
Riccardo Spagni
c57ce06a97
Merge pull request #1300
...
eb19492
wallet2_api: do not copy the whole pending tx when iterating (moneromooo-monero)
2016-11-08 22:48:04 +02:00
Riccardo Spagni
af2ceb29fa
Merge pull request #1298
...
97288a5
wallet2_api: add API for tx notes (moneromooo-monero)
2016-11-08 22:45:54 +02:00
Riccardo Spagni
c05cecf036
Merge pull request #1297
...
af8a260
wallet_api: txkey checking functions for the GUI (moneromooo.monero)
2016-11-08 22:44:15 +02:00
Riccardo Spagni
4c44d896d3
Merge pull request #1285
...
a970a4e
refresh speedup (luigi1111)
2016-11-08 22:34:26 +02:00
Riccardo Spagni
0fa6cbef3f
Merge pull request #1276
...
18f66f4
wallet: use the dynamic per kB fee (moneromooo-monero)
e6deb8a
rpc: add a dynamic fee estimation RPC call (moneromooo-monero)
82dbba1
core: dynamic fee algorithm from ArticMine (moneromooo-monero)
2016-11-08 22:33:13 +02:00
moneromooo-monero
40a68e22fa
wallet2_api: add API for create_unmixable_sweep_transactions
2016-11-08 20:03:07 +00:00
Jacob Brydolf
0c530de057
Wallet API: Pause refresh while creating transaction
2016-11-08 13:20:42 +01:00
moneromooo-monero
8aba0d4b4c
wallet: encrypt outputs and key images files with the view key
...
This key is available to both cold and hot wallet.
Authenticated encryption will guard against interception and/or
modification of the file.
2016-11-07 20:01:05 +00:00
moneromooo-monero
c80f4d416d
wallet: fix output collision detection for view wallets
...
View wallets do not have the spend secret key, and are thus
unable to derive key images for incoming outputs. Moreover,
a previous patch set key images to zero as a means to mark
an output as having an unknown key image, so they could be
filled in when importing key images at a later time. That
later patch caused spurious collisions. We now use public
keys to detect duplicate outputs. Public keys obtained from
the blockchain are checked to be identical to the ones
derived locally, so can't be spoofed.
2016-11-07 18:59:30 +00:00
moneromooo-monero
63fe6fd9ba
wallet2_api: allow connection to return "yes, but wrong version"
2016-11-07 12:00:29 +00:00
moneromooo-monero
eb194925ec
wallet2_api: do not copy the whole pending tx when iterating
2016-11-06 10:36:08 +00:00
moneromooo-monero
97288a5ce2
wallet2_api: add API for tx notes
2016-11-05 21:19:08 +00:00
moneromooo.monero
af8a2600aa
wallet_api: txkey checking functions for the GUI
2016-11-05 15:24:05 +00:00
moneromooo-monero
b5d6faada3
wallet: fix bad amounts/fees again
...
m_amount_out was sometimes getting initialized with the sum of
an transaction's outputs, and sometimes with the sum of outputs
that were not change. This caused confusion and bugs. We now
always set it to the sum of outputs. This reverts an earlier
fix for bad amounts as this used the other semantics. The wallet
data should be converted automatically in a percentage of cases
that I'm hesitant to estimate. In any case, restoring from seed
or keys or rebuilding the cache will get it right.
2016-11-02 23:11:30 +00:00
luigi1111
a970a4e3cf
refresh speedup
...
Compute derivation only once per tx, instead of once per output. Approx 33% faster while using 75% as much CPU on my machine. Note old functions in cryptonote_core (lookup_acc_outs and is_out_to_acc) are still used by tests.
2016-11-01 11:24:04 -05:00
Riccardo Spagni
b06c1abaa6
Merge pull request #1278
...
43ec2d0
Wallet API: added walletExists logic (Jacob Brydolf)
2016-11-01 15:29:44 +02:00
Riccardo Spagni
6f85b20d92
Merge pull request #1283
...
4869db7
adding static_assert to pod functions in string tools (Lee Clagett)
2016-11-01 15:13:10 +02:00
Riccardo Spagni
d53bc2eddf
Merge pull request #1281
...
bb560dd
wallet: new import_outputs/export_outputs commands (moneromooo-monero)
2016-11-01 15:12:03 +02:00
Lee Clagett
4869db702a
adding static_assert to pod functions in string tools
2016-10-31 13:22:21 -04:00
moneromooo-monero
18f66f44ef
wallet: use the dynamic per kB fee
2016-10-31 08:38:06 +00:00
moneromooo-monero
bb560dd814
wallet: new import_outputs/export_outputs commands
...
The intended use is to export outputs from a hot wallet, which
can scan incoming transfers from the network, and import them
in the cold wallet, which can't. The cold wallet can then compute
key images for those outputs, which can then be exported with
export_key_images, etc.
2016-10-30 19:37:09 +00:00
Jacob Brydolf
43ec2d002a
Wallet API: added walletExists logic
2016-10-30 15:34:50 +01:00
moneromooo-monero
7e6d3cf441
wallet: set incoming outputs' key image to 0 on view wallets
...
This allows rescan_spent to know the daemon response to those
is not valid.
2016-10-30 12:14:33 +00:00
moneromooo-monero
1f9e6a46d8
wallet: print tx overview on submit_transfer too
...
This is on the potentially compromised wallet, but still guards
against stupid mistakes.
2016-10-30 10:49:22 +00:00
Riccardo Spagni
83b0511731
Merge pull request #1270
...
fdef09f
Wallet API: make sure path exists before searching for wallets (Jacob Brydolf)
2016-10-29 11:35:48 +02:00
Jacob Brydolf
fdef09f11c
Wallet API: make sure path exists before searching for wallets
2016-10-28 22:29:33 +02:00
moneromooo-monero
069d688cf7
simplewallet: log transactions to submit in submit_transfer
...
Not as trustworthy as this is in the view wallet, the one
that's considered compromised.
2016-10-26 13:17:29 +01:00
moneromooo-monero
31abac4daf
wallet: fix pre-rct cold wallet signing not splitting change
...
Re-creating the transaction on the cold wallet was not splitting
the change, causing the transaction to be rejected by the network.
This worked on testnet since amounts do not have to be split.
Also add selected_transfers, which can now be saved since they're
size_t rather than iterators. This allows the view wallet to
properly set the sent outputs as spent and update balance.
Bump transfer file version numbers to match.
2016-10-25 21:44:31 +01:00
Riccardo Spagni
4e98d2958c
Merge pull request #1246
...
372f338
wallet: sanity check on selected transfer indices in signed ptx (moneromooo-monero)
2016-10-23 19:09:18 +02:00
Riccardo Spagni
92095104fe
Merge pull request #1230
...
06b642d
wallet_api: add address validation functions (moneromooo-monero)
2016-10-23 19:04:01 +02:00
Riccardo Spagni
4f6ea2eb6a
Merge pull request #1229
...
b6b86ab
wallet2_api: recognize full size payment ids as valid (moneromooo-monero)
2016-10-22 22:19:43 +02:00
Riccardo Spagni
b3d4505ae1
Merge pull request #1228
...
2bf65df
wallet_api: do not override invalid payment id (moneromooo-monero)
2016-10-22 22:18:36 +02:00
Riccardo Spagni
09f62ed33e
Merge pull request #1225
...
04da979
Always confirm transfers defaults to ON/YES (NanoAkron)
2016-10-22 22:16:39 +02:00
Riccardo Spagni
f800390ccc
Merge pull request #1224
...
8231997
simplewallet: fix sweep_all misreporting sweeped amount for rct outputs (moneromooo-monero)
985f61a
wallet: force 0 mixin transactions to use pre-rct txes (moneromooo-monero)
2016-10-22 22:15:50 +02:00
Riccardo Spagni
7c5431624e
Merge pull request #1223
...
0950be9
wallet: speed up output selection, and fix bug with relatedness calculation (moneromooo-monero)
0eba133
wallet: fix mixup between mixin 2 and 4 before/after v5 (moneromooo-monero)
2016-10-22 22:15:16 +02:00
Riccardo Spagni
9feb358e46
Merge pull request #1220
...
e76dcdd
wallet: improve error messages when not enough money for transfer (moneromooo-monero)
2016-10-22 22:12:17 +02:00
Riccardo Spagni
e48ef1684c
Merge pull request #1219
...
2d7083c
wallet_api: fix wrong amount in tx history (moneromooo-monero)
b5f2001
simplewallet: fix wrong amount in show_transfers (moneromooo-monero)
2016-10-22 22:11:12 +02:00
Riccardo Spagni
b53c9e5549
Merge pull request #1200
...
a3748f4
Rewrote add_wallet_create_if_needed for clearer flow and behaviour (NanoAkron)
2016-10-22 22:07:38 +02:00
moneromooo-monero
372f338682
wallet: sanity check on selected transfer indices in signed ptx
2016-10-22 18:07:26 +01:00
moneromooo-monero
06b642dfe4
wallet_api: add address validation functions
...
The payment id from integrated addresses is also parsed
2016-10-16 16:52:45 +01:00
moneromooo-monero
b6b86ab347
wallet2_api: recognize full size payment ids as valid
2016-10-16 13:54:53 +01:00
moneromooo-monero
2bf65dfb8d
wallet_api: do not override invalid payment id
...
Instead, return an empty string to mark the error
2016-10-16 13:17:29 +01:00
NanoAkron
a3748f40ea
Rewrote add_wallet_create_if_needed for clearer flow and behaviour
2016-10-15 22:29:28 +01:00
NanoAkron
04da979f46
Always confirm transfers defaults to ON/YES
2016-10-15 20:38:07 +01:00
moneromooo-monero
8231997b66
simplewallet: fix sweep_all misreporting sweeped amount for rct outputs
...
RingCT outputs will be 0 in the vin, so we need to get the actual
amount from elsewhere.
2016-10-15 19:18:52 +01:00
moneromooo-monero
985f61a4ec
wallet: force 0 mixin transactions to use pre-rct txes
...
rct transactions does not support 0 mixin, and those are
now typically dust sweep transactions, for which a lower
fee is a must.
2016-10-15 18:42:04 +01:00
moneromooo-monero
88faec75fe
wallet: select part of the fake outs from recent outputs
...
25% of the outputs are selected from the last 5 days (if possible),
in order to avoid the common case of sending recently received
outputs again. 25% and 5 days are subject to review later, since
it's just a wallet level change.
2016-10-15 18:17:16 +01:00
moneromooo-monero
0950be9e34
wallet: speed up output selection, and fix bug with relatedness calculation
2016-10-15 16:32:08 +01:00
moneromooo-monero
0eba1335be
wallet: fix mixup between mixin 2 and 4 before/after v5
2016-10-15 16:07:18 +01:00
moneromooo-monero
e76dcdd810
wallet: improve error messages when not enough money for transfer
2016-10-15 14:31:40 +01:00
moneromooo-monero
2d7083ca56
wallet_api: fix wrong amount in tx history
2016-10-15 13:56:25 +01:00
Jacob Brydolf
a8cd65646c
Wallet API: added setRecoveringFromSeed();
2016-10-10 19:37:10 +02:00
Riccardo Spagni
0673db16ad
Merge pull request #1195
...
697ce1d
libwallet_api: reverted deleted curly brace (Ilya Kitaev)
bb9094f
libwallet_api: fixes for transaction history (Ilya Kitaev)
62b3708
libwallet_api: do not signal on sent/received tx until wallet completely synchronized (Ilya Kitaev)
11fab41
libwallet_api: TransactionHistory: read/write syncchronization (Ilya Kitaev)
559f379
libwallet_api: test: adjusted mixin_count=4 as it's minumum allowed (Ilya Kitaev)
8b0cb8c
libwallet_api: some renamings (Ilya Kitaev)
db3282c
Initialize transaction history if empty (Ilya Kitaev)
85f5e73
libwallet_api: fixes for transaction history (Ilya Kitaev)
2016-10-09 14:34:59 +02:00
Riccardo Spagni
8cd01bc378
Merge pull request #1192
...
36a89ab
libwallet_api: Added option to restore from specific height (Jacob Brydolf)
2016-10-09 14:33:17 +02:00
Riccardo Spagni
0589209eb4
Merge pull request #1191
...
9f31e2d
wallet: do not announce pool txes as money spent/received (yet) (moneromooo-monero)
2016-10-09 14:29:16 +02:00
Jacob Brydolf
36a89ab435
libwallet_api: Added option to restore from specific height
2016-10-08 00:57:09 +02:00
moneromooo-monero
9f31e2d8c0
wallet: do not announce pool txes as money spent/received (yet)
2016-10-07 19:52:05 +01:00
Ilya Kitaev
697ce1d435
libwallet_api: reverted deleted curly brace
2016-10-07 00:43:45 +03:00
Ilya Kitaev
a4390dae07
resolved conflict with 'develop' of https://github.com/mbg033/monero
2016-10-07 00:36:36 +03:00
Ilya Kitaev
62b3708ea5
libwallet_api: do not signal on sent/received tx until wallet completely
...
synchronized
2016-10-07 00:29:13 +03:00
Ilya Kitaev
11fab41c36
libwallet_api: TransactionHistory: read/write syncchronization
2016-10-06 23:25:43 +03:00
Ilya Kitaev
8b0cb8caa4
libwallet_api: some renamings
2016-10-06 15:47:29 +03:00
Ilya Kitaev
db3282cdf0
Initialize transaction history if empty
2016-10-06 15:47:29 +03:00
Ilya Kitaev
85f5e73d9c
libwallet_api: fixes for transaction history
2016-10-06 15:47:29 +03:00
Ilya Kitaev
bb9094f1fe
libwallet_api: fixes for transaction history
2016-10-04 23:11:19 +03:00
moneromooo-monero
4e6d70808d
wallet: better implementation of sweep_unmixable
...
This was still using the old transaction creation algorithm,
coupled with a deterministic output selection scheme, which
made it ill suited to the job, since it'd loop indefinitely
in case the fee increased between the test tx and adding the
fee.
2016-10-04 17:44:56 +01:00
Riccardo Spagni
2723cd12e1
Merge pull request #1173
...
65ea836
wallet2_api: added Wallet::daemonBlockChainTargetHeight() libwallet_api: Wallet::blockChainTargetHeight (Jacob Brydolf)
2016-10-04 12:15:02 +02:00
Riccardo Spagni
bfdac4b5ff
Merge pull request #1160
...
80b4da3
wallet: wallet option to confirm transfers with no payment id (moneromooo-monero)
2016-10-04 12:11:32 +02:00
Riccardo Spagni
4cb1348548
Merge pull request #1139
...
01ec195
Update CMakeLists.txt (codehalo)
446ebbc
Update CMakeLists.txt (codehalo)
bd773e7
Update CMakeLists.txt (codehalo)
3627cea
Cleanup. Dropped "bit" from bitmonero. (Randi Joseph)
2a51396
Dropped "bit" from bitmonero. (Randi Joseph)
78b13d6
Cleanup. Dropped "bit" from bitmonero. (Randi Joseph)
1e6aedb
Cleanup. Dropped "bit" from bitmonero. (Randi Joseph)
9e54616
Dropped "bit" from bitmonero. (Randi Joseph)
2016-10-04 12:11:03 +02:00
Riccardo Spagni
60e527f1c2
Merge pull request #1125
...
7b09e9f
wallet: update min mixin for sweep_unmixable on v4 (moneromooo-monero)
2016-10-04 12:06:04 +02:00
Riccardo Spagni
db90a16f03
Merge pull request #1152
...
8b20cbf
libwallet_api: do not use fast-refresh on recovery (Ilya Kitaev)
10fe626
libwallet_api: fast-refresh in case of opening non-synced wallet (Ilya Kitaev)
0019e31
libwallet_api: fix unhandled exception on address check (Ilya Kitaev)
1f73f80
libwallet_api: fast-refresh for new wallet (Ilya Kitaev)
4789347
libwallet_api: test for create/init wallet on mainnet (Ilya Kitaev)
2016-10-04 11:37:18 +02:00
Riccardo Spagni
2ef81914b5
Merge pull request #1140
...
bba6af9
wallet: cold wallet transaction signing (moneromooo-monero)
9872dcb
wallet: fix log confusion between bytes and kilobytes (moneromooo-monero)
d9b0bf9
cryptonote_core: make extra field removal more generic (moneromooo-monero)
98f19d4
serialization: add support for serializing std::pair and std::list (moneromooo-monero)
2016-10-04 11:27:38 +02:00
Jacob Brydolf
65ea8364f8
wallet2_api: added Wallet::daemonBlockChainTargetHeight()
...
libwallet_api: Wallet::blockChainTargetHeight
Signed-off-by: Jacob Brydolf <jacob@brydolf.net>
2016-10-03 20:47:41 +02:00
Ilya Kitaev
8b20cbfa7d
libwallet_api: do not use fast-refresh on recovery
2016-10-01 21:04:49 +03:00
moneromooo-monero
80b4da3330
wallet: wallet option to confirm transfers with no payment id
...
set confirm-missing-payment-id 0|1
Defaults to true.
2016-10-01 17:03:53 +01:00
Ilya Kitaev
10fe626e13
libwallet_api: fast-refresh in case of opening non-synced wallet
2016-09-30 22:42:15 +03:00
Ilya Kitaev
0019e3106b
libwallet_api: fix unhandled exception on address check
2016-09-30 21:43:57 +03:00
Ilya Kitaev
1f73f80c94
libwallet_api: fast-refresh for new wallet
2016-09-30 02:11:28 +03:00
Ilya Kitaev
2dacb193d0
wallet2: wallet2::get_daemon_blockchain_height() clean error message on
...
success
2016-09-28 00:39:06 +03:00
Ilya Kitaev
25e5efc238
libwallet_api: Wallet::setAutoRefreshInterval sanity check
2016-09-28 00:35:10 +03:00
Ilya Kitaev
a6688200fb
libwallet_api: explicitly return 0 in Wallet::daemonBlockChainHeight()
...
on error
2016-09-28 00:31:21 +03:00
moneromooo-monero
bba6af9064
wallet: cold wallet transaction signing
...
This change adds the ability to create a new unsigned transaction
from a watch only wallet, and save it to a file. This file can
then be moved to another computer/VM where a cold wallet may load
it, sign it, and save it. That cold wallet does not need to have
a blockchain nor daemon. The signed transaction file can then be
moved back to the watch only wallet, which can load it and send
it to the daemon.
Two new simplewallet commands to use it:
sign_transfer (on the cold wallet)
submit_transfer (on the watch only wallet)
The transfer command used on a watch only wallet now writes an
unsigned transaction set in a file called 'unsigned_monero_tx'
instead of submitting the tx to the daemon as a normal wallet does.
The signed tx file is called 'signed_monero_tx'.
2016-09-27 07:46:39 +01:00
moneromooo-monero
9872dcbbe3
wallet: fix log confusion between bytes and kilobytes
2016-09-26 23:12:43 +01:00
Randi Joseph
9e54616924
Dropped "bit" from bitmonero.
2016-09-26 17:22:30 -04:00
Ilya Kitaev
cda4cb969a
formatting: 2-spaces indentation
2016-09-26 23:46:07 +03:00
Ilya Kitaev
545a48f098
formatting: 2-spaces indentation
2016-09-26 23:29:53 +03:00
Ilya Kitaev
3079c5756b
wallet2_api: milliseconds resolution for auto-refresh interval
2016-09-26 23:19:25 +03:00
Ilya Kitaev
7b4a85b309
wallet2_api: added Wallet::daemonBlockChainHeight()
2016-09-26 23:19:25 +03:00
Ilya Kitaev
9de3ec3e2a
libwallet_api: Wallet::blockChainHeight, WalletListener::newBlock
2016-09-26 23:19:25 +03:00
moneromooo-monero
7b09e9ff77
wallet: update min mixin for sweep_unmixable on v4
2016-09-24 14:48:34 +01:00
Ilya Kitaev
d5d0856ce6
wallet2_api: getter and setter for "refresh interval"
2016-09-20 20:40:58 +03:00
Ilya Kitaev
cdb6c96f89
wallet2_api: fixed deadlock while closing wallet
2016-09-20 20:08:33 +03:00
moneromooo-monero
eeb2bbc0fc
epee: optionally restrict HTTP service to a configurable user agent
...
This is intended to catch traffic coming from a web browser,
so we avoid issues with a web page sending a transfer RPC to
the wallet. Requiring a particular user agent can act as a
simple password scheme, while we wait for 0MQ and proper
authentication to be merged.
2016-09-18 20:32:02 +01:00
Riccardo Spagni
68e6678ab7
Merge pull request #1099
...
c2faab5
fix v5 height (Riccardo Spagni)
70bd7d8
remove dead backup seed nodes, add new ones (Riccardo Spagni)
cebbcf0
fix v5 fork date description (Riccardo Spagni)
eb60fa2
update version (Riccardo Spagni)
c41098a
updated fork heights for v4 and v5 (Riccardo Spagni)
c69b8a1
update block headers (Riccardo Spagni)
f148af2
add checkpoints (Riccardo Spagni)
c15da0e
switch wallet API from std thread/mutex to boost (Riccardo Spagni)
8a274ea
switch wallet API from std thread/mutex to boost (Riccardo Spagni)
2016-09-18 20:26:39 +02:00
Riccardo Spagni
6b744c349f
Merge pull request #1098
...
1dd5b0b
wallet: keep change dest separate from other dests (moneromooo-monero)
2016-09-18 17:42:32 +02:00
Riccardo Spagni
a6914c140c
Merge pull request #1097
...
5f5d727
wallet: fix empty tx in corner case sending nothing (moneromooo-monero)
2016-09-18 17:42:10 +02:00
Riccardo Spagni
8a274eab3f
switch wallet API from std thread/mutex to boost
2016-09-18 17:37:47 +02:00
moneromooo-monero
1dd5b0b7df
wallet: keep change dest separate from other dests
...
This fixes misreporting of amount/fee in rct txes, as the rct
tx construction code was lumping all dests (whether change or
not) in the same dests vector, while the pre-rct code was
keeping it separate.
2016-09-18 12:04:23 +01:00
moneromooo-monero
5f5d7279b6
wallet: fix empty tx in corner case sending nothing
2016-09-18 10:44:32 +01:00
redfish
e1c7af35d4
cmake: transitive deps and remove deprecated LINK_*
...
Keep the immediate direct deps at the library that depends on them,
declare deps as PUBLIC so that targets that link against that library
get the library's deps as transitive deps.
Break dep cycle between blockchain_db <-> crytonote_core.
No code refactoring, just hide cycle from cmake so that
it doesn't complain (cycles are allowed only between
static libs, not shared libs).
This is in preparation for supproting BUILD_SHARED_LIBS cmake
built-in option for building internal libs as shared.
2016-09-18 02:56:26 -04:00
moneromooo-monero
9c7b0cb28e
wallet: change priority/fee to ArticMine's recommendation
...
We keep 1, 2, 3 multipliers till the fee decrase from 0.01/kB
to 0.002/kB, where we start using 1, 20, 166 multipliers.
This ensures the higher multiplier will compensate for the
block reward penalty when pushing past 100% of the past median.
The fee-multiplier wallet setting is now rename to priority,
since it keeps its [0..3] range, but maps to different multiplier
values.
2016-09-16 11:50:52 +01:00
Riccardo Spagni
7c899ec33a
Merge pull request #1074
...
cd01bae
Decrease minimum fee from 0.01/kB to 0.002/kB (moneromooo-monero)
2016-09-15 15:23:49 +02:00
moneromooo-monero
cd01bae735
Decrease minimum fee from 0.01/kB to 0.002/kB
...
The wallet will start using that fee about two weeks after hard
fork 3, when most people will likely have updated their daemons.
2016-09-15 09:28:33 +01:00
moneromooo-monero
70b78bb2c8
wallet: fix misdetection of duplicates
2016-09-14 20:23:28 +01:00
Riccardo Spagni
aa996e3a60
Merge pull request #1038
...
43677f9
gui/libwallet_merged: libunbound is one more dependency (Ilya Kitaev)
2016-09-03 14:11:26 +02:00
Ilya Kitaev
43677f9d68
gui/libwallet_merged: libunbound is one more dependency
2016-09-03 13:32:06 +03:00
Riccardo Spagni
6c608c352c
Merge pull request #1033
...
4d17949
wallet_merged: ringct added to dependencies (Ilya Kitaev)
2016-09-01 23:00:21 +02:00
Ilya Kitaev
4d17949d4f
wallet_merged: ringct added to dependencies
2016-09-01 23:06:36 +03:00
luigi1111
34bb78956f
Re-add s to rangesigs
...
Whoops.
2016-09-01 13:53:53 -05:00
luigi1111
dbf017a5f7
Fix some rct tx size calculations
...
Some variance is still expected
2016-09-01 13:14:31 -05:00
Riccardo Spagni
27c8713f56
Merge pull request #1027
...
85dc0ce
wallet: sanity check on histogram response (moneromooo-monero)
2016-09-01 11:31:58 +02:00
Riccardo Spagni
e858c4c745
Merge pull request #1016
...
3112e24
wallet: interpret 0 fee multiplier as default for sweep_all too (moneromooo-monero)
2016-09-01 11:28:29 +02:00
Riccardo Spagni
9b579773d7
Merge pull request #1007
...
1de812a
cmake: merge libs via virtual object libraries (redfish)
a7498ad
cmake: comply with the new policy CMP0026 (redfish)
2016-09-01 11:21:38 +02:00
moneromooo-monero
85dc0ce3a5
wallet: sanity check on histogram response
2016-09-01 09:04:45 +01:00
redfish
1de812a92a
cmake: merge libs via virtual object libraries
...
CMake issued a warming about policy CMP0026: access of LOCATION
target property at config time was disallowed. Offending code
was the code that merged static libraries to generate
libwallet_merged.a.
This patch does that same merge task in a much simpler way. And,
since it doesn't violate the policy, the warning went away.
2016-08-30 23:01:48 -04:00
moneromooo-monero
3112e24aa7
wallet: interpret 0 fee multiplier as default for sweep_all too
2016-08-30 13:19:20 +01:00
moneromooo-monero
73b9b4ba34
wallet: fix not finding enough rct fake outputs
...
If picking coinbase outputs, those are locked for a longer time
than other outputs, so we ask for more of those
2016-08-29 20:51:21 +01:00
moneromooo-monero
adca903589
wallet_rpc_server: return payment id in make_integrated_address RPC
...
It is useful, especially when requesting a random one
2016-08-29 12:18:22 +01:00
moneromooo-monero
fbd7c359ee
wallet: fix some "may be used uninitialized" warnings
...
The compiler can't always work out the _found booleans are
set iff the value is initialized.
2016-08-28 21:30:44 +01:00
moneromooo-monero
4a41dd4068
wallet: do not generate 0 change
2016-08-28 21:30:42 +01:00
moneromooo-monero
45349b6f7c
wallet: do not ask for duplicate histograms
2016-08-28 21:30:36 +01:00
moneromooo-monero
b951bc8780
wallet: transfer_selected_rct now also selects fake outs
2016-08-28 21:30:34 +01:00
moneromooo-monero
c3b3260ae5
New "Halfway RingCT" outputs for coinbase transactions
...
When RingCT is enabled, outputs from coinbase transactions
are created as a single output, and stored as RingCT output,
with a fake mask. Their amount is not hidden on the blockchain
itself, but they are then able to be used as fake inputs in
a RingCT ring. Since the output amounts are hidden, their
"dustiness" is not an obstacle anymore to mixing, and this
makes the coinbase transactions a lot smaller, as well as
helping the TXO set to grow more slowly.
Also add a new "Null" type of rct signature, which decreases
the size required when no signatures are to be stored, as
in a coinbase tx.
2016-08-28 21:30:26 +01:00
moneromooo-monero
d4b62a1e29
rct amount key modified as per luigi1111's recommendations
...
This allows the key to be not the same for two outputs sent to
the same address (eg, if you pay yourself, and also get change
back). Also remove the key amounts lists and return parameters
since we don't actually generate random ones, so we don't need
to save them as we can recalculate them when needed if we have
the correct keys.
2016-08-28 21:30:19 +01:00
moneromooo-monero
3ab2ab3e76
rct: change the simple flag to a type
...
for future expansion
2016-08-28 21:30:14 +01:00
moneromooo-monero
a47ceee83b
wallet: do not store signatures in the wallet cache
...
Saves some substantial space.
Also avoid calculating tx hashes we don't need.
2016-08-28 21:30:10 +01:00
moneromooo-monero
2c9d9519f1
wallet2: factor m_spent changes
...
Makes it easier to track what is going on.
2016-08-28 21:30:04 +01:00
moneromooo-monero
1303cda646
wallet: always use new algorithm for RPC transfers
...
This ensures we get rct transactions when appropriate
2016-08-28 21:30:03 +01:00
moneromooo-monero
230fca2d56
wallet: use the prefered rct case only when enough rct outs exist
2016-08-28 21:29:55 +01:00
moneromooo-monero
c27194a444
wallet: do not try to use rct txes a few blocks before the fork
2016-08-28 21:29:53 +01:00
moneromooo-monero
37bdf6ebe3
change fork settings to allow pre-rct txes for one more fork cycle
2016-08-28 21:29:50 +01:00
moneromooo-monero
9b70856ccb
rct: make the amount key derivable by a third party with the tx key
...
Scheme design from luigi1114.
2016-08-28 21:29:46 +01:00
moneromooo-monero
cf33e1a52a
rct: do not serialize public keys in outPk
...
They can be reconstructed from vout
2016-08-28 21:29:43 +01:00