Cypher_Stack/wownero
2
0
Fork 0
mirror of https://git.wownero.com/wownero/wownero.git synced 2024-12-26 16:38:53 +00:00
Code Issues Packages Projects Releases Wiki Activity
10,988 Commits 21 Branches 51 Tags 161 MiB
93db74a91e
Commit Graph

1475 Commits

Author SHA1 Message Date
Kevin Barbour
85db1734e7
Remove unused variables in monero codebase 
There are quite a few variables in the code that are no longer
(or perhaps never were) in use. These were discovered by enabling
compiler warnings for unused variables and cleaning them up.

In most cases where the unused variables were the result
of a function call the call was left but the variable
assignment removed, unless it was obvious that it was
a simple getter with no side effects.
 2021-02-09 08:05:05 +01:00
Lee Clagett
bd129849f0 Remove copies from foreach loops (thanks to Clang) 2021-01-28 23:42:40 -05:00
Lee Clagett
679d05567d Remove payload copy in all outgoing p2p messages 2021-01-19 02:22:32 +00:00
luigi1111
e45619e61e Revert "Merge pull request #7136" 
This reverts commit 63c7ca07fb, reversing
changes made to 2218e23e84.
 2021-04-16 13:52:44 -05:00
Lee Clagett
23aae5571b Remove payload copy in all outgoing p2p messages 2021-01-16 22:53:28 +00:00
moneromooo-monero
1e27f7101e
blockchain: lock access to m_blocks_hash_of_hashes 
it is accessed both when adding and when prevalidating a set
of new hashes from a peer
 2021-01-02 22:19:54 +00:00
moneromooo-monero
0aa541b361
protocol: more sanity checks in new chain block hashes 2020-12-31 23:33:18 +00:00
moneromooo-monero
1eb14af1a3
rpc: limit the number of txes for get_blocks.bin 2020-12-29 04:31:58 +00:00
Alexander Blair
4f401f6fca
Merge pull request #7025 
b10878f10 Change Dandelion++ fluff probability to 20%, and embargo timeout to 39s (Lee Clagett)
 2020-12-01 14:23:49 -08:00
luigi1111
850edfe419
Merge pull request #7021 
d73cb95 Fix timeout checks for forwarded and Dandelion++ stem txes (Lee Clagett)
 2020-11-29 01:59:35 -06:00
luigi1111
36d31ba0be
Merge pull request #7018 
a9cd5d9 cryptonote_core: dandelion - use local height or median height if syncing (xiphon)
 2020-11-29 01:58:13 -06:00
luigi1111
4d298d4f11
Merge pull request #6924 
874487f blockchain: remove some dead code (moneromooo-monero)
 2020-11-29 01:44:26 -06:00
luigi1111
999e797cea
Merge pull request #6922 
a25bc71 Make Blockchain::get_fee_quantization_mask() compile time (SChernykh)
 2020-11-29 01:40:59 -06:00
xiphon
a9cd5d914e cryptonote_core: dandelion - use local height or median height if syncing 2020-11-25 01:27:42 +00:00
Lee Clagett
b10878f108 Change Dandelion++ fluff probability to 20%, and embargo timeout to 39s 
A 20% fluff probability increases the precision of a spy connected to
every node by 10% on average, compared to a network using 0% fluff
probability. The current value (10% fluff) should increase precision by
~5% compared to baseline.

This decreases the expected stem length from 10 to 5. The embargo
timeout was therefore lowered to 39s; the fifth node in a stem is
expected to have a 90% chance of being the first to timeout, which is
the same probability we currently have with an expected stem length of
10 nodes.
 2020-11-17 21:45:37 -05:00
Lee Clagett
d73cb95dfa Fix timeout checks for forwarded and Dandelion++ stem txes 2020-11-15 00:08:10 -05:00
moneromooo-monero
874487fed8
blockchain: remove some dead code 
This is already done
 2020-10-20 16:50:36 +00:00
SChernykh
a25bc71f3f Make Blockchain::get_fee_quantization_mask() compile time 
This also removes potential thread safety bug in that function.
 2020-10-20 14:16:09 +02:00
Nathan Dorfman
f1836ac28a cryptonote_core: Fix missing override warnings 2020-10-19 18:23:07 -06:00
Alexander Blair
8e3f46dd0a
Merge pull request #6881 
11b20229c tx_pool: silence spammy harmless warning till we fix the bug (moneromooo-monero)
 2020-10-18 23:25:54 -07:00
Alexander Blair
543d600042
Merge pull request #6875 
a12a8174e Dandelion++: skip desynced peers in stem phase (xiphon)
 2020-10-18 23:25:08 -07:00
moneromooo-monero
88fde0309a
blockchain: fix sync at v14 boundary 
Miners with MLSAG txes which they'd already verified included
a couple in that block, but the consensus rules had changed
in the meantime, so that block is technically invalid and any
node which did not already have those two txes in their txpool
could not sync. Grandfather them in, since it has no effect in
practice.
 2020-10-18 11:52:33 +00:00
moneromooo-monero
11b20229c9
tx_pool: silence spammy harmless warning till we fix the bug 2020-10-12 14:07:40 +00:00
xiphon
a12a8174e0 Dandelion++: skip desynced peers in stem phase 2020-10-12 13:44:06 +00:00
moneromooo-monero
4971219c2c
blockchain: deterministic UNIX time unlock checks 
Based on a patch by TheCharlatan <seb.kung@gmail.com>
 2020-09-15 11:40:28 +00:00
selsta
f240b1dd88
build: prepare v0.17 2020-09-14 16:52:42 +02:00
moneromooo-monero
fc2cb224a9
blockchain: fix pow skipping for old blocks without precalc hash 2020-09-07 01:57:19 +00:00
Riccardo Spagni
aefa7740c3
Merge pull request #6111 
d20ff4f64 functional_tests: add a large (many randomx epochs) p2p reorg test (moneromooo-monero)
6a0b3b1f8 functional_tests: add randomx tests (moneromooo-monero)
9d42649d5 core: fix mining from a block that's not the current top (moneromooo-monero)
 2020-09-06 15:49:37 +02:00
luigi1111
ee0b02d0db
Merge pull request #6757 
6a37da8 threadpool: guard against exceptions in jobs, and armour plating (moneromooo-monero)
 2020-09-03 12:25:59 -05:00
moneromooo-monero
6a37da837e
threadpool: guard against exceptions in jobs, and armour plating 
Those would, if uncaught, exit run and leave the waiter to wait
indefinitely for the number of active jobs to reach 0
 2020-09-01 14:33:33 +00:00
moneromooo-monero
d20ff4f648
functional_tests: add a large (many randomx epochs) p2p reorg test 2020-08-27 15:13:04 +00:00
moneromooo-monero
9d42649d58
core: fix mining from a block that's not the current top 2020-08-27 15:13:00 +00:00
moneromooo-monero
82ee01699c
Integrate CLSAGs into monero 
They are allowed from v12, and MLSAGs are rejected from v13.
 2020-08-27 12:44:04 +00:00
Alexander Blair
0c101f1236
Merge pull request #6767 
07442a605 Fix build with Boost 1.74 (moneromooo-monero)
 2020-08-27 03:07:32 -07:00
Alexander Blair
b04da25e4d
Merge pull request #6760 
844fb4e94 enforce claiming maximum coinbase amount (moneromooo-monero)
 2020-08-27 03:01:28 -07:00
moneromooo-monero
844fb4e940
enforce claiming maximum coinbase amount 
Claiming a slightly lesser amount does not yield the size gains
that were seen pre rct, so this closes a fingerprinting vector
 2020-08-21 12:36:53 +00:00
moneromooo-monero
55363c5941
Avoid some temporary strings when reading off the database 2020-08-17 14:02:27 +00:00
Alexander Blair
d73b1b6560
Merge pull request #6727 
13eee1d6a rpc: reject wrong sized txid (moneromooo-monero)
92e6b7df2 easylogging++: fix crash with reentrant logging (moneromooo-monero)
6dd95d530 epee: guard against exceptions in RPC handlers (moneromooo-monero)
90016ad74 blockchain: guard against exceptions in add_new_block/children (moneromooo-monero)
 2020-08-16 12:55:25 -07:00
Alexander Blair
bc48494731
Merge pull request #6661 
267ce5b71 avoid a couple needless copies (moneromooo-monero)
 2020-08-16 12:45:37 -07:00
Alexander Blair
c6c4ead44e
Merge pull request #6614 
fb31167b1 Wallet, daemon: From 'help_advanced' back to 'help', and new 'apropos' command (rbrunner7)
 2020-08-16 12:44:03 -07:00
moneromooo-monero
07442a6059
Fix build with Boost 1.74 
Thanks iDunk for testing
 2020-08-16 16:23:26 +00:00
Alexander Blair
c108c5e2f0
Merge pull request #6354 
67ade8005 Add randomized delay when forwarding txes from i2p/tor -> ipv4/6 (Lee Clagett)
 2020-08-09 06:42:49 -07:00
moneromooo-monero
90016ad744
blockchain: guard against exceptions in add_new_block/children 
Reporter requested credit to be given to Decred
 2020-07-30 22:52:11 +00:00
rbrunner7
fb31167b12 Wallet, daemon: From 'help_advanced' back to 'help', and new 'apropos' command 2020-07-24 07:12:11 +02:00
Alexander Blair
36d50d93f2
Merge pull request #6534 
7bd66b01b daemon: guard against rare 'difficulty drift' bug with checkpoints and recalculation (stoffu)
 2020-07-19 03:36:39 -07:00
Alexander Blair
814e617117
Merge pull request #6526 
5d882f4f1 blockchain: fix theoretical race getting bulk timestamps (moneromooo-monero)
 2020-07-19 03:34:52 -07:00
Alexander Blair
a0d179e528
Merge pull request #6512 
5ef0607da Update copyright year to 2020 (SomaticFanatic)
 2020-07-19 03:32:59 -07:00
moneromooo-monero
332d60719a
tx_pool: mine stem txes in fake chain mode 
This fixes the functional tests, since txes would not be mined
after being sent to the daemon (they'd be waiting for the
dandelion timeout first)
 2020-07-09 14:52:13 +00:00
moneromooo-monero
0fd6ccef21
blockchain: fix timestamp/difficulty cache getting out of sync 
The cache is discarded when a block is popped, but then gets
rebuilt when the difficulty for next block is requested.
While this is all properly locked, it does not take into account
the delay caused by a database transaction being only committed
(and thus its effects made visible to other threads) later on,
which means another thread could request difficulty between
the pop and the commit, which would end up using stale database
view to build the cache, but that cache would not be invalidated
again when the transaction gets committed, which would cause the
cache to not match the new database data.

To fix this, we now keep track of when the cache is invalidated
so we can invalidate it again upon database transaction commit
to ensure it gets calculated again with fresh data next time it
is nedeed.
 2020-07-08 22:31:51 +00:00
luigi1111
99b14ccd6a
Merge pull request #6647 
4d8d121 Fix D++ block template check (vtnerd)
 2020-07-08 17:25:01 -05:00
luigi1111
18bb011afe
Merge pull request #6629 
795e186 blockchain: fix total_height in getblocks.bin response (moneromooo-monero)
 2020-07-08 17:23:28 -05:00
luigi1111
634262f3f5
Merge pull request #6568 
f037121 cryptonote_core: remove 'We are most likely forked' message (moneromooo-monero)
 2020-07-08 17:10:39 -05:00
luigi1111
ed903578d7
Merge pull request #6544 
5741b4d blockchain: detect and log bad difficulty calculations (moneromooo-monero)
 2020-07-08 17:04:41 -05:00
moneromooo-monero
267ce5b718
avoid a couple needless copies 2020-06-14 18:05:35 +00:00
Lee Clagett
4d8d121462 Fix D++ block template check 2020-06-12 22:05:52 -04:00
stoffu
7bd66b01bf
daemon: guard against rare 'difficulty drift' bug with checkpoints and recalculation 
On startup, it checks against the difficulty checkpoints, and if any mismatch is found, recalculates all the blocks with wrong difficulties. Additionally, once a week it recalculates difficulties of blocks after the last difficulty checkpoint.
 2020-06-09 10:40:51 +09:00
moneromooo-monero
795e18632c
blockchain: fix total_height in getblocks.bin response 2020-06-05 15:27:07 +00:00
moneromooo-monero
f0371210e9
cryptonote_core: remove "We are most likely forked" message 
It's time based and we don't have forks every 6 months anymore
 2020-05-19 16:27:24 +00:00
moneromooo-monero
5741b4d74d
blockchain: detect and log bad difficulty calculations 2020-05-17 12:44:45 +00:00
Lee Clagett
67ade80055 Add randomized delay when forwarding txes from i2p/tor -> ipv4/6 2020-05-15 07:57:35 +00:00
selsta
4baee200a7
build: prepare v0.16.0.0 release 2020-05-13 16:15:03 +02:00
moneromooo-monero
5d882f4f14
blockchain: fix theoretical race getting bulk timestamps 2020-05-13 13:42:41 +00:00
luigi1111
77a008f714
Merge pull request #6510 
70609d7 cryptonote_core: take out the time based upgrade warning (moneromooo-monero)
 2020-05-07 10:44:34 -05:00
SomaticFanatic
5ef0607da6 Update copyright year to 2020 
Update copyright year to 2020
 2020-05-06 22:36:54 -04:00
moneromooo-monero
70609d7681
cryptonote_core: take out the time based upgrade warning 
It doesn't really work anymore since we don't have a fork soon
 2020-05-06 18:27:23 +00:00
luigi1111
0f233c6ad8
Merge pull request #6478 
ee58362 Used legacy category to match insert_key_images behavior (vtnerd)
 2020-05-06 00:27:13 -05:00
luigi1111
483e5cab5c
Merge pull request #6472 
2efbd5f cryptonote: fix reuse of non default tx data when relaying (moneromooo-monero)
 2020-05-06 00:25:18 -05:00
luigi1111
1f505a5eac
Merge pull request #6468 
a813c46 cryptonote_core: skip dns checkpoints on startup if not enforced (xiphon)
 2020-05-06 00:22:20 -05:00
Lee Clagett
e5214a2ca2 Adding ZMQ/Pub support for txpool_add and chain_main events 2020-05-04 02:06:35 +00:00
luigi1111
443f5c6bda
Merge pull request #6436 
688a3e8 Add timelock verification on device (cslashm)
 2020-05-01 15:20:05 -05:00
Sumo Gr
dd807b8410 txpool.cpp: rename var to fix for old g++ version (xenial default) 2020-04-29 10:03:51 +00:00
Lee Clagett
ee58362b1f Used legacy category to match insert_key_images behavior 2020-04-24 20:19:37 -04:00
moneromooo-monero
2efbd5f0cc
cryptonote: fix reuse of non default tx data when relaying 
An automatic tx variable is initialized properly on the first
run through the loop, but not the second. Moving the variable
inside the loop ensures the ctor is called again to init it.
 2020-04-22 16:50:20 +00:00
xiphon
a813c46a1b cryptonote_core: skip dns checkpoints on startup if not enforced 2020-04-20 18:56:22 +00:00
cslashm
688a3e87e7 Add timelock verification on device 2020-04-08 11:12:32 +02:00
luigi1111
44547006bf
Merge pull request #6347 
fcb06f7 cryptonote_core: skip block notify on blockchain switching rollback (xiphon)
 2020-04-04 12:52:46 -05:00
luigi1111
c4f75fe898
Merge pull request #6339 
c61abf8 remove empty statements (shopglobal)
 2020-04-04 12:47:31 -05:00
luigi1111
0bb7191fd6
Merge pull request #6328 
9bde70e core: mention time being off in hash rate changes message (moneromooo-monero)
 2020-04-04 12:40:18 -05:00
luigi1111
6c7d928f19
Merge pull request #6336 
760ecf2 console_handler: do not let exception past the dor (moneromooo-monero)
09c8111 threadpool: lock mutex in create (moneromooo-monero)
e377977 tx_pool: catch theoretical error in get_block_reward (moneromooo-monero)
 2020-03-31 15:14:12 -05:00
luigi1111
096e2135dd
Merge pull request #6214 
054b4c7 protocol: request txpool contents when synced (moneromooo-monero)
 2020-03-31 13:32:55 -05:00
Lee Clagett
571546067f Always reject duplicate key-images from second txid 2020-03-30 17:52:42 +00:00
Lee Clagett
babf25d2ec Allow unrestricted rpc calls to get full txpool info 2020-03-30 17:52:42 +00:00
Alexander Blair
8cb005b39c
Merge pull request #6289 
ffe7165e wallet: reroll fake outs selection on local tx_sanity_check failure (xiphon)
 2020-03-27 12:28:29 -07:00
Alexander Blair
aa982a51da
Merge pull request #6284 
02224e71 Fix check_fee() discrepancy. (UkoeHB)
 2020-03-27 12:21:26 -07:00
Alexander Blair
a22cf5de1b
Merge pull request #6275 
aa93e388 p2p: remove old debug commands (Aaron Hook)
 2020-03-27 12:16:30 -07:00
Lee Clagett
02d887c2e5 Adding Dandelion++ support to public networks: 
- New flag in NOTIFY_NEW_TRANSACTION to indicate stem mode
  - Stem loops detected in tx_pool.cpp
  - Embargo timeout for a blackhole attack during stem phase
 2020-03-26 15:01:30 +00:00
luigi1111
228af683a7
Merge pull request #6403 
5de2295 Correct key image check in tx_pool (vtnerd)
 2020-04-10 16:10:33 -05:00
luigi1111
7954f8cb18
Merge pull request #6358 
8958b4e blockchain_db: faster fetching of consecutive txes (moneromooo-monero)
 2020-04-10 16:01:37 -05:00
moneromooo-monero
054b4c7f41
protocol: request txpool contents when synced 
A newly synced Alice sends a (typically quite small) list of
txids in the local tpxool to a random peer Bob, who then uses
the existing tx relay system to send Alice any tx in his txpool
which is not in the list Alice sent
 2020-03-22 16:03:31 +00:00
Aaron Hook
aa93e38862 p2p: remove old debug commands 2020-03-20 22:09:44 -07:00
Lee Clagett
5de2295f3c Correct key image check in tx_pool 2020-03-14 19:17:15 +00:00
moneromooo-monero
f8d76f395b
core: move the LockedTXN class out of txpool so it may be reused 
for example, in the RPC server
 2020-03-12 11:30:05 +00:00
Alexander Blair
4371ac4265
Merge pull request #6225 
987c3139 print_coinbase_tx_sum now supports 128 bits sums (moneromooo-monero)
 2020-02-28 19:48:11 -08:00
Alexander Blair
4da37daf67
Merge pull request #6211 
5985c5af rpc: add bad-blocks to flush_cache RPC (moneromooo-monero)
 2020-02-28 19:36:16 -08:00
moneromooo-monero
8958b4e7aa
blockchain_db: faster fetching of consecutive txes 
Useful for wallet refresh or node sync
 2020-02-27 15:05:34 +00:00
xiphon
fcb06f7a82 cryptonote_core: skip block notify on blockchain switching rollback 2020-02-19 16:19:29 +00:00
Interchained
c61abf87c0 remove empty statements 
Cleaning up a little around the code base.
 2020-02-17 11:55:15 -05:00
moneromooo-monero
e3779775d7
tx_pool: catch theoretical error in get_block_reward 
Coverity 196626
 2020-02-12 21:05:28 +00:00
moneromooo-monero
9bde70e567
core: mention time being off in hash rate changes message 2020-02-10 16:56:10 +00:00
Alexander Blair
e552ba14b2
Merge pull request #6127 
67b4a19e simplewallet: noob-friendly help menu (wowario)
 2020-02-06 00:33:31 -08:00