Riccardo Spagni
5953724f69
Merge pull request #2443
...
ffe27127
2017-09-25 16:51:07 +02:00
Riccardo Spagni
b911130a46
Merge pull request #2442
...
e29282d2
2017-09-25 16:50:35 +02:00
moneromooo-monero
fee15ef1a9
wallet2: catch failure to parse address
...
CID 175297
2017-09-25 15:48:48 +01:00
moneromooo-monero
54cc209a5e
wallet_rpc_server: catch failure to create directory
...
CID 175281
2017-09-25 15:48:39 +01:00
moneromooo-monero
3e55099cb2
wallet_rpc_server: init m_vm to NULL in ctor
...
CID 175279
2017-09-25 15:48:36 +01:00
moneromooo-monero
7d0dde5eb5
wallet_args: remove redundant default value for --log-file
...
CID 175265
2017-09-25 15:48:33 +01:00
moneromooo-monero
ed4a33502d
wallet2: catch failure to save keys file
...
CID 161848
2017-09-25 15:48:30 +01:00
moneromooo-monero
44434c8a37
wallet2_api: check whether dynamic_cast returns NULL
...
CID 161844
2017-09-25 15:48:27 +01:00
moneromooo-monero
5475692ed5
wallet2_api: remove an unused, uninitialized, field
...
Silences CID 161874
2017-09-25 15:48:21 +01:00
moneromooo-monero
b2763ace06
wallet2_api: init error code to "no error" in the ctor
...
CID 161872
2017-09-25 15:48:16 +01:00
moneromooo-monero
2e44d8f23c
wallet_rpc_server: guard against exceptions
...
CID 175305
2017-09-25 15:48:10 +01:00
Riccardo Spagni
ce37967dd2
Merge pull request #2386
...
a15e85838fe5f609
2017-09-25 16:40:54 +02:00
Riccardo Spagni
216395d43e
Merge pull request #2379
...
9c83f806
2017-09-25 16:40:35 +02:00
Riccardo Spagni
ec0e144e90
Merge pull request #2377
...
b5cbdce8
2017-09-25 16:40:16 +02:00
Riccardo Spagni
40d213154b
Merge pull request #2289
...
6ee1116d
2017-09-25 16:38:14 +02:00
Riccardo Spagni
c6306e75e7
Merge pull request #2257
...
651baaec
2017-09-25 16:37:17 +02:00
m2049r
6ee1116d75
store is optional during close and defaults to true; except during descruction
2017-09-23 00:52:09 +02:00
stoffu
e29282d208
build: auto update version info without manually deleting version.h
2017-09-21 07:47:37 +09:00
stoffu
b5cbdce8a6
wallet2: correctly handle in/out payments for view-only wallet
2017-09-21 07:46:19 +09:00
Riccardo Spagni
a6403846ef
Merge pull request #2441
...
fee3c3ed
2017-09-20 21:41:33 +02:00
Riccardo Spagni
786a4ae9ea
Merge pull request #2429
...
55b91d86
2017-09-20 21:41:09 +02:00
moneromooo-monero
d5a9edf27a
wallet2: fix exception on split txes
2017-09-20 10:35:15 +01:00
moneromooo-monero
5c5b0fd048
wallet2: print unused indices on a single line
...
Decreases log spam massively on large wallets
2017-09-20 10:34:45 +01:00
selsta
91def9a59b
daemon, wallet: add --max-log-file-size option
2017-09-17 04:42:45 +02:00
Howard Chu
510d0d4753
Use a threadpool
...
Instead of constantly creating and destroying threads
2017-09-14 21:42:48 +01:00
moneromooo-monero
ffe2712726
wallet_rpc_server: fix index for newly added address book entry
2017-09-13 11:02:06 +01:00
Matthew Campassi
fee3c3ed1e
Update wallet2.cpp for misspelling
...
Misspelling in wallet2.cpp
2017-09-12 16:11:45 -05:00
moneromooo-monero
651baaec46
wallet: add encrypted seed functionality
...
This uses luigi1111's CN_Add method.
See https://xmr.llcoins.net for details.
2017-09-12 13:56:01 +01:00
moneromooo-monero
a15e858302
wallet2: guard against daemon sending txes in the wrong order
2017-09-11 16:48:28 +01:00
moneromooo-monero
55b91d8605
wallet: fix --help and --version erroring out
2017-09-10 14:12:32 +01:00
Riccardo Spagni
e19b68b005
Merge pull request #2362
...
adce8ae4
2017-09-02 11:30:07 +02:00
Riccardo Spagni
2560948f69
Merge pull request #2342
...
2e338ca5
2017-09-02 11:29:53 +02:00
Riccardo Spagni
10da3051c2
Merge pull request #2309
...
d58700e08a9bbd26d27fe32e225a25f3
2017-09-02 11:28:25 +02:00
Lee Clagett
9c83f8063d
Do not create file when RPC user/pass is given and use file locking
2017-08-30 17:39:59 -04:00
moneromooo-monero
adce8ae466
simplewallet: new "fee" command to display fee information
...
including expected transaction backlog at different priorities
2017-08-29 16:28:18 +01:00
moneromooo-monero
f906d87e66
wallet: new option to check/confirm txpool backlog when sending
2017-08-26 17:16:30 +01:00
moneromooo-monero
2e338ca574
wallet2: account for huge testnet reorgs for estimating height
2017-08-25 11:03:51 +01:00
Jaquee
d58700e003
WalletAPI: only allow trusted daemon when importing key images
2017-08-21 08:11:12 +02:00
Jaquee
8a9bbd26d3
WalletAPI: copy wallet data when creating a view only wallet
2017-08-21 08:11:12 +02:00
Jaquee
d27fe32e4a
wallet2: export/import wallet data functions
2017-08-21 08:11:12 +02:00
Jaquee
225a25f327
import_key_images - allow importing without being connected to daemon
2017-08-18 16:11:30 +02:00
Riccardo Spagni
9e6bcbc014
Merge pull request #2286
...
8655ba04
2017-08-15 20:55:30 +02:00
Riccardo Spagni
a861cbb465
Merge pull request #2279
...
359517c720495b27
2017-08-15 20:53:58 +02:00
Riccardo Spagni
b6fc7f283f
Merge pull request #2270
...
1307e3cc
2017-08-15 20:51:11 +02:00
Riccardo Spagni
9721b37bd5
Merge pull request #2258
...
74597bd1
2017-08-15 20:49:56 +02:00
Riccardo Spagni
085ef96768
Merge pull request #2252
...
9707998a
2017-08-15 20:48:31 +02:00
Riccardo Spagni
6f60613ffb
Merge pull request #2240
...
b7d6ec83fa23a500f1307bbd
2017-08-15 20:46:31 +02:00
Riccardo Spagni
4c24eb050b
Merge pull request #2238
...
ad4649ac
2017-08-15 20:46:09 +02:00
Riccardo Spagni
d64b9c1c9e
Merge pull request #2233
...
67ce4910
2017-08-15 20:45:19 +02:00
Riccardo Spagni
68ccc10b29
Merge pull request #2205
...
c97d1bd3
2017-08-15 20:44:44 +02:00
moneromooo-monero
8655ba04ba
wallet_rpc_server: adjust small ring sizes to 5 for v6
2017-08-12 12:59:06 +01:00
Jaquee
359517c7f5
wallet_rpc_server: fix possible privacy leak in on_import_key_images()
2017-08-11 11:18:21 +02:00
Jaquee
1307e3cc12
WalletAPI: add getDefaultDataDir()
2017-08-09 12:38:29 +02:00
Riccardo Spagni
bfd2532ea5
Merge pull request #2247
...
a839a6fa
2017-08-07 23:34:06 +02:00
moneromooo-monero
61770ec2da
change mixin to ring size in user visible places
2017-08-07 21:12:27 +01:00
Riccardo Spagni
3db039828e
Merge pull request #2254
...
e31aac8048c0cb1bf233c01c
2017-08-07 16:01:40 +02:00
Riccardo Spagni
15e895399c
Merge pull request #2239
...
600353e2
2017-08-07 15:13:30 +02:00
Riccardo Spagni
1e2d6f898e
Merge pull request #2211
...
525975ac
2017-08-07 15:10:13 +02:00
Riccardo Spagni
f5be5b7e7b
Merge pull request #2210
...
cb0b5594
2017-08-07 15:09:45 +02:00
Riccardo Spagni
24dd5e87af
Merge pull request #2203
...
0c57df97
2017-08-07 15:09:17 +02:00
Riccardo Spagni
5a04301b32
Merge pull request #2201
...
dc0b312f5eb79983
2017-08-07 15:09:03 +02:00
moneromooo-monero
74597bd15a
wallet2: improve refresh height determination
...
As reported by jaquee, the calculation could underflow for very
low heights.
Additionally, we now use the target height too.
2017-08-06 16:56:51 +01:00
Jaquee
e31aac80e5
walletAPI: add getRefreshFromBlockHeight()
2017-08-05 19:23:55 +02:00
Jaquee
48c0cb1ba6
wallet api: pause refresh while commiting tx
2017-08-05 19:21:23 +02:00
moneromooo-monero
9707998a08
wallet2: clear some missing containers in clear()
2017-08-05 18:09:31 +01:00
Jaquee
67ce4910bc
wallet2: store testnet bool in keys file
2017-08-05 17:23:47 +02:00
moneromooo-monero
0c57df9770
wallet2: fix temporarily missing incoming tx when being mined
...
When scanning the txpool without having first updated the
blockchain, the tx would be seen as neither in the txpool
nor the chain, and removed, so it'd only reappear once the
chain is refreshed, and the tx seen in a block.
2017-08-05 12:36:03 +01:00
Jaquee
a839a6fa8a
Wallet API: add tx unlock time
2017-08-03 21:37:45 +02:00
m2049r
ad4649ac81
Enable verifying wallet password with having to load wallet.
2017-08-03 01:45:45 +02:00
moneromooo-monero
fa23a5006d
wallet2: add a is_synced function
2017-08-02 14:44:19 +01:00
moneromooo-monero
f1307bbd7b
node_rpc_proxy: add a proxy for target height
2017-08-02 14:43:47 +01:00
moneromooo-monero
c97d1bd3d4
wallet: return unlock_time in get_transfers
...
also show it in simplewallet's show_transfer
2017-08-02 10:15:27 +01:00
m2049r
600353e2b2
fix wallet callback signatures
2017-08-02 01:23:53 +02:00
Erik de Castro Lopo
525975acc4
wallet-cli: Minor improvement to help output
2017-07-27 20:36:28 +10:00
moneromooo-monero
cb0b559451
Move OpenAlias console input back from libs
...
Library code should definitely not ask for console input unless
it's clearly an input function. Delegating the user interaction
part to the caller means it can now be used by a GUI, or have a
decision algorithm better adapted to a particular caller.
2017-07-27 11:30:13 +01:00
moneromooo-monero
dc0b312f8a
wallet_rpc_server: optionally return tx blobs on transfer calls
...
also add do_not_relay flag to them, so it now becomes possible
to create a tx without sending it yet
2017-07-26 10:33:04 +01:00
Erik de Castro Lopo
35d68b2c6d
Fix spelling errors
2017-07-05 17:53:16 +10:00
Riccardo Spagni
218f1a1d69
Merge pull request #2125
...
f98bf48b
2017-07-03 12:30:46 +02:00
Riccardo Spagni
44e4bbd15c
Merge pull request #2124
...
3b599d2bd3bb72ff32754784
2017-07-03 12:30:16 +02:00
Riccardo Spagni
645c898e2d
Merge pull request #2121
...
5a09d79cFix #2120 : return per-tx amount in transfer_split RPC call. (binaryFate)
2017-07-03 12:28:56 +02:00
binaryFate
f98bf48b1d
Minor cleanup: tab vs. space + logs messages
2017-06-26 12:30:14 +02:00
binaryFate
5a09d79caf
Fix #2120 : return per-tx amount in transfer_split RPC call.
2017-06-26 12:22:12 +02:00
moneromooo-monero
3b599d2b7e
wallet2: get current height from the daemon on creation
...
Use current time to estimate current height only if the daemon
cannot be queried.
2017-06-26 08:11:14 +01:00
moneromooo-monero
d3bb72fff1
wallet2: fix infinite loop on future refresh height
...
If the refresh height is in the future, the current code will
loop till the actual height reaches this. Fix it by bailing out
if we receive only three hashes, which is what we set in the
call parameters.
2017-06-26 06:58:37 +01:00
moneromooo-monero
32754784db
wallet: fix refresh_from_height setting on new wallet
...
The previous patch was based on a wrong premise (that the
daemon height was 0 because the daemon calling code wasn't
yet initialized). In fact, current height approximation
was not setup for testnet. Fix this.
2017-06-26 06:58:31 +01:00
Mike C
b592cb3f0a
Fix on_transfer RPC incorrect logging info
2017-06-23 11:54:10 -04:00
Riccardo Spagni
ae8841f2ab
Merge pull request #2087
...
4e13ab30
2017-06-18 17:36:55 +02:00
moneromooo-monero
4e13ab306a
wallet_api: fix missing transaction parameter in callback
...
It was unused, so harmless
Reported by erikd on IRC
2017-06-13 19:34:51 +01:00
Robby Weinberg
71f8249a08
Prevent crash if performing certain actions before wallet is initialized
2017-06-03 19:56:51 -05:00
Riccardo Spagni
ea286d1a14
Merge pull request #2058
...
6bcd3b2d
2017-06-01 19:42:37 +02:00
schnerchi
6bcd3b2df1
fix get_upper_transaction rename
2017-05-31 12:26:42 +02:00
Riccardo Spagni
f5e65452ce
Merge pull request #2042
...
740bc24c
2017-05-30 21:24:45 +02:00
Riccardo Spagni
a4c13ea092
Merge pull request #2039
...
4b932ff3
2017-05-30 21:24:11 +02:00
Riccardo Spagni
cd13bcb4d2
Merge pull request #2036
...
89b2f306a374a522
2017-05-30 21:23:05 +02:00
Riccardo Spagni
d621f9e558
Merge pull request #2022
...
e25293473029d0ef
2017-05-30 21:19:00 +02:00
Riccardo Spagni
024860b49d
Merge pull request #2020
...
6cb1ad1f
2017-05-30 21:14:24 +02:00
moneromooo-monero
0a182576d0
node_rpc_proxy: fix earliest fork height query for unknown forks
2017-05-26 21:34:44 +01:00
Jaquee
740bc24c95
Wallet API: Set seed lang when recovering form keys
2017-05-23 14:01:23 +02:00
Gentian
4b932ff314
changed crypto to cncrypto so it generated libcncrypto
...
fix a cmakelist
2017-05-23 07:45:40 -04:00
moneromooo-monero
a374a522df
wallet2: check key image validity domain in import_key_images
2017-05-18 09:19:48 +01:00
Nano Akron
e2529347b6
Correct spelling of 'get_upper_transaction_size_limit'
2017-05-09 16:02:57 +01:00
Nano Akron
3029d0efb3
Remove the 1.25x multiplier in max transaction size in just the wallet
2017-05-09 16:01:11 +01:00
stoffu
6cb1ad1fa2
wallet fix: ensure iterator to be valid
2017-05-09 11:54:21 +09:00
moneromooo-monero
391c918d87
wallet2: fix sweep_unmixable assuming wrong minimum mixin at v5
...
The bump to minimum mixin 4 was moved from v5 to v6
2017-05-07 18:27:25 +01:00
Riccardo Spagni
81b370d5a1
Merge pull request #2012
...
bbf4c210
2017-05-05 11:35:03 +02:00
Jaquee
bbf4c21048
Wallet API: add spend/view key getters
2017-05-02 16:48:38 +02:00
moneromooo-monero
6df83b3efb
wallet: add sweep_below function
...
It sweeps all outputs below the given threshold
This is available via the existing sweep_all RPC, by setting
amount_threshold the desired amount (in atomic units)
2017-04-24 19:50:37 +01:00
Riccardo Spagni
9a9fb0483f
Merge pull request #1996
...
a6d5bb75ac1aba90
2017-04-24 10:55:24 +02:00
Riccardo Spagni
999b0f399d
Merge pull request #1989
...
7f4beaa4
2017-04-24 10:50:54 +02:00
Riccardo Spagni
ae1d816768
Merge pull request #1976
...
a7d78dda
2017-04-24 10:48:56 +02:00
Riccardo Spagni
29a77c9b19
Merge pull request #1961
...
89d70756
2017-04-24 10:43:39 +02:00
Riccardo Spagni
0a6da8929d
Merge pull request #1959
...
10e137be
2017-04-24 10:43:13 +02:00
moneromooo-monero
a6d5bb75fe
wallet2: refer to triangular distribution for recent zone in comment
...
It was wrongly refering to equiprobable distribution, which I think
I'd originally done, but forgot to update the comment after changing
to triangular
Reported by smooth on IRC
2017-04-22 11:22:39 +01:00
moneromooo-monero
ac1aba90f8
wallet2: bias fake outs more towards recent outputs
...
Two recent papers quantified the real usage bias for the
real output in a ring being the true one, and shows that
the current biasing is much too weak.
While we wait for a better solution, we increase the ratio
of recent-to-total fake outputs, as well as decrease the
time window for recent outputs, so that half the fake outs
are selected within the last 1.8 day. Value plucked from
figure 10, page 11 of An Empirical Analysis of Linkability
in the Monero Blockchain, 2017, Miller et al.
This is also arbitrary, of course, but serves as a stopgap
till a better selection algorithm is chosen.
2017-04-22 10:29:03 +01:00
moneromooo-monero
7f4beaa44a
wallet2: fix removal of wrong txes from unconfirmed_payments
...
unconfirmed_payments changed from having the txid as key to
the payment id, and this was not changed to match.
2017-04-17 19:37:13 +01:00
moneromooo-monero
a7d78dda77
wallet2: fix --generate-from-json in RPC mode
...
The daemon address was initialized too late
2017-04-14 22:12:20 +01:00
Howard Chu
110b683152
Resolve #92 add ability to create wallets thru RPC
...
Reviewed and squashed. Open/Create is only allowed if no walletfile
was specified at startup.
2017-04-11 01:22:44 +01:00
Riccardo Spagni
4be94be168
Merge pull request #1951
...
0a7885bf
2017-04-11 00:26:47 +02:00
Riccardo Spagni
e9ca165b1a
Merge pull request #1950
...
f5bd3465d8a88d05
2017-04-11 00:26:15 +02:00
moneromooo-monero
89d707566a
wallet2: fix spurious output splitting when not merging destinations
2017-04-08 11:13:28 +01:00
moneromooo-monero
10e137be3a
wallet2: mention escaping/quoting --password in help string
2017-04-06 21:24:55 +01:00
Jaquee
f5bd346573
IOS CMAKE build settings
2017-04-03 18:38:50 +02:00
Jaquee
0a7885bf19
Wallet API: fix Cold signing split tx
2017-04-02 14:19:21 +02:00
moneromooo-monero
0ee018b407
wallet2: do not go over the target tx size if many destinations
...
If using a large input and many destinations, the code would
generate as many outputs as it could using that input, even if
it would bring the resulting tx above the max tx size.
2017-04-02 11:13:15 +01:00
moneromooo-monero
a50c4a4fad
wallet: option to merge destinations
...
With the change from the original transfer method to the new
algorithm, payments to the same destination were merged. It
seemed like a good idea, optimizing space. However, it is a
useful tool for people who want to split large outputs into
several smaller ones (ie, service providers making frequent
payments, and who do not like a large chunk of their balance
being locked for 10 blocks after each payment).
Default to off, which is a change from the previous behavior.
2017-03-25 11:44:04 +00:00
moneromooo-monero
0ad87db01f
wallet: try to save large outputs when using an unneeded second input
...
When a single input is enough to satisfy a transfer, the code would
previously try to add a second input, to match the "canonical" makeup
of a transaction with two inputs and two outputs. This would cause
wallets to slowly merge outputs till all the monero ends up in a
single output, which causes trouble when making two transactions
one after the other, since change is locked for 10 blocks, and an
increasing portion of the remaining balance would end up locked on
each transaction.
There are two new settings (min-output-count and min-output-value)
which can control when to stop adding such unneeded second outputs.
The idea is that small "dust" outputs will still get added, but
larger ones will not.
Enable with, eg:
set min-output-count 10
set min-output-value 30
to avoid using an unneeded second output of 30 monero or more, if
there would be less than 10 such outputs left.
This does not invalidate any other reason why such outputs would
be used (ie, when they're really needed to satisfy a transfer, or
when randomly picked in the normal course of selection). This may
be improved in the future.
2017-03-24 21:04:08 +00:00
Riccardo Spagni
92c2d79d10
Merge pull request #1915
...
a8646b09
2017-03-24 14:34:55 +02:00
Riccardo Spagni
f543377789
Merge pull request #1894
...
8bbcbcfb
2017-03-24 14:33:47 +02:00
Jaquee
a8646b0957
Wallet API: add hard fork info functions
2017-03-24 09:59:26 +01:00
moneromooo-monero
558cfc31ca
core, wallet: faster tx pool scanning
...
Includes a new RPC to get tx pool hashes fast.
2017-03-23 09:25:22 +00:00
Riccardo Spagni
70e71a1845
Merge pull request #1904
...
995969b1
2017-03-21 14:09:42 +02:00
Riccardo Spagni
7769a6e757
Merge pull request #1903
...
350e99ae
2017-03-21 14:09:19 +02:00
Riccardo Spagni
9d157b519d
Merge pull request #1899
...
c1e9ccc7
2017-03-21 14:08:36 +02:00
moneromooo-monero
995969b190
wallet: fix set_log not handling 0,xxx style settings
2017-03-21 11:17:05 +00:00
moneromooo-monero
350e99ae57
wallet2: cache which pool txes were scanned already
...
This massively speeds up the wallet updating the pool on mainnet,
where the tx backlog is more than 500 txes.
2017-03-21 10:30:25 +00:00
moneromooo-monero
5b7c6ced80
wallet2: start using new fee priorities at v5, not 14 days laer
...
Waiting would mean the fee used is 1x base, but the base will
have suddenly dropped
2017-03-20 18:34:56 +00:00
moneromooo-monero
c1e9ccc794
wallet2: speed up transactions using remote nodes
...
Asking for a full histogram from a remote node (since it's
untrusted) is pretty slow, and spams the remote node, so
we replace it by only adding a second input if we have rct
ones, which are for all intents and purposes always mixable.
2017-03-20 08:44:28 +00:00
stoffu
8bbcbcfb0d
wallet rpc: enable solo mining
2017-03-20 09:47:16 +09:00
Riccardo Spagni
45fa27b56a
Merge pull request #1892
...
df810a82
2017-03-19 22:58:55 +02:00
kenshi84
df810a8250
wallet-rpc bugfix: get_transfer_by_txid previously checking against payment id
2017-03-19 17:45:39 +09:00
moneromooo-monero
24ae71404f
wallet: increase node_rpc_proxy timeout to match wallet2
2017-03-18 23:06:06 +00:00
Riccardo Spagni
a6f1959d1c
Merge pull request #1884
...
e9175cec
2017-03-18 20:30:50 +02:00
Riccardo Spagni
f33a696ec7
Merge pull request #1883
...
d0238313
2017-03-18 20:30:19 +02:00
Riccardo Spagni
9aac64c238
Merge pull request #1882
...
3fa597559d134e86
2017-03-18 20:29:22 +02:00
moneromooo-monero
e9175cec07
wallet_rpc_server: make a few RPCs unavailable in restricted mode
...
Address book modification, setting tx nodes, importing key images
2017-03-18 13:01:53 +00:00
moneromooo-monero
d023831327
use const references in catch blocks
2017-03-18 12:56:07 +00:00
moneromooo-monero
3fa5975520
wallet2: call is_key_image_spent in blocks in rescan_spent
...
This is a potentially long lasting daemon RPC call
2017-03-18 12:47:07 +00:00
moneromooo-monero
9d134e8647
wallet_rpc_server: add a rescan_spent RPC
2017-03-18 12:04:17 +00:00
stoffu
250c4cb3e0
wallet-rpc: enable openalias
2017-03-17 10:42:10 +09:00
Riccardo Spagni
c642d3224c
Merge pull request #1869
...
3396a9f2
2017-03-15 18:23:51 +01:00
