Lee Clagett
679d05567d
Remove payload copy in all outgoing p2p messages
2021-01-19 02:22:32 +00:00
luigi1111
e45619e61e
Revert "Merge pull request #7136 "
...
This reverts commit 63c7ca07fb
, reversing
changes made to 2218e23e84
.
2021-04-16 13:52:44 -05:00
Lee Clagett
23aae5571b
Remove payload copy in all outgoing p2p messages
2021-01-16 22:53:28 +00:00
luigi1111
6556c33f13
Merge pull request #7355
...
bd12984
Remove copies from foreach loops (thanks to Clang) (Lee Clagett)
1572df9
Removing unused namespace alias (Lee Clagett)
2021-02-18 14:06:47 -05:00
Kevin Barbour
85db1734e7
Remove unused variables in monero codebase
...
There are quite a few variables in the code that are no longer
(or perhaps never were) in use. These were discovered by enabling
compiler warnings for unused variables and cleaning them up.
In most cases where the unused variables were the result
of a function call the call was left but the variable
assignment removed, unless it was obvious that it was
a simple getter with no side effects.
2021-02-09 08:05:05 +01:00
Lee Clagett
bd129849f0
Remove copies from foreach loops (thanks to Clang)
2021-01-28 23:42:40 -05:00
moneromooo-monero
1e27f7101e
blockchain: lock access to m_blocks_hash_of_hashes
...
it is accessed both when adding and when prevalidating a set
of new hashes from a peer
2021-01-02 22:19:54 +00:00
moneromooo-monero
0aa541b361
protocol: more sanity checks in new chain block hashes
2020-12-31 23:33:18 +00:00
moneromooo-monero
1eb14af1a3
rpc: limit the number of txes for get_blocks.bin
2020-12-29 04:31:58 +00:00
luigi1111
4d298d4f11
Merge pull request #6924
...
874487f
blockchain: remove some dead code (moneromooo-monero)
2020-11-29 01:44:26 -06:00
moneromooo-monero
874487fed8
blockchain: remove some dead code
...
This is already done
2020-10-20 16:50:36 +00:00
SChernykh
a25bc71f3f
Make Blockchain::get_fee_quantization_mask() compile time
...
This also removes potential thread safety bug in that function.
2020-10-20 14:16:09 +02:00
moneromooo-monero
88fde0309a
blockchain: fix sync at v14 boundary
...
Miners with MLSAG txes which they'd already verified included
a couple in that block, but the consensus rules had changed
in the meantime, so that block is technically invalid and any
node which did not already have those two txes in their txpool
could not sync. Grandfather them in, since it has no effect in
practice.
2020-10-18 11:52:33 +00:00
moneromooo-monero
4971219c2c
blockchain: deterministic UNIX time unlock checks
...
Based on a patch by TheCharlatan <seb.kung@gmail.com>
2020-09-15 11:40:28 +00:00
selsta
f240b1dd88
build: prepare v0.17
2020-09-14 16:52:42 +02:00
moneromooo-monero
fc2cb224a9
blockchain: fix pow skipping for old blocks without precalc hash
2020-09-07 01:57:19 +00:00
Riccardo Spagni
aefa7740c3
Merge pull request #6111
...
d20ff4f64
functional_tests: add a large (many randomx epochs) p2p reorg test (moneromooo-monero)
6a0b3b1f8
functional_tests: add randomx tests (moneromooo-monero)
9d42649d5
core: fix mining from a block that's not the current top (moneromooo-monero)
2020-09-06 15:49:37 +02:00
luigi1111
ee0b02d0db
Merge pull request #6757
...
6a37da8
threadpool: guard against exceptions in jobs, and armour plating (moneromooo-monero)
2020-09-03 12:25:59 -05:00
moneromooo-monero
6a37da837e
threadpool: guard against exceptions in jobs, and armour plating
...
Those would, if uncaught, exit run and leave the waiter to wait
indefinitely for the number of active jobs to reach 0
2020-09-01 14:33:33 +00:00
moneromooo-monero
9d42649d58
core: fix mining from a block that's not the current top
2020-08-27 15:13:00 +00:00
moneromooo-monero
82ee01699c
Integrate CLSAGs into monero
...
They are allowed from v12, and MLSAGs are rejected from v13.
2020-08-27 12:44:04 +00:00
Alexander Blair
b04da25e4d
Merge pull request #6760
...
844fb4e94
enforce claiming maximum coinbase amount (moneromooo-monero)
2020-08-27 03:01:28 -07:00
moneromooo-monero
844fb4e940
enforce claiming maximum coinbase amount
...
Claiming a slightly lesser amount does not yield the size gains
that were seen pre rct, so this closes a fingerprinting vector
2020-08-21 12:36:53 +00:00
moneromooo-monero
55363c5941
Avoid some temporary strings when reading off the database
2020-08-17 14:02:27 +00:00
Alexander Blair
d73b1b6560
Merge pull request #6727
...
13eee1d6a
rpc: reject wrong sized txid (moneromooo-monero)
92e6b7df2
easylogging++: fix crash with reentrant logging (moneromooo-monero)
6dd95d530
epee: guard against exceptions in RPC handlers (moneromooo-monero)
90016ad74
blockchain: guard against exceptions in add_new_block/children (moneromooo-monero)
2020-08-16 12:55:25 -07:00
Alexander Blair
bc48494731
Merge pull request #6661
...
267ce5b71
avoid a couple needless copies (moneromooo-monero)
2020-08-16 12:45:37 -07:00
moneromooo-monero
90016ad744
blockchain: guard against exceptions in add_new_block/children
...
Reporter requested credit to be given to Decred
2020-07-30 22:52:11 +00:00
Alexander Blair
36d50d93f2
Merge pull request #6534
...
7bd66b01b
daemon: guard against rare 'difficulty drift' bug with checkpoints and recalculation (stoffu)
2020-07-19 03:36:39 -07:00
Alexander Blair
814e617117
Merge pull request #6526
...
5d882f4f1
blockchain: fix theoretical race getting bulk timestamps (moneromooo-monero)
2020-07-19 03:34:52 -07:00
Alexander Blair
a0d179e528
Merge pull request #6512
...
5ef0607da
Update copyright year to 2020 (SomaticFanatic)
2020-07-19 03:32:59 -07:00
moneromooo-monero
0fd6ccef21
blockchain: fix timestamp/difficulty cache getting out of sync
...
The cache is discarded when a block is popped, but then gets
rebuilt when the difficulty for next block is requested.
While this is all properly locked, it does not take into account
the delay caused by a database transaction being only committed
(and thus its effects made visible to other threads) later on,
which means another thread could request difficulty between
the pop and the commit, which would end up using stale database
view to build the cache, but that cache would not be invalidated
again when the transaction gets committed, which would cause the
cache to not match the new database data.
To fix this, we now keep track of when the cache is invalidated
so we can invalidate it again upon database transaction commit
to ensure it gets calculated again with fresh data next time it
is nedeed.
2020-07-08 22:31:51 +00:00
luigi1111
18bb011afe
Merge pull request #6629
...
795e186
blockchain: fix total_height in getblocks.bin response (moneromooo-monero)
2020-07-08 17:23:28 -05:00
luigi1111
ed903578d7
Merge pull request #6544
...
5741b4d
blockchain: detect and log bad difficulty calculations (moneromooo-monero)
2020-07-08 17:04:41 -05:00
moneromooo-monero
267ce5b718
avoid a couple needless copies
2020-06-14 18:05:35 +00:00
stoffu
7bd66b01bf
daemon: guard against rare 'difficulty drift' bug with checkpoints and recalculation
...
On startup, it checks against the difficulty checkpoints, and if any mismatch is found, recalculates all the blocks with wrong difficulties. Additionally, once a week it recalculates difficulties of blocks after the last difficulty checkpoint.
2020-06-09 10:40:51 +09:00
moneromooo-monero
795e18632c
blockchain: fix total_height in getblocks.bin response
2020-06-05 15:27:07 +00:00
moneromooo-monero
5741b4d74d
blockchain: detect and log bad difficulty calculations
2020-05-17 12:44:45 +00:00
selsta
4baee200a7
build: prepare v0.16.0.0 release
2020-05-13 16:15:03 +02:00
moneromooo-monero
5d882f4f14
blockchain: fix theoretical race getting bulk timestamps
2020-05-13 13:42:41 +00:00
SomaticFanatic
5ef0607da6
Update copyright year to 2020
...
Update copyright year to 2020
2020-05-06 22:36:54 -04:00
Lee Clagett
e5214a2ca2
Adding ZMQ/Pub support for txpool_add and chain_main events
2020-05-04 02:06:35 +00:00
luigi1111
7954f8cb18
Merge pull request #6358
...
8958b4e
blockchain_db: faster fetching of consecutive txes (moneromooo-monero)
2020-04-10 16:01:37 -05:00
luigi1111
44547006bf
Merge pull request #6347
...
fcb06f7
cryptonote_core: skip block notify on blockchain switching rollback (xiphon)
2020-04-04 12:52:46 -05:00
luigi1111
c4f75fe898
Merge pull request #6339
...
c61abf8
remove empty statements (shopglobal)
2020-04-04 12:47:31 -05:00
Alexander Blair
aa982a51da
Merge pull request #6284
...
02224e71
Fix check_fee() discrepancy. (UkoeHB)
2020-03-27 12:21:26 -07:00
Alexander Blair
4da37daf67
Merge pull request #6211
...
5985c5af
rpc: add bad-blocks to flush_cache RPC (moneromooo-monero)
2020-02-28 19:36:16 -08:00
moneromooo-monero
8958b4e7aa
blockchain_db: faster fetching of consecutive txes
...
Useful for wallet refresh or node sync
2020-02-27 15:05:34 +00:00
xiphon
fcb06f7a82
cryptonote_core: skip block notify on blockchain switching rollback
2020-02-19 16:19:29 +00:00
Interchained
c61abf87c0
remove empty statements
...
Cleaning up a little around the code base.
2020-02-17 11:55:15 -05:00
luigi1111
d7aeb5a9f8
Merge pull request #6233
...
8a27645
blockchain: fix flushing txes from the txpool (moneromooo-monero)
2020-02-04 14:38:35 -05:00