Cypher_Stack/wownero
2
0
Fork 0
mirror of https://git.wownero.com/wownero/wownero.git synced 2024-12-22 22:48:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7867

Browse Source 
eed7e79 UB: Not calling virtual method in destructor of WalletImpl (mj-xmr)
This commit is contained in:
luigi1111 2021-10-17 23:26:50 -05:00
commit 19a6cc26fc
No known key found for this signature in database
GPG Key ID: F4ACA0183641E010
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/wallet/api/wallet.cpp
View File

@ -450,7 +450,7 @@ WalletImpl::~WalletImpl()
LOG_PRINT_L1(__FUNCTION__); LOG_PRINT_L1(__FUNCTION__);
m_wallet->callback(NULL); m_wallet->callback(NULL);
// Pause refresh thread - prevents refresh from starting again // Pause refresh thread - prevents refresh from starting again
pauseRefresh(); WalletImpl::pauseRefresh(); // Call the method directly (not polymorphically) to protect against UB in destructor.
// Close wallet - stores cache and stops ongoing refresh operation // Close wallet - stores cache and stops ongoing refresh operation
close(false); // do not store wallet as part of the closing activities close(false); // do not store wallet as part of the closing activities
// Stop refresh thread // Stop refresh thread