Cypher_Stack/wownero
2
0
Fork 0
mirror of https://git.wownero.com/wownero/wownero.git synced 2025-01-08 19:58:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix output shuffling for multisig

Browse Source
This commit is contained in:
stoffu 2018-05-20 09:38:41 +09:00 committed by wowario
parent d78fe99ac6
commit 195e309465
No known key found for this signature in database
GPG Key ID: 24DCBE762DE9C111
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/cryptonote_core/cryptonote_tx_utils.cpp
View File

@ -315,9 +315,10 @@ namespace cryptonote
tx.vin.push_back(input_to_key); tx.vin.push_back(input_to_key);
} }
// "Shuffle" outs if (shuffle_outs)
std::vector<tx_destination_entry> shuffled_dsts(destinations); {
std::shuffle(shuffled_dsts.begin(), shuffled_dsts.end(), std::default_random_engine(crypto::rand<unsigned int>())); std::shuffle(destinations.begin(), destinations.end(), std::default_random_engine(crypto::rand<unsigned int>()));
}
// sort ins by their key image // sort ins by their key image
std::vector<size_t> ins_order(sources.size()); std::vector<size_t> ins_order(sources.size());
@ -364,7 +365,7 @@ namespace cryptonote
uint64_t summary_outs_money = 0; uint64_t summary_outs_money = 0;
//fill outputs //fill outputs
size_t output_index = 0; size_t output_index = 0;
for(const tx_destination_entry& dst_entr: shuffled_dsts) for(const tx_destination_entry& dst_entr: destinations)
{ {
CHECK_AND_ASSERT_MES(dst_entr.amount > 0 || tx.version > 1, false, "Destination with wrong amount: " << dst_entr.amount); CHECK_AND_ASSERT_MES(dst_entr.amount > 0 || tx.version > 1, false, "Destination with wrong amount: " << dst_entr.amount);
crypto::key_derivation derivation; crypto::key_derivation derivation;