Initial Commit #1

2023-04-18T00:01:07Z

detherminal commented

2023-04-18 00:01:07 +00:00

(Migrated from github.com)

This pr adds two endpoints: /themelist and /themedetails/:id

/themelist returns only the name, id, description, primary_color, secondary_color, tertiary_color thats been pulled from /data/themes.json

/themedetails/:id checks the id from /data/themes.json and returns the complete data if matched

The themes.json is not usable for now and it needs to be completed from themes

This pr adds two endpoints: `/themelist` and `/themedetails/:id` `/themelist` returns only the `name, id, description, primary_color, secondary_color, tertiary_color` thats been pulled from `/data/themes.json` `/themedetails/:id` checks the id from `/data/themes.json` and returns the complete data if matched The themes.json is not usable for now and it needs to be completed from [themes](https://github.com/cypherstack/stack_wallet/tree/main/lib/utilities/theme)

Likho commented

2023-04-18 11:16:43 +00:00

(Migrated from github.com)

LGTM

sneurlax (Migrated from github.com) approved these changes 2023-04-19 16:02:07 +00:00

sneurlax (Migrated from github.com) left a comment

I have reviewed this PR and this submission looks safe.

I would request changes, however: more error handling would be good. Anywhere we open a file should be wrapped in some sort of error catching/handling imo

but this looks good

I have reviewed this PR and this submission looks safe. I would request changes, however: more error handling would be good. Anywhere we open a file should be wrapped in some sort of error catching/handling imo but this looks good

Sign in to join this conversation.

No reviewers

sneurlax