Commit Graph

508 Commits

Author SHA1 Message Date
Christophe Fergeau
c8931ab6fc test-prompt: Fix GError leak
https://bugzilla.gnome.org/show_bug.cgi?id=756766
2015-10-19 12:09:50 +02:00
Christophe Fergeau
6fbfb64b17 item: Fix local variable leak in on_create_path()
This fixes:
==22678== 48 bytes in 1 blocks are definitely lost in loss record 1,045 of 1,560
==22678==    at 0x4C28C50: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==22678==    by 0x6002FCC: g_malloc (gmem.c:94)
==22678==    by 0x60032AE: g_malloc_n (gmem.c:330)
==22678==    by 0x601DBF0: g_strdup (gstrfuncs.c:363)
==22678==    by 0x4E6508B: on_create_item_called (secret-paths.c:1991)
==22678==    by 0x5A3346D: g_task_return_now (gtask.c:1104)
==22678==    by 0x5A33575: g_task_return (gtask.c:1162)
==22678==    by 0x5A33E76: g_task_return_pointer (gtask.c:1537)
==22678==    by 0x5A9BB7D: g_dbus_connection_call_done (gdbusconnection.c:5704)
==22678==    by 0x5A3346D: g_task_return_now (gtask.c:1104)
==22678==    by 0x5A334B6: complete_in_idle_cb (gtask.c:1118)
==22678==    by 0x5FFD3D0: g_idle_dispatch (gmain.c:5441)
==22678==    by 0x5FFAA18: g_main_dispatch (gmain.c:3154)
==22678==    by 0x5FFB85C: g_main_context_dispatch (gmain.c:3769)
==22678==    by 0x5FFBA40: g_main_context_iterate (gmain.c:3840)
==22678==    by 0x5FFBE66: g_main_loop_run (gmain.c:4034)
==22678==    by 0x4E7C9E4: loop_wait_until (egg-testing.c:151)
==22678==    by 0x4E7C85C: egg_test_wait_until (egg-testing.c:105)
==22678==    by 0x402D22: test_create_async (test-item.c:245)
==22678==    by 0x60258FA: test_case_run (gtestutils.c:2158)
==22678==    by 0x6025CBB: g_test_run_suite_internal (gtestutils.c:2241)
==22678==    by 0x6025D64: g_test_run_suite_internal (gtestutils.c:2253)
==22678==    by 0x6025F7B: g_test_run_suite (gtestutils.c:2328)
==22678==    by 0x6024C1C: g_test_run (gtestutils.c:1596)
==22678==    by 0x4E7CA3E: egg_tests_run_with_loop (egg-testing.c:167)
==22678==    by 0x406B52: main (test-item.c:887)

https://bugzilla.gnome.org/show_bug.cgi?id=756766
2015-10-19 12:09:50 +02:00
Christophe Fergeau
2c5567cd65 item: Free SecreItem::value in finalize()
This fixes:
==20768== 67 (40 direct, 27 indirect) bytes in 1 blocks are definitely lost in loss record 1,133 of 1,588
==20768==    at 0x4C28C50: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==20768==    by 0x6002FCC: g_malloc (gmem.c:94)
==20768==    by 0x601B523: g_slice_alloc (gslice.c:1007)
==20768==    by 0x601B563: g_slice_alloc0 (gslice.c:1032)
==20768==    by 0x4E5FB64: secret_value_new_full (secret-value.c:140)
==20768==    by 0x4E67B63: service_decode_aes_secret (secret-session.c:457)
==20768==    by 0x4E67D6B: _secret_session_decode_secret (secret-session.c:513)
==20768==    by 0x4E50A61: on_item_load_secret (secret-item.c:1157)
==20768==    by 0x5A3346D: g_task_return_now (gtask.c:1104)
==20768==    by 0x5A33575: g_task_return (gtask.c:1162)
==20768==    by 0x5A33E76: g_task_return_pointer (gtask.c:1537)
==20768==    by 0x5AAC7E6: reply_cb (gdbusproxy.c:2579)
==20768==    by 0x5A3346D: g_task_return_now (gtask.c:1104)
==20768==    by 0x5A33575: g_task_return (gtask.c:1162)
==20768==    by 0x5A33E76: g_task_return_pointer (gtask.c:1537)
==20768==    by 0x5A9BB7D: g_dbus_connection_call_done (gdbusconnection.c:5704)
==20768==    by 0x5A3346D: g_task_return_now (gtask.c:1104)
==20768==    by 0x5A334B6: complete_in_idle_cb (gtask.c:1118)
==20768==    by 0x5FFD3D0: g_idle_dispatch (gmain.c:5441)
==20768==    by 0x5FFAA18: g_main_dispatch (gmain.c:3154)
==20768==    by 0x5FFB85C: g_main_context_dispatch (gmain.c:3769)
==20768==    by 0x5FFBA40: g_main_context_iterate (gmain.c:3840)
==20768==    by 0x5FFBE66: g_main_loop_run (gmain.c:4034)
==20768==    by 0x4E510DA: secret_item_load_secret_sync (secret-item.c:1311)
==20768==    by 0x405238: test_load_secret_sync (test-item.c:592)
==20768==    by 0x60258FA: test_case_run (gtestutils.c:2158)
==20768==    by 0x6025CBB: g_test_run_suite_internal (gtestutils.c:2241)
==20768==    by 0x6025D64: g_test_run_suite_internal (gtestutils.c:2253)
==20768==    by 0x6025F7B: g_test_run_suite (gtestutils.c:2328)
==20768==    by 0x6024C1C: g_test_run (gtestutils.c:1596)
==20768==    by 0x4E7CA25: egg_tests_run_with_loop (egg-testing.c:167)
==20768==    by 0x406B52: main (test-item.c:887)

https://bugzilla.gnome.org/show_bug.cgi?id=756766
2015-10-19 12:09:50 +02:00
Christophe Fergeau
4a7de5a403 test-item: Fix string leaks
This fixes:

==16901== 7 bytes in 1 blocks are definitely lost in loss record 9 of 1,154
==16901==    at 0x4A06C50: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==16901==    by 0x36E564F679: g_malloc (gmem.c:97)
==16901==    by 0x36E56688AE: g_strdup (gstrfuncs.c:356)
==16901==    by 0x4C3098F: secret_item_get_label (secret-item.c:1922)
==16901==    by 0x402A65: test_create_sync (test-item.c:203)
==16901==    by 0x36E566FB92: test_case_run (gtestutils.c:2124)
==16901==    by 0x36E566FB92: g_test_run_suite_internal (gtestutils.c:2185)
==16901==    by 0x36E566FD5A: g_test_run_suite_internal (gtestutils.c:2196)
==16901==    by 0x36E56700DA: g_test_run_suite (gtestutils.c:2249)
==16901==    by 0x36E5670110: g_test_run (gtestutils.c:1553)
==16901==    by 0x4C5A0EA: egg_tests_run_with_loop (egg-testing.c:167)
==16901==    by 0x406AAE: main (test-item.c:880)
==16901==-
==16901== 7 bytes in 1 blocks are definitely lost in loss record 10 of 1,154
==16901==    at 0x4A06C50: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==16901==    by 0x36E564F679: g_malloc (gmem.c:97)
==16901==    by 0x36E56688AE: g_strdup (gstrfuncs.c:356)
==16901==    by 0x4C3098F: secret_item_get_label (secret-item.c:1922)
==16901==    by 0x402DB6: test_create_async (test-item.c:249)
==16901==    by 0x36E566FB92: test_case_run (gtestutils.c:2124)
==16901==    by 0x36E566FB92: g_test_run_suite_internal (gtestutils.c:2185)
==16901==    by 0x36E566FD5A: g_test_run_suite_internal (gtestutils.c:2196)
==16901==    by 0x36E56700DA: g_test_run_suite (gtestutils.c:2249)
==16901==    by 0x36E5670110: g_test_run (gtestutils.c:1553)
==16901==    by 0x4C5A0EA: egg_tests_run_with_loop (egg-testing.c:167)
==16901==    by 0x406AAE: main (test-item.c:880)
==16901==-

https://bugzilla.gnome.org/show_bug.cgi?id=756766
2015-10-19 12:09:50 +02:00
Christophe Fergeau
66888a1e6a test-item: Fix GHashTable leak
This fixes:
==16901== 248 (88 direct, 160 indirect) bytes in 1 blocks are definitely lost in loss record 1,108 of 1,154
==16901==    at 0x4A06C50: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==16901==    by 0x36E564F679: g_malloc (gmem.c:97)
==16901==    by 0x36E5666CD2: g_slice_alloc (gslice.c:1007)
==16901==    by 0x36E563860D: g_hash_table_new_full (ghash.c:711)
==16901==    by 0x4047B2: test_set_attributes_async (test-item.c:493)
==16901==    by 0x36E566FB92: test_case_run (gtestutils.c:2124)
==16901==    by 0x36E566FB92: g_test_run_suite_internal (gtestutils.c:2185)
==16901==    by 0x36E566FD5A: g_test_run_suite_internal (gtestutils.c:2196)
==16901==    by 0x36E56700DA: g_test_run_suite (gtestutils.c:2249)
==16901==    by 0x36E5670110: g_test_run (gtestutils.c:1553)
==16901==    by 0x4C5A0EA: egg_tests_run_with_loop (egg-testing.c:167)
==16901==    by 0x406AAE: main (test-item.c:880)

https://bugzilla.gnome.org/show_bug.cgi?id=756766
2015-10-19 12:09:50 +02:00
Christophe Fergeau
cd96ccffcd test-item: Fix GError leak
This fixes:
==16901== 94 (16 direct, 78 indirect) bytes in 1 blocks are definitely lost in loss record 901 of 1,154
==16901==    at 0x4A06C50: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==16901==    by 0x36E564F679: g_malloc (gmem.c:97)
==16901==    by 0x36E5666CD2: g_slice_alloc (gslice.c:1007)
==16901==    by 0x36E563522B: g_error_new_valist (gerror.c:386)
==16901==    by 0x36E563560A: g_set_error (gerror.c:560)
==16901==    by 0x4C2CFB2: secret_item_initable_init (secret-item.c:480)
==16901==    by 0x36E6E5D83E: g_initable_new_valist (ginitable.c:228)
==16901==    by 0x36E6E5D8F5: g_initable_new (ginitable.c:146)
==16901==    by 0x4C3E711: secret_item_new_for_dbus_path_sync (secret-paths.c:286)
==16901==    by 0x402506: test_new_sync_noexist (test-item.c:121)
==16901==    by 0x36E566FB92: test_case_run (gtestutils.c:2124)
==16901==    by 0x36E566FB92: g_test_run_suite_internal (gtestutils.c:2185)
==16901==    by 0x36E566FD5A: g_test_run_suite_internal (gtestutils.c:2196)
==16901==    by 0x36E56700DA: g_test_run_suite (gtestutils.c:2249)
==16901==    by 0x36E5670110: g_test_run (gtestutils.c:1553)
==16901==    by 0x4C5A0EA: egg_tests_run_with_loop (egg-testing.c:167)
==16901==    by 0x406AAE: main (test-item.c:880)

https://bugzilla.gnome.org/show_bug.cgi?id=756766
2015-10-19 12:09:50 +02:00
Christophe Fergeau
a2e76aede7 Fix 'attributes' typo in API doc
https://bugzilla.gnome.org/show_bug.cgi?id=756766
2015-10-19 12:09:50 +02:00
Christophe Fergeau
1be4264b76 secret-item: Fix 'convenince' typo
https://bugzilla.gnome.org/show_bug.cgi?id=756766
2015-10-19 12:09:50 +02:00
Arash Mousavi
4d76cf7dd8 Add Persian translation 2015-09-17 01:19:35 +04:30
Stef Walter
43b7633993 Add gnome.org install command to 'make upload-release' 2015-08-03 09:33:26 +02:00
Stef Walter
bcb4091715 Bump version 2015-08-03 09:18:43 +02:00
Pedro Albuquerque
0e7c6ec52e Updated Portuguese translation 2015-07-01 22:01:54 +00:00
Stef Walter
4c08fe2933 docs: Don't overcomplicate things with the major version in docs
Just hard code '1' instead of using variable substitution.

https://bugzilla.gnome.org/show_bug.cgi?id=751400
2015-06-29 14:41:49 +02:00
Daniel Șerbănescu
5f6126da7b Added Romanian Translation 2015-06-22 17:14:30 +02:00
Stef Walter
55d57de44a Bump to 0.18.2
Actual 0.18.2 release is not on master branch.
2015-04-28 15:44:03 +02:00
Cédric Valmary
d5eb5b6176 Added Occitan translation 2015-04-28 13:37:13 +00:00
Frédéric Péters
d2a87b5148 Update doc online location to unstable url
developer.gnome.org doesn't create /stable/ links for libraries that have not
reached 1.0 yet.
2015-04-15 11:49:59 +02:00
Stef Walter
ad77f143e6 libsecret: Fix up the tests for recent regressions 2015-04-14 10:48:19 +02:00
Roy Zhang
70d1bc3307 Fix typo in documentation
Since "equivalent" is not a function, it should not follow with
parenthese.

https://bugzilla.gnome.org/show_bug.cgi?id=747654
2015-04-11 07:29:05 +02:00
Samir Ribic
d0690e2504 Added Bosnian translation 2015-03-13 21:02:18 +00:00
Vamsi Krishna Brahmajosyula
e5ddb9d2df Updated autogen.sh to allow automake version 1.15
https://bugzilla.gnome.org/show_bug.cgi?id=743444
2015-01-25 08:21:44 +01:00
Stef Walter
e8a2b3cd5a Add license headers to enum template files 2014-12-04 22:50:26 +01:00
Baurzhan Muftakhidinov
9e135d9eb2 Added Kazakh translation 2014-10-28 05:58:15 +00:00
Mosaab Alzoubi
bfe9f35140 Added Arabic translation 2014-10-06 09:20:46 +01:00
Stef Walter
d205542ba3 Fix for GObject-Introspection annotation changes
The GTK-Doc form of annotations is deprecated.
2014-09-09 15:18:33 +02:00
Stef Walter
5e2fe4afaa egg: Accomodate thread-safe libgcrypt 1.6+
libcrypt no longer supports setting our own threading callbacks,
and is thread-safe if we call gcry_check_version() before creating
threads.

Unfortunately we can't guarantee that we call gcry_check_version()
early enough, we try our best. Most of the callers of libsecret either
don't use libgcrypt, or also initialize it appropriately themselves.

Bump libgcrypt dependency to 1.4.5+, and have earlier versions use
the native pthread implementation of locking.
2014-09-09 15:18:33 +02:00
Stef Walter
c91de25db1 configure: Use subdir-objects to shut up automake 1.14 2014-09-09 15:18:33 +02:00
Mattias Eriksson
4ec854f6e0 Added Swedish translation 2014-08-31 11:14:38 +00:00
Piotr Drąg
e268df59d5 doap: add <programming-language> 2014-07-31 19:39:33 +02:00
Olav Vitters
833f3c3485 doap category core 2014-07-30 20:32:20 +02:00
Tom Tryfonidis
2f09a9a34c Updated Greek translation 2014-07-09 23:20:48 +00:00
Muhammet Kara
5c4f25f1f5 Updated Turkish translation 2014-05-30 22:08:06 +00:00
Muhammet Kara
0a816b5068 Added Turkish translation 2014-05-30 21:55:54 +00:00
Piotr Drąg
b882a69150 doap: update URLs 2014-04-06 18:10:13 +02:00
Inaki Larranaga Murgoitio
a8f98f0314 Added Basque language\nAdded 'eu' (Basque) to LINGUAS 2014-04-03 17:47:20 +02:00
Stef Walter
cf94c7661d Release version 0.18.1 2014-03-23 08:59:42 +01:00
Stef Walter
d418a2dfc4 build: Use /usr/bin/env to find python during tests 2014-03-23 08:59:12 +01:00
Stef Walter
0c8b680004 Release version 0.18 2014-03-06 21:38:52 +01:00
Stef Walter
083902c185 tap-gtester: Set a standard environment variable for test harness
Lets tests know whether they're running under an automated
testing harness.
2014-03-06 12:50:46 +01:00
Stef Walter
c28233973b Makefile.am: Don't build tests during normal builds
This makes things build faster, and also fixes issues
I can't reproduce with vala and gir.

https://bugzilla.gnome.org/show_bug.cgi?id=725690
2014-03-06 12:48:48 +01:00
Stef Walter
068e80451b Makefile.am: Fix make distcheck again 2014-03-05 12:59:48 +01:00
Stef Walter
0d116b7177 libsecret: Fix uninitialized access in _secret_attributes_validate() 2014-03-05 12:59:48 +01:00
Stef Walter
fb4de0e52a glib.supp: Add valgrind suppression of uninitiaziled sigaction 2014-03-05 12:59:48 +01:00
Stef Walter
f089662a9f Makefile.am: Add check-memory target for valgrind testing
Update the test-driver to accomodate this and figure out
how best to implement this.

Fix up 'make recheck' as well.
2014-03-05 12:59:46 +01:00
Stef Walter
b00658d308 test-driver: Use a single driver which supports both tap and simple
Rename our GTest tap compiler so it's clearer what's going on.
2014-03-05 10:12:00 +01:00
Stef Walter
460d36e32c Makefile.am: Look in $builddir for headers when building vala tests 2014-03-04 23:42:42 +01:00
Stef Walter
7d58d2d2b0 Makefile.am: Fix typo in last commit 2014-03-04 22:22:10 +01:00
Stef Walter
f9a32fb043 Makefile.am: Add dependencies on vapis from vala tests 2014-03-04 21:55:07 +01:00
Stef Walter
b24d7d78f7 Makefile.am: Get the dependencies of libsecret-testable.so right 2014-03-04 21:23:58 +01:00
Stef Walter
5910155863 Makefile.am Fix build of vala tests
valac is very hard to make happy
2014-03-04 21:20:41 +01:00