From 9472b0ab390d3a3be3d58691db06ee11977f0bff Mon Sep 17 00:00:00 2001 From: Daiki Ueno Date: Sat, 3 Apr 2021 06:50:37 +0200 Subject: [PATCH] secret-tool: Fix secret_password_clearv_sync return value check This was a regression introduced in the rewrite using the simple API (commit 6886aebb0457d752f348a4cedc5a11ce109544ee). Reported by Chih-Hsuan Yen in: https://gitlab.gnome.org/GNOME/libsecret/-/issues/56 Signed-off-by: Daiki Ueno --- tool/secret-tool.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tool/secret-tool.c b/tool/secret-tool.c index 5d95194..9335e37 100644 --- a/tool/secret-tool.c +++ b/tool/secret-tool.c @@ -142,7 +142,10 @@ secret_tool_action_clear (int argc, g_hash_table_unref (attributes); if (!ret) { - g_printerr ("%s: %s\n", g_get_prgname (), error->message); + if (error != NULL) { + g_printerr ("%s: %s\n", g_get_prgname (), error->message); + g_error_free (error); + } return 1; } @@ -215,6 +218,7 @@ secret_tool_action_lookup (int argc, if (error != NULL) { g_printerr ("%s: %s\n", g_get_prgname (), error->message); + g_error_free (error); return 1; } @@ -482,6 +486,7 @@ secret_tool_action_search (int argc, if (error != NULL) { g_printerr ("%s: %s\n", g_get_prgname (), error->message); + g_error_free (error); return 1; }