Cypher_Stack/libsecret
2
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/libsecret.git synced 2024-12-22 04:38:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix issues flagged by static analyzers

Browse Source 
These changes specifically fix the issues flagged by clang-analyzer.
Fixes: #59
This commit is contained in:
Dhanuka Warusadura 2021-03-31 13:02:32 +05:30 committed by Daiki Ueno
parent 127f326a2d
commit 7e713cf65a
3 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libsecret/secret-collection.c
View File

@ -1560,8 +1560,6 @@ secret_collection_search_sync (SecretCollection *self,
if (paths == NULL) if (paths == NULL)
return NULL; return NULL;
ret = TRUE;
want = 1; want = 1;
if (flags & SECRET_SEARCH_ALL) if (flags & SECRET_SEARCH_ALL)
want = G_MAXINT; want = G_MAXINT;

6
libsecret/secret-service.c
View File

@ -1140,9 +1140,6 @@ secret_service_open (GType service_gtype,
g_return_if_fail (cancellable == NULL || G_IS_CANCELLABLE (cancellable)); g_return_if_fail (cancellable == NULL || G_IS_CANCELLABLE (cancellable));
g_return_if_fail (g_type_is_a (service_gtype, SECRET_TYPE_SERVICE)); g_return_if_fail (g_type_is_a (service_gtype, SECRET_TYPE_SERVICE));
if (service_bus_name == NULL)
service_bus_name = get_default_bus_name ();
g_async_initable_new_async (service_gtype, G_PRIORITY_DEFAULT, g_async_initable_new_async (service_gtype, G_PRIORITY_DEFAULT,
cancellable, callback, user_data, cancellable, callback, user_data,
"flags", flags, "flags", flags,
@ -1217,9 +1214,6 @@ secret_service_open_sync (GType service_gtype,
g_return_val_if_fail (cancellable == NULL || G_IS_CANCELLABLE (cancellable), NULL); g_return_val_if_fail (cancellable == NULL || G_IS_CANCELLABLE (cancellable), NULL);
g_return_val_if_fail (g_type_is_a (service_gtype, SECRET_TYPE_SERVICE), NULL); g_return_val_if_fail (g_type_is_a (service_gtype, SECRET_TYPE_SERVICE), NULL);
if (service_bus_name == NULL)
service_bus_name = get_default_bus_name ();
return g_initable_new (service_gtype, cancellable, error, return g_initable_new (service_gtype, cancellable, error,
"flags", flags, "flags", flags,
NULL); NULL);

5
libsecret/test-methods.c
View File

@ -727,6 +727,7 @@ test_store_sync (Test *test,
ret = secret_service_store_sync (test->service, &MOCK_SCHEMA, attributes, collection_path, ret = secret_service_store_sync (test->service, &MOCK_SCHEMA, attributes, collection_path,
"New Item Label", value, NULL, &error); "New Item Label", value, NULL, &error);
g_assert_true (ret);
g_assert_no_error (error); g_assert_no_error (error);
secret_value_unref (value); secret_value_unref (value);
g_hash_table_unref (attributes); g_hash_table_unref (attributes);
@ -776,10 +777,12 @@ test_store_replace (Test *test,
ret = secret_service_store_sync (test->service, &MOCK_SCHEMA, attributes, collection_path, ret = secret_service_store_sync (test->service, &MOCK_SCHEMA, attributes, collection_path,
"New Item Label", value, NULL, &error); "New Item Label", value, NULL, &error);
g_assert_true (ret);
g_assert_no_error (error); g_assert_no_error (error);
ret = secret_service_store_sync (test->service, &MOCK_SCHEMA, attributes, collection_path, ret = secret_service_store_sync (test->service, &MOCK_SCHEMA, attributes, collection_path,
"Another Label", value, NULL, &error); "Another Label", value, NULL, &error);
g_assert_true (ret);
g_assert_no_error (error); g_assert_no_error (error);
secret_value_unref (value); secret_value_unref (value);
g_hash_table_unref (attributes); g_hash_table_unref (attributes);
@ -829,6 +832,7 @@ test_store_async (Test *test,
egg_test_wait (); egg_test_wait ();
ret = secret_service_store_finish (test->service, result, &error); ret = secret_service_store_finish (test->service, result, &error);
g_assert_true (ret);
g_assert_no_error (error); g_assert_no_error (error);
g_object_unref (result); g_object_unref (result);
@ -877,6 +881,7 @@ test_store_no_default (Test *test,
ret = secret_service_store_sync (test->service, &MOCK_SCHEMA, attributes, SECRET_COLLECTION_DEFAULT, ret = secret_service_store_sync (test->service, &MOCK_SCHEMA, attributes, SECRET_COLLECTION_DEFAULT,
"New Item Label", value, NULL, &error); "New Item Label", value, NULL, &error);
g_assert_true (ret);
g_assert_no_error (error); g_assert_no_error (error);
secret_value_unref (value); secret_value_unref (value);
g_hash_table_unref (attributes); g_hash_table_unref (attributes);