Cypher_Stack/libsecret
2
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/libsecret.git synced 2024-12-22 04:38:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

file-backend: avoid deadlock when portal op is canceled

Browse Source 
Calling g_cancellable_disconnect() inside a cancelled handler is a
guaranteed deadlock. Cancellables should only be canceled once, so we
don't need to worry about a second cancellation occurring. I think it's
sufficent to disconnect when the InitClosure is freed.

Fixes #86
This commit is contained in:
Michael Catanzaro 2023-04-25 19:17:22 -05:00
parent ecb788d44e
commit 0e205fce5f
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
libsecret/secret-file-backend.c
View File

@ -206,6 +206,7 @@ typedef struct {
GDBusConnection *connection;
gchar *request_path;
guint portal_signal_id;
GCancellable *cancellable;
gulong cancellable_signal_id;
} InitClosure;
@ -218,6 +219,14 @@ init_closure_free (gpointer data)
g_clear_pointer (&init->buffer, egg_secure_free);
g_clear_object (&init->connection);
g_clear_pointer (&init->request_path, g_free);
if (init->cancellable_signal_id) {
g_cancellable_disconnect (init->cancellable, init->cancellable_signal_id);
init->cancellable_signal_id = 0;
}
/* Note: do not cancel the cancellable here! That's for the API user to
* do. We're just keeping track of it here so we can disconnect.
*/
g_clear_object (&init->cancellable);
g_free (init);
}
@ -352,9 +361,6 @@ on_portal_cancel (GCancellable *cancellable,
cancellable,
on_portal_request_close,
task);
g_cancellable_disconnect (cancellable, init->cancellable_signal_id);
init->cancellable_signal_id = 0;
}
static void
@ -575,6 +581,7 @@ secret_file_backend_real_init_async (GAsyncInitable *initable,
init = g_new0 (InitClosure, 1);
init->io_priority = io_priority;
init->file = file;
init->cancellable = g_object_ref (cancellable);
g_task_set_task_data (task, init, init_closure_free);
g_bus_get (G_BUS_TYPE_SESSION, cancellable, on_bus_get, task);
} else {